Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kChph-0008Rz-6V for pgadmin-hackers@arkaria.postgresql.org; Mon, 31 Aug 2020 11:18:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kChpg-0006LF-42 for pgadmin-hackers@arkaria.postgresql.org; Mon, 31 Aug 2020 11:18:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kChpf-0006L8-P2 for pgadmin-hackers@lists.postgresql.org; Mon, 31 Aug 2020 11:18:39 +0000 Received: from mail-il1-x135.google.com ([2607:f8b0:4864:20::135]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kChpd-0008Bp-3w for pgadmin-hackers@postgresql.org; Mon, 31 Aug 2020 11:18:39 +0000 Received: by mail-il1-x135.google.com with SMTP id m1so666312ilj.10 for ; Mon, 31 Aug 2020 04:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7BaZMLktbfTcSsC5FZY3+yT1g3jYDnjLhsGttiB/65M=; b=Oj2O5v1Ks3j/xohQ2x4jfqD2mOZPDZb6yXSqKp5QMi66HMgutEcuvKH9lmSvJ8vOV8 ZaMbLViZUhqaf+X4GgvDcMOY/BDZTIuy6pBDj30VH9foWH/OJ32AENgGlg2oo6v4SLUe jCj5OvR5MrRAmuebpxK8nr1R3ZlQ4674ozgScHSMYYCnRf7pmeb+UV3qHfyGX1qHOpWB b2cVbwuqRjKuBSssXlahrZVQVyV6OCk4UGEhzMT5pcFkO6K5YwtVf4RxcUBLigrP3BlU YlC8e5selwT1KGgeUUD+AYkuN/7usKXSBuSY9W8yeCrVd8vPUenezJtcw7opsE/DzDoQ SbFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7BaZMLktbfTcSsC5FZY3+yT1g3jYDnjLhsGttiB/65M=; b=t/SL73zqZS7C7Sy1GetaQXqVfd1qoEIOBTf2Z9rVw8MrKU2Gz1u6OqaUj/X0jYNOuC 36b30CQStV+lUXDysqczCQza1FtYsdngqfW9TfIfDKf16X/D1R1haPatY7efwkSANRkn P/5dOWCO3dSxePHv7TsFMqJ136uyA+/nvfJcn5dhFtJIolxorZHr11o5fpkqSW4Oj81y ipqpVBOlNqTj2sxQ10ODorHJhjUNrNuXvGQ/fIo59Xje4T4tsnFSMPotjMyFhIWvtNNU /izTR9MNnfdPJq3m9dH3mQxSgi68CPc+6mCcdm9OYouOrFu+qU+/Z5UaOtaQaKawnVwZ rCgA== X-Gm-Message-State: AOAM5309Qlcm3+gQQU6GDP0UpeoPD0JPCph8Jzh7T0IoEflmZz36ow33 a6QnYuNCCk62739N1tKeqfjKV0RiHZudmKwqUmrxVLp88xO12AWFPUO2yMhpoD7J66Ikgbzjoio PodX/vwqR98B6xUHGefCVKVQpsZD9O6DslSal4C5WmpXPNZ5rwdpvPLUltVS6hsyxJ9LEF9PyQu BhGZ/1GTHzhG+067yrctRfBpdtNRvm/Gk9ruWsqEpOvSEDGhbcH74L/iMtiw== X-Google-Smtp-Source: ABdhPJwrF1ehL+vEJbWgJ1tPiavxa8yuUqpsz/pe3KEnAFu9zNTHBcV8jw1qjoFK3egZnXTr+OdKJiuq7MAt3N5tQfM= X-Received: by 2002:a92:248:: with SMTP id 69mr904166ilc.236.1598872710404; Mon, 31 Aug 2020 04:18:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 31 Aug 2020 16:48:17 +0530 Message-ID: Subject: Re: More idiomatic python3 + fix some tests To: Cyril Jouve Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000037a2405ae2a9078" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000037a2405ae2a9078 Content-Type: text/plain; charset="UTF-8" Hi Cyril Thanks, patch applied. Please make sure to run "yarn run pep8" before sending the patch. On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve wrote: > Hello, > > patch 1 to 6 generated mostly using 2to3: > 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts > 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter > 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms > 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass > 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange > 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode > > patch 7 fixes change_password tests: > Less that min length : min is 8 instead of 6 > Valid password : use an user different than admin user / mock mail module > > patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using simplejson > like in all other modules). > > Regards, > Cyril > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000037a2405ae2a9078 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Cyril

Thanks, patch appli= ed. Please make sure to run "yarn run pep8" before sending the pa= tch.

On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve <jv.cyril@gmail.com> wrote:
Hello,

patch 1 to 6 generated mostly using 2to3:
0001: https://docs.python.org/3.8/library/2to3.html#2to= 3fixer-asserts
Valid password := use an user different than admin user / mock mail module

patch 8 fixes ConstraintDeleteMultipleT= estCase on py3.10 (using simplejson like in all other modules).

Regards,
Cyril


--
Thanks & Regards
Akshay Joshi
<= div>pgAdmin Hacker | = Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

<= /div>
--000000000000037a2405ae2a9078--