Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhG4x-0006ZS-Gt for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Sep 2016 13:06:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bhG4w-0004nq-Gn for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Sep 2016 13:06:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bhG4j-0004ZY-8Y for pgadmin-hackers@postgresql.org; Tue, 06 Sep 2016 13:06:05 +0000 Received: from mail-yb0-x231.google.com ([2607:f8b0:4002:c09::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bhG4d-0006ap-MT for pgadmin-hackers@postgresql.org; Tue, 06 Sep 2016 13:06:04 +0000 Received: by mail-yb0-x231.google.com with SMTP id g5so16508387yba.2 for ; Tue, 06 Sep 2016 06:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=98nG1wDLLpr/q5gj/BTK9Tm9e9CBl4Shil/tvZ1NkTQ=; b=blNUrH2TCNKpnCwcazVP5UR34XslFu/yr8J7dlXyUvfVic6XHRZeyrTfR0Vp0J72cO LYvadg8Wuu0LUMWh2zr4VNDhzivzHV4ju2xoRITgzLy0hDqpz6hOWFdVYLQ2WOXfA+j3 iydoEpNBBFnETVxh/3C8Y76Ku8b5EMCg+VvgdGet/LEuXIh+dPTBSSTvT0BtK8MfBN+U 81fjIZbe9Ub0VvnFmHmAa2oa8IRjRtgrYQ2kzZGFQzDGS6hZJBTcS3sKbAgVfj34rldw tWl/7mgpkK64SpU/9zKody7MopLT6WzZFa0iZT9LRko8JPd7G2cLCF6ciLntiQjCX+gK R4sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=98nG1wDLLpr/q5gj/BTK9Tm9e9CBl4Shil/tvZ1NkTQ=; b=nJx/NjkaCYGYWfF3LPFMWjfXoRx8XmPGnV266iCYhUTJrlo3bm6lHAtA+63bq8l+/m Ey2bIOkjsrpCxmUDJBJUkm5nPGqSQyq6cSQNH4r7kezR85pMT/dzFl8fhcC4J1wNZue9 W8HsEQIyA6aDKI3xcEnQa7EPxz6l1tLGhIiTK8EtkasGrz0hmb4a7DBmFYUmupXgdKEB q+6h4p3ngzmfyAGUODKAunYdi7Z8XXHClzoXD2fTkMKJGkNNv9NL+zYPseHy4+bhSGRk VKZ5MBhRBleSlFTMLpGnz2EjgnukYw/sdtq6v4f+zKIxDxZsf/XCwZZOWzC6QM6W5EHF s4+A== X-Gm-Message-State: AE9vXwMSLAmB8uPaalhRIbrUJ5XIT4WomLX0cKDW0L1uyY1fc7UU+L0U18bMvHEOJU+cYebxBXf2WnD/nT+3d/Kf X-Received: by 10.107.47.213 with SMTP id v82mr4490291iov.144.1473167157918; Tue, 06 Sep 2016 06:05:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.19.206 with HTTP; Tue, 6 Sep 2016 06:05:57 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Tue, 6 Sep 2016 18:35:57 +0530 Message-ID: Subject: Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server To: Dave Page Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1135464824be35053bd6753b X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1135464824be35053bd6753b Content-Type: text/plain; charset=UTF-8 Code looks good to me. Patch applied. On Tue, Sep 6, 2016 at 12:05 PM, Akshay Joshi wrote: > > > On Fri, Sep 2, 2016 at 7:49 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> > > Sure. > >> >> Thanks. >> >> On Tue, Aug 30, 2016 at 5:05 PM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> On Tue, Aug 30, 2016 at 7:16 PM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Please find the add-on patch on top of the current change. >>>> >>>> Can you please take a look at it? >>>> This mainly works on the postgres driver to make an attempt to >>>> reconnect the server. >>>> >>> >>> One more attempt with some more corner cases handling. >>> * Handled the connection-lost, and object gone error on client side >>> during 'refresh' operation. >>> * Handle the reconnection more consistently (even during cursor object >>> creation). >>> >>> Please take a look at it. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a1135464824be35053bd6753b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Code looks good to me. Patch applied.=C2=A0

On Tue, Sep 6, 2016 at 12:= 05 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Fri, S= ep 2, 2016 at 7:49 PM, Dave Page <dpage@pgadmin.org> wrote:<= br>
Akshay, can you review/c= ommit this please?=C2=A0

=C2= =A0 =C2=A0 Sure.=C2=A0

Thanks.

On Tue, Aug 30, 2= 016 at 5:05 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

= Please find the add-on patch on top of the current change.

Can you please take a look at it?
This mainly works on t= he postgres driver to make an attempt to reconnect the server.
<= /blockquote>

One more attempt with some more corner ca= ses handling.
* Handled the connection-lost, and object gone error on c= lient side during 'refresh' operation.
* Handle the recon= nection more consistently (even during cursor object creation).
<= br>
Please take a look at it.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshv= ashi


<= span style=3D"font-style:italic">--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company=


http://www.linkedin.com/in/asheshvashi





<= font color=3D"#888888">--
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer=C2=A0
<= br>

Phone: +91 20-3= 058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246
--001a1135464824be35053bd6753b--