Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMPy1-0002Jt-Ls for pgadmin-hackers@arkaria.postgresql.org; Thu, 09 Apr 2020 05:43:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMPxz-0003J1-DJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 09 Apr 2020 05:43:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMPxz-0003Iu-3t for pgadmin-hackers@lists.postgresql.org; Thu, 09 Apr 2020 05:43:07 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jMPxq-0000T5-Fy for pgadmin-hackers@lists.postgresql.org; Thu, 09 Apr 2020 05:43:06 +0000 Received: by mail-io1-xd43.google.com with SMTP id u2so2636447iop.10 for ; Wed, 08 Apr 2020 22:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9Rfz/3Mv11m5kJz2HIUSYBXFVuJNaif4tZWucETLuyU=; b=cxZbK4P2pCcmjNg/Q70qbKnUQbvS7NFP7TECK3WV32yN3h0I0yoPzMXOl1y+j8FjM/ 71/IliGmR2e6kFwCIo9GYORHpg9KQNMdCiuTzUFZxcP+iK4isq13w0rns11Yt3V1AwuL BPoq6xBPCgI21SB83cqe/XfQLlpMV+QxAWzKfPGoQVAqWhm5t3f36VDdhRtO/y7PS0+b 6glgcRI3b62zjaiqOrcJD/KW5yBsM+yWPdoF9bKRWgTXAUkNowsU/RhniGjsGF4fi1Ob yZ9Kx3K7MYWso1ljjYTIxFqp/ZXSUfbJBQz9dU4Qf+/EZwTEsGMVLo3mEVQWeuKySYrZ K3Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9Rfz/3Mv11m5kJz2HIUSYBXFVuJNaif4tZWucETLuyU=; b=cqXwNdTcBbDptsN4KCDOISr5sp4gOLyZDFJaXPQ9HrB37udTDiyUSI4vLA/V7Liw6G dD4EuGaGOPMenh1olZ2TEPj++Yh6wibBcaOWVrCcaeWMUKnfavJjjo2UD8oRFLucsTcY bwWbSbWP0urT6l47PDG/uRVMUfb4z+QlDQ3ZNOMlGyonrJP3F43hTO1Jm+zEvmu8DemG z6X7D90QH5k5Q8CKO8sOLHEmO42ITjJFawkBPjkS+2nc52SApVmik6cC6g0WqsI193GI SiTumGvc7RKh32aOdI4g16qMTGY7qbOokUBsOFtXNKqykKKj0jn8ZBU1uTiewdlrOUGU kVtw== X-Gm-Message-State: AGi0PuagXmatkYVgj6pgfcikRSu0OIEnFboXqiQPndc431yuChvgn3d6 4jAn0kYLaVxlkERxHO+UNAQnedGnk4L1YXX25ZzK+24HVRq7cYXm1uBYxhq0IOdqkJLrxr8c1Kk maxTFavpGQ56E4fjDDFZ0OM1vLXAH3kaMLmVSVANJDmGB473MhIwl0Kmp2nnn5a+5BZDKLn0rod Z7a4AM5L0YEKTW3w76yjPvJ+BrZUmBiVIfy1IDNcl1T+SHXykwoywTWT6TIoOidHowjbY= X-Google-Smtp-Source: APiQypJ7IroO0p8LtMME998zw8okOdo+E32Qpwae4ktXBWrCjG596hSqqOolYKLCcgZQyRYbKGahA5G7iqMyjmEsE+4= X-Received: by 2002:a02:8666:: with SMTP id e93mr1159909jai.0.1586410976039; Wed, 08 Apr 2020 22:42:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 9 Apr 2020 11:12:45 +0530 Message-ID: Subject: Re: RM4292 - Dark mode support for Windows/macOS To: Neel Patel Cc: pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="000000000000b1f0cb05a2d5168a" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b1f0cb05a2d5168a Content-Type: text/plain; charset="UTF-8" Neel, Can you please review/test it? On Wed, Apr 8, 2020 at 9:08 PM Dave Page wrote: > The attached patch detects if dark mode is enabled on Windows (10+)/macOS > (10.14+) at server start, and styles the runtime accordingly. It doesn't > dynamically switch if the user changes their preferences. > > Linux builds continue to use the standard styling from Qt. > > NOTE: I've tested this on macOS, but my Windows build system is playing up > at the moment. Akshay, can you have someone on your team test it please? I > believe the code should work; it's just a case of reading a reg key and > then doing the same thing as on macOS to set the theme accordingly. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000b1f0cb05a2d5168a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Neel,=C2=A0

Can you please review/test = it?

On Wed, Apr 8, 2020 at 9:08 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch detect= s if dark mode is enabled on Windows (10+)/macOS (10.14+) at server start, = and styles the runtime accordingly. It doesn't dynamically=C2=A0switch = if the user changes their preferences.

Linux builds=C2= =A0continue to use the standard styling from Qt.

N= OTE: I've tested this on macOS, but my Windows build system is playing = up at the moment. Akshay, can you have someone on your team test it please?= I believe the code should work; it's just a case of reading a reg key = and then doing the same thing as on macOS to set the theme accordingly.

--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000b1f0cb05a2d5168a--