Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9QoS-0004by-Oj for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 11:04:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9QoR-0007SH-KL for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 11:04:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9QoR-0007SA-0j for pgadmin-hackers@lists.postgresql.org; Tue, 09 Feb 2021 11:04:07 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9QoN-0004fl-Gs for pgadmin-hackers@postgresql.org; Tue, 09 Feb 2021 11:04:05 +0000 Received: by mail-io1-xd2f.google.com with SMTP id u20so18276204iot.9 for ; Tue, 09 Feb 2021 03:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lqz2CpiydlpHn1ta3NS1fK/5NJaqe+WpqUpthf2/6t0=; b=lmFMI+LTj34GLbBgwCHs/cT6y9s5x0XSnzYF+tmjXAsglzw1F8sSfbbqgsQw1OItc8 UHmkF4q6qxxqzMLO7c1iGfK7JNdlBMa+CBkR2u0SY+WwDU8kxCDeYvtOaeMlkE/HJbOD eSxtVL3zAphPUdDFSyk2/y0hsukC3+/YkJhhtxiwshMpGbmWB82Tw1c23uyxgFFOIOcw Ewo+rXXiLAv69k6BH+MVyyoL4lx4WxXlxO61Xorb0QwKvRGMBUZIEZIln+aMBoOfhR66 HVLMqSkbShTnY/FM7cyj98jjrKvQX4umezYQRSUR7Dt65dR276jWgQ+HLM19IcXn1F+4 IMqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lqz2CpiydlpHn1ta3NS1fK/5NJaqe+WpqUpthf2/6t0=; b=sHEP1CKfcAvy7QypQzcTXLH+vgn+Zh9+Hh1rAHMmSyOgiNGpSrR/QgDcAEowc8a2PB xVE2xb9DxNrg5kMDVJVpPslJN6hAXzf2TFaiikp/QPKlEllkEiCCdVoDWPFkyv+kFxXu N1Y5kTaFTOt+gnKGvwJ+G/c05vom4EKXFVbVz5DosLxRZQ3YUHftOImGF1/aYeg5EVep p8N81EdjtB6SQ0IGMJG9mzH+rvG6S58fl2lrFn+bM1gqOGaVHrLoNqdnPHbt/3qNXqxb XWG2tz7aJ/UNLI0P/ilTyhIfCCj6wQTCXiU619r7t/y2FgBQzRuKcZdigQBn296KaSzc Irmg== X-Gm-Message-State: AOAM531hbQSBByj9N6AeDNeMtwefl6mthxmI9c5zhaoqscTFfxYE1OeA TkPwEjPTs74uZdTMw4HHZA77FRH1WR/mI8BRY/nS0HnIHxNQ2+2/4PUUWX+NK0PGNZggWNVr9yY A4krtDz505RAjVuaL60Nf0eEYfttH8AD01LuJQx3Ilk3aXQBVJNudY0/jp2IaV/oiGoHa34Qaet UMtB5ZUr6wNCqyAXRAyZDt9uzDvaUTg5ulq6v5zstXHxkfpEaQ+G3Gk9+PYg== X-Google-Smtp-Source: ABdhPJy/33aQuzE9JC5tAzHJJ0vhe3J+WdEijo6+uHJ48vbDdLlBRxmEfekVIAg1lMsywqZ15yjtHrquaDOrxxFc8D0= X-Received: by 2002:a02:a90a:: with SMTP id n10mr22334435jam.7.1612868642409; Tue, 09 Feb 2021 03:04:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 9 Feb 2021 16:33:51 +0530 Message-ID: Subject: Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000080278905bae53e6d" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000080278905bae53e6d Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Feb 9, 2021 at 2:23 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hello Akshay, > > The previous patch will fix the dashboard issue also. > > On Tue, Feb 9, 2021 at 12:41 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> Please fix the issue for Dashboard API calls as well and send the patch >> again. >> >> On Mon, Feb 8, 2021 at 5:39 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> The changes for not calling the ajax until the panel is focused were >>> missed in the last patch. Please review the attached. >>> >>> On Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached patch will allow closing Statistics, Dependencies, Dependants >>>>> tabs. The tabs can be added back by right clicking on the tab strip and >>>>> selecting "Add panel", similar to that of Dashboard. >>>>> Changes are also made to make sure statistics, dependencies, >>>>> dependants are fetched only when they're visible, to avoid >>>>> unnecessary ajax calls. >>>>> >>>>> Please review. >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000080278905bae53e6d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Feb 9, 2021 at 2:23 PM Adity= a Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hello Akshay,

The previous pa= tch will fix the dashboard issue also.

On Tue, Feb 9, 2021 at 12:41 PM= Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Adit= ya

Please fix the issue for Dashboard API calls as well= and send the patch again.

On Mon, Feb 8, 2021 at 5:39 PM Aditya Toshniwal &= lt;a= ditya.toshniwal@enterprisedb.com> wrote:
Hi,

The changes for not c= alling the ajax until the panel is focused were missed in the last patch. P= lease review the attached.

On Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi= <aks= hay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
=
On Tue= , Feb 2, 2021 at 5:44 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com= > wrote:
=
Hi Hackers,

Attached patch will allow closing=C2=A0Statist= ics, Dependencies, Dependants tabs. The tabs can be added back=C2=A0by righ= t clicking on the tab strip and selecting "Add panel", similar to= that of Dashboard.
Changes are als= o made to make sure statistics, dependencies, dependants are fetched only w= hen they're visible, to avoid unnecessary ajax calls.
=
Please review.

--
Thanks,
Aditya Toshni= wal
pgAdmin hacker=C2=A0| Sr. Software Engineer | = edbpostgres.com
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000080278905bae53e6d--