public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding feature #5908
Date: Fri, 29 Sep 2023 12:32:27 +0530
Message-ID: <CANxoLDdGE-u_77SpN40_hqK1zG4FFpD7uRkmG+ie_ROyvNuoAA@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AN+T-Efb6sZVZ338SGFpeWOFFhQRe06wZJ=gC6LxmhxQQ@mail.gmail.com>
References: <CAOBg0AN+T-Efb6sZVZ338SGFpeWOFFhQRe06wZJ=gC6LxmhxQQ@mail.gmail.com>

Hi Nikhil


On Fri, Sep 29, 2023 at 11:13 AM Nikhil Mohite <
[email protected]> wrote:

> Hi Hackers,
>
> I am currently working on #5908
> <https://github.com/pgadmin-org/pgadmin4/issues/5908; Ability to Edit the
> View/Edit Data Query as if it were a query tool pane.
>
> To achieve this there are 2 different approaches:
> 1. Allow users to promote existing View/Edit data window to Query Tool.
>
>    1. Give a button on the View/Edit data toolbar to convert the
>    View/Edit data to the Query tool, after this users will able to edit the
>    queries
>    2. [image: image.png]
>    3. In View/Edit data we can move the Query section with the Data
>    output panel so the user can use the maximum space to see the actual
>    result. (This is UI enhancement)
>    4. Click on "Promote to Query Tool" will confirm from the user whether
>    the user wants to promote View/Edit Data to Query Tool or not, after
>    confirmation from the user it will promote View/Edit data to query tool.
>    5. Once promoted to Query Tool it will not be able to use the *Filters*
>    and *Limit* options that are available in View/Edit Data.
>
> 2. Allow the users to open a new Query Tool from View/Edit Data with Query.
>
>    1. Give an option on the View/Edit data connection bar to open a new
>    Query Tool with the current query (Query present in View/Edit data query
>    window). Currently, we have an open new query tool button already present,
>    we will just add a new option to that button that the user can select from
>    the dropdown.
>    2. [image: Screenshot 2023-09-29 at 10.53.29 AM.png]
>    3. With this, the View/Edit Data will not allow the edit query and
>    simply open a new Query Tool with a pre-written query.
>    4. We can add the UI enhancements with this option as well to move the
>    Query section to Data Output. (3rd point from 1st approach)
>
>
> Please let me know your suggestions/thoughts. and which approach we should
> go with.
>


   I am inclined toward 2nd approach with UI enhancements to move the Query
section to Data Output.

>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>


Attachments:

  [image/png] image.png (209.1K, 3-image.png)
  download | view image

  [image/png] Screenshot 2023-09-29 at 10.53.29 AM.png (199.9K, 4-Screenshot%202023-09-29%20at%2010.53.29%20AM.png)
  download | view image

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Regarding feature #5908
  In-Reply-To: <CANxoLDdGE-u_77SpN40_hqK1zG4FFpD7uRkmG+ie_ROyvNuoAA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox