Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpqws-000062-5M for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 Nov 2021 12:00:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mpqwr-00063q-41 for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 Nov 2021 12:00:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpqwq-00063c-Ed for pgadmin-hackers@lists.postgresql.org; Wed, 24 Nov 2021 12:00:24 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mpqwj-0005yS-K9 for pgadmin-hackers@postgresql.org; Wed, 24 Nov 2021 12:00:23 +0000 Received: by mail-io1-xd2f.google.com with SMTP id x6so2763191iol.13 for ; Wed, 24 Nov 2021 04:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ygpDHT4Vy9FepaQixpu/iRBvmDyJ1dVhREe142CW3eo=; b=jzwunwgWXuMAbWsCvO1zDrbPU7EnGKHGTJAmuewZiizVybTbjvDubGl0t7uVir18zH 6HmaXHOIQwLIexWvu/Bfxq/I3p0ghz6Xv4KpBjWFxdfN5lsUgRMqPSCafzV6Y3sBNuB4 HxsVIJD/HbLTJ4nMkLUI47xIa5K+vpJQnE/CjIfxC0srUMzobu9Dj5+ItK9FTXOg3iF/ nhBvIHkWoif8WbiUWbfbDZqsaT4iK54nu0eicqhwjeotSglRajZMQBxOtJhhsxlMdSaI F+DLz65XMnwj11ZkARR3S/+L8r59hw7BgRk7alSojiC0Ck2MNkFwzEQRMJtvyO8lh6V+ lojA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ygpDHT4Vy9FepaQixpu/iRBvmDyJ1dVhREe142CW3eo=; b=lXgKNU8hmXc/eHmjYaD9ASRnevFpL1P7L8+MH6fD5WjHXfn/wcEt5ynnWFCrri6EbH gz2GYs25elnozL4hLaKCaHHKpJJSF4at/GJV2UCcGM93sr9M8QCQ5wzfpcQaJwv26hgr u0rcz2/v/8Y5ougq4RHOY+bjRDwyHAanwiGZpbdmf+gSSRfP96KWEMDlJO94ooW1fnRU ac18ScIqP/KnD3yWgfU3kSiixfiPD3IPSheoJ87fXJqd+gG7tVbVdIRa6Qn/eLm1gjuK Ve+3MFsB6gB1yFkyUJPMbLLYPiIjoSF4ukTOFkELyBijsvuhLkKQDtP64XvZ8wirjZjH 86cg== X-Gm-Message-State: AOAM532wcnjd/DwFdnFwPWTAytLmxJ977MJ+TqxEfW23/gXsTyqhnp+g 15DJJxy1hnkMmZ+17TqLwhanarQ5XV0Y1Lu8GZSqJO52gUxiVw7V6hss6PFKtTywWHqlV0542V4 L9ME9DfLqK+diguCxmIKz5qF+zeeGPq6pN3L8p5YiFIuxJ9qC8bw2LxSYjE/b7cMmJKXaXM5v17 rX1m0Z/bheGhKq2zXGi1OQKdb7CSuEvZbMQ+/zUqjB0HZ7xmox0UEOUD9/kg== X-Google-Smtp-Source: ABdhPJzyvqIKDiGBizcoJkd67cmDd22+7HON2gyTzQQt/+BFXuj8O0v2Z47uaG0byrkdHrkLbI2O/O9EAkEsfvhbey4= X-Received: by 2002:a05:6638:32aa:: with SMTP id f42mr15089411jav.115.1637755216580; Wed, 24 Nov 2021 04:00:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 24 Nov 2021 17:30:05 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e9ec6b05d1879913" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e9ec6b05d1879913 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Wed, Nov 24, 2021 at 5:09 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch: > 1. Resolved issue if the binary patch is not present/ not correct, then > show error notification to add/ correct the binary path. > > Regards, > Nikhil Mohite > > On Mon, Nov 22, 2021 at 11:22 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >> On Mon, Nov 22, 2021 at 10:48 AM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find the updated patch. >>> >>> On Wed, Nov 17, 2021 at 6:34 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Nikhil >>>> >>>> Following are the review comments: >>>> >>>> GUI: >>>> >>>> - Dialog size should be increased. >>>> - Remove the first blank element from the Encoding dropdown. >>>> - When opening the file dialog header should have the title 'Select >>>> file'. >>>> - 'Backup server' title should be changed to 'Backup Server'. >>>> - When taking the backup of any object like database, schema, etc.. >>>> the title on the dialog header should be "Backup (Database/Schema ..." >>>> instead of "Backup (database/schema ..." >>>> >>>> >>>> Code: >>>> >>>> - Jasmine test cases are failing. >>>> - Remove warnBeforeChangesLost function not needed for Utilities. >>>> (Remove Alertify as well) >>>> - The naming convention should be identical, in some cases, you >>>> used camel case and in some cases used with an underscore. >>>> - Remove the commented code from all the files. >>>> - Take all the screenshots again with a width of 681. >>>> >>>> Resolved all review comments. >>> >>>> Note: I haven't tested it thoroughly with all combinations. >>>> >>>> On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite < >>>> nikhil.mohite@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Please find the attached patch for RM-6884: >>>>> Port Backup Global, >>>>> Backup Server, and Backup object dialog in React >>>>> >>>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Senior Software Engineer.* >>> *EDB Postgres* >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000e9ec6b05d1879913 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Wed, Nov 24, 2021 at 5:09 PM = Nikhil Mohite <nikhil.= mohite@enterprisedb.com> wrote:
Hi Akshay,

Pleas= e find the updated patch:
1. Resolved issue if the binary patch i= s not present/ not correct, then show error notification to add/ correct th= e binary path.

Regards,
Nikhil Mohite

On Mon, Nov 22, 2021 at 11:22 AM Akshay Joshi <akshay.joshi@enterprisedb.com<= /a>> wrote:
<= div dir=3D"ltr">Thanks, the patch applied.

On Mon, Nov 22, 2021 at 10:48 AM = Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Akshay,

Please find the updated patch.
On Wed, = Nov 17, 2021 at 6:34 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrot= e:
Hi Nikhil

Following are the review comments:

GUI:
  • Dialog size should be increased.
  • Remove the first blank element from the Encoding dropdown.
  • W= hen opening the file dialog header should have the title 'Select file&#= 39;.
  • 'Backup server' title should be changed to 'Backup= Server'.
  • When taking the backup of any object like database, s= chema, etc.. the=C2=A0title on the dialog header should be "Backup (Da= tabase/Schema ..." instead of=C2=A0 "Backup (database/schema ...&= quot;

Code:
  • Jasmine test case= s are failing.
  • Remove warnBeforeChangesLost function not needed for= Utilities. (Remove Alertify as well)
  • The naming convention should = be identical, in some cases, you used camel case and in some cases used wit= h an underscore.
  • Remove the commented code from all the files.
    • =
  • Take all the screenshots again with a width of 681.
Resolved all review comments.=C2=A0
Note: I haven= 't tested it thoroughly with all combinations.



--
Thanks & Regards,
Se= nior Software Engineer.
Mob.No: +9= 1-7798364578.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000e9ec6b05d1879913--