Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zn3qn-0002Hl-Hr for pgadmin-support@arkaria.postgresql.org; Fri, 16 Oct 2015 12:11:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zn3qm-0003uk-Op for pgadmin-support@arkaria.postgresql.org; Fri, 16 Oct 2015 12:11:08 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zn3qN-0003Tr-Kj for pgadmin-support@postgresql.org; Fri, 16 Oct 2015 12:10:43 +0000 Received: from mail-ob0-f177.google.com ([209.85.214.177]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1Zn3qK-0008Jp-9m for pgadmin-support@postgresql.org; Fri, 16 Oct 2015 12:10:42 +0000 Received: by obcqt19 with SMTP id qt19so10706221obc.3 for ; Fri, 16 Oct 2015 05:10:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=nDs+ByCNn7+mJHBBs9wO6blsWOZON8Di2uhIRgv7Cqs=; b=VPJVUvsrdCQzujUueHPx6ISGxOq8uHz+RnLAvVJySyaqnl5FK81bp1CB160TdQOtR6 Qs2bEx+NKEQNSgcA53zU2HdiUa4/n7k+y99J8Ye+dw4F6V222JQZ6UzkorIXbiZsRqei 7HBFJ20KmOptyre9uEs1h8UbGR+MWrXyJtPqkKFUSEC2dhlTElpv5Q6DHouvqaU4WrfG 1azFsq34ZTixYQkkDSqLwH1XSyos/bCV8704NX+4/Bp9XjyXybleULouT0iyzo8reCYP C0O5KjZD5zdjmm4zLh69t9sLIXLlyzYPBoK/QwHVzmCWzVDTXWCscayJTrN46wthHz2Z TMjA== X-Gm-Message-State: ALoCoQlyK9jVKFg+n4Z9aQrpAQZ8Q4urcxfJoky91ic4QIT8CtqIEkLmLnjDluIDO+Tc2ocGWHyq MIME-Version: 1.0 X-Received: by 10.182.89.197 with SMTP id bq5mr9110129obb.27.1444997438675; Fri, 16 Oct 2015 05:10:38 -0700 (PDT) Received: by 10.202.73.150 with HTTP; Fri, 16 Oct 2015 05:10:38 -0700 (PDT) In-Reply-To: References: <1444887919111-5870044.post@n5.nabble.com> Date: Fri, 16 Oct 2015 17:40:38 +0530 Message-ID: Subject: Re: Error about inherited table of column in pgadmin1.20.0 From: Akshay Joshi To: Ashesh Vashi Cc: pgadmin-support , JasmineLiu Content-Type: multipart/mixed; boundary=089e013cbc20095f90052237aff0 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-support Precedence: bulk Sender: pgadmin-support-owner@postgresql.org --089e013cbc20095f90052237aff0 Content-Type: multipart/alternative; boundary=089e013cbc20095f8b052237afee --089e013cbc20095f8b052237afee Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ashesh On Thu, Oct 15, 2015 at 1:51 PM, Ashesh Vashi wrote: > On Thu, Oct 15, 2015 at 11:15 AM, JasmineLiu > wrote: > >> Hi, all ! >> >> This is Liu Yuanyuan. >> I find the inherited table of column shown in pgadmin 1.20.0, sometimes >> isn=E2=80=99t right. That should be a bug. >> Hope someone to do something about this problem! >> Here is my example: >> >> First I execute the following sql in pgadmin 1.20.0 by query tool: >> create schema test; >> create table test.a1(id int); >> create table test.a2(id int, name varchar); >> create table test.a3(age int); >> create table test.aa() inherits(test.a1,test.a2,test.a3); >> >> >> Then in main view of pgadmin 1.20.0=EF=BC=9A >> It shows the column age is inherited from table test.a2, this is not >> right. >> >> >> > Looks like a bug to me. > > Akshay, > > Can you please take a look at it? > I have fixed the issue, attached is the patch file. Can you please review it and if it looks good can you please commit the code. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > >> >> I also check the code of pgadmin 1.20.0, I think the method to specify t= he >> inherited table of columns is not correct,especially when the inherited >> tables have same column. >> >> Thanks and hope to hear from you soon! >> >> Best wishes! >> Liu Yuanyuan >> >> >> >> >> -- >> View this message in context: >> http://postgresql.nabble.com/Error-about-inherited-table-of-column-in-pg= admin1-20-0-tp5870044.html >> Sent from the PostgreSQL - pgadmin support mailing list archive at >> Nabble.com. >> >> >> -- >> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-support >> > > --=20 *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --089e013cbc20095f8b052237afee Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Ashesh

On Thu, = Oct 15, 2015 at 1:51 PM, Ash= esh Vashi <ashesh.vashi@enterprisedb.com> wrote:=
On Thu, Oct 15, 2015 at 11:15 = AM, JasmineLiu <liuyuanyuangogo@gmail.com> wrote:
<= span class=3D"">
Hi, all !=

This is Liu Yuanyuan.
I find the inherited table of column shown in pgadmin 1.20.0, sometimes
isn=E2=80=99t right. That should be a bug.
Hope someone to do something about this problem!
Here is my example:

First I execute the following sql in pgadmin 1.20.0 by query tool:
create schema test;
create table test.a1(id int);
create table test.a2(id int, name varchar);
create table test.a3(age int);
create table test.aa() inherits(test.a1,test.a2,test.a3);


Then in main view of pgadmin 1.20.0=EF=BC=9A
It shows the column age is inherited from table test.a2, this is not right.=
<http://postgresql.nabble.com/file/n5870044/1.jpg= >
<http://postgresql.nabble.com/file/n5870044/2.jpg= >
Looks like a bug to me.

A= kshay,

Can you please take a look at it?
<= /div>

=C2=A0 =C2=A0I have fixed the issue, = attached is the patch file. Can you please review it and if it looks good c= an you please commit the code.=C2=A0
<= br>

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

= =C2=A0

I also check the code of pgadmin 1.20.0, I think the method to specify the<= br> inherited table of columns is not correct,especially when the inherited
tables have same column.

Thanks and hope to hear from you soon!

Best wishes!
Liu Yuanyuan




--
View this message in context: http://postgresql.nabble.com/Error-about-inheri= ted-table-of-column-in-pgadmin1-20-0-tp5870044.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.c= om.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support=




--
Akshay= Joshi<= /b>
= Principal Software Engineer=C2=A0


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246
--089e013cbc20095f8b052237afee-- --089e013cbc20095f90052237aff0 Content-Type: application/octet-stream; name="Fixed_Inherited_Table.patch" Content-Disposition: attachment; filename="Fixed_Inherited_Table.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iftm4y0h0 ZGlmZiAtLWdpdCBhL3BnYWRtaW4vaW5jbHVkZS9zY2hlbWEvcGdDb2x1bW4u aCBiL3BnYWRtaW4vaW5jbHVkZS9zY2hlbWEvcGdDb2x1bW4uaAppbmRleCBm Y2E4NDU2Li45NjMwNzk0IDEwMDY0NAotLS0gYS9wZ2FkbWluL2luY2x1ZGUv c2NoZW1hL3BnQ29sdW1uLmgKKysrIGIvcGdhZG1pbi9pbmNsdWRlL3NjaGVt YS9wZ0NvbHVtbi5oCkBAIC0xNSw2ICsxNSw4IEBACiAvLyBBcHAgaGVhZGVy cwogI2luY2x1ZGUgInBnVGFibGUuaCIKIAorV1hfREVDTEFSRV9TVFJJTkdf SEFTSF9NQVAod3hTdHJpbmcsIGluaGVyaXRIYXNoTWFwKTsKKwogY2xhc3Mg cGdDb2xsZWN0aW9uOwogCiBjbGFzcyBwZ0NvbHVtbkZhY3RvcnkgOiBwdWJs aWMgcGdUYWJsZU9iakZhY3RvcnkKZGlmZiAtLWdpdCBhL3BnYWRtaW4vc2No ZW1hL3BnQ29sdW1uLmNwcCBiL3BnYWRtaW4vc2NoZW1hL3BnQ29sdW1uLmNw cAppbmRleCBiMzc5NmUyLi5jMTNiMTNlIDEwMDY0NAotLS0gYS9wZ2FkbWlu L3NjaGVtYS9wZ0NvbHVtbi5jcHAKKysrIGIvcGdhZG1pbi9zY2hlbWEvcGdD b2x1bW4uY3BwCkBAIC01NDYsMTcgKzU0NiwzOCBAQCBwZ09iamVjdCAqcGdD b2x1bW5GYWN0b3J5OjpDcmVhdGVPYmplY3RzKHBnQ29sbGVjdGlvbiAqY29s bCwgY3RsVHJlZSAqYnJvd3NlciwgYwogCXBnQ29sdW1uICpjb2x1bW4gPSAw OwogCXBnRGF0YWJhc2UgKmRhdGFiYXNlID0gY29sbGVjdGlvbi0+R2V0RGF0 YWJhc2UoKTsKIAl3eFN0cmluZyBzcWw7Ci0JaW50IGN1cnJlbnRjb2w7Ci0J aW50IGN1cnJlbnRsaW1pdDsKLQotCS8vIGdyYWIgaW5oZXJpdGVkIHRhYmxl cwotCXNxbCA9IHd4VCgiU0VMRUNUIGluaHBhcmVudDo6cmVnY2xhc3MgQVMg aW5ocmVsbmFtZSxcbiIpCi0JICAgICAgd3hUKCIgIChTRUxFQ1QgY291bnQo KikgRlJPTSBwZ19hdHRyaWJ1dGUgV0hFUkUgYXR0cmVsaWQ9aW5ocGFyZW50 IEFORCBhdHRudW0+MCkgQVMgY29sc2NvdW50XG4iKQotCSAgICAgIHd4VCgi ICBGUk9NIHBnX2luaGVyaXRzXG4iKQotCSAgICAgIHd4VCgiICBXSEVSRSBp bmhyZWxpZCA9ICAiKSArIGNvbGxlY3Rpb24tPkdldE9pZFN0cigpICsgd3hU KCI6Om9pZFxuIikKLQkgICAgICB3eFQoIiAgT1JERVIgQlkgaW5oc2Vxbm8i KTsKKwlpbmhlcml0SGFzaE1hcCBpbmhNYXA7CisKKwkvLyBncmFiIGluaGVy aXRlZCB0YWJsZXMgd2l0aCBhdHRpYnV0ZSBuYW1lcworCXNxbCA9IHd4VCgi IFNFTEVDVCBpbmhwYXJlbnQ6OnJlZ2NsYXNzIEFTIGluaHJlbG5hbWUsIGEu YXR0bmFtZSBBUyBhdHRybmFtZSBGUk9NIHBnX2luaGVyaXRzIGlcbiIpCisJ ICAgICAgd3hUKCIgTEVGVCBKT0lOIHBnX2F0dHJpYnV0ZSBhIE9OIChhdHRy ZWxpZCA9IGluaHBhcmVudCBBTkQgYXR0bnVtID4gMClcbiIpCisJICAgICAg d3hUKCIgV0hFUkUgaW5ocmVsaWQgPSAgIikgKyBjb2xsZWN0aW9uLT5HZXRP aWRTdHIoKSArIHd4VCgiOjpvaWRcbiIpCisJICAgICAgd3hUKCIgT1JERVIg QlkgaW5oc2Vxbm8iKTsKIAlwZ1NldCAqaW5odGFibGVzID0gZGF0YWJhc2Ut PkV4ZWN1dGVTZXQoc3FsKTsKIAorCWlmIChpbmh0YWJsZXMpCisJeworCQl3 aGlsZSAoIWluaHRhYmxlcy0+RW9mKCkpCisJCXsKKwkJCXd4U3RyaW5nIGF0 dHJOYW1lID0gaW5odGFibGVzLT5HZXRWYWwod3hUKCJhdHRybmFtZSIpKTsK KwkJCXd4U3RyaW5nIGluaHJlbE5hbWUgPSBpbmh0YWJsZXMtPkdldFZhbCh3 eFQoImluaHJlbG5hbWUiKSk7CisKKwkJCS8vIENoZWNrIGF0dHJpYnV0ZSBu YW1lIGlzIGFscmVhZHkgZXhpc3RzIGluIGhhc2ggbWFwCisJCQlpbmhlcml0 SGFzaE1hcDo6aXRlcmF0b3IgaXQgPSBpbmhNYXAuZmluZChhdHRyTmFtZSk7 CisJCQlpZiAoIGl0ICE9IGluaE1hcC5lbmQoKSkKKwkJCXsKKwkJCQl3eFN0 cmluZyAmcmVsTmFtZSA9IGl0LT5zZWNvbmQ7CisJCQkJcmVsTmFtZSArPSB3 eFQoIiwgIikgKyBpbmhyZWxOYW1lOworCQkJfQorCQkJZWxzZQorCQkJCWlu aE1hcFthdHRyTmFtZV0gPSBpbmhyZWxOYW1lOworCisJCQlpbmh0YWJsZXMt Pk1vdmVOZXh0KCk7CisJCX0KKworCQlkZWxldGUgaW5odGFibGVzOworCX0K KwogCXd4U3RyaW5nIHN5c3RlbVJlc3RyaWN0aW9uOwogCWlmICghc2V0dGlu Z3MtPkdldFNob3dTeXN0ZW1PYmplY3RzKCkpCiAJCXN5c3RlbVJlc3RyaWN0 aW9uID0gd3hUKCJcbiAgIEFORCBhdHQuYXR0bnVtID4gMCIpOwpAQCAtNjA0 LDE3ICs2MjUsMTAgQEAgcGdPYmplY3QgKnBnQ29sdW1uRmFjdG9yeTo6Q3Jl YXRlT2JqZWN0cyhwZ0NvbGxlY3Rpb24gKmNvbGwsIGN0bFRyZWUgKmJyb3dz ZXIsIGMKIAlwZ1NldCAqY29sdW1ucyA9IGRhdGFiYXNlLT5FeGVjdXRlU2V0 KHNxbCk7CiAJaWYgKGNvbHVtbnMpCiAJewotCQljdXJyZW50Y29sID0gMDsK LQkJaWYgKGluaHRhYmxlcyAmJiAhaW5odGFibGVzLT5Fb2YoKSkKLQkJewot CQkJY3VycmVudGxpbWl0ID0gaW5odGFibGVzLT5HZXRMb25nKHd4VCgiY29s c2NvdW50IikpOwotCQl9CiAJCXdoaWxlICghY29sdW1ucy0+RW9mKCkpCiAJ CXsKLQkJCWlmIChjb2x1bW5zLT5HZXRMb25nKHd4VCgiYXR0bnVtIikpID4g MCkgLy8gaWdub3JlIHN5c3RlbSBjb2x1bW5zIGJlZm9yZSBpbmhlcml0ZWQg Y29sdW1ucwotCQkJCWN1cnJlbnRjb2wrKzsKLQotCQkJY29sdW1uID0gbmV3 IHBnQ29sdW1uKGNvbGxlY3Rpb24tPkdldFRhYmxlKCksIGNvbHVtbnMtPkdl dFZhbCh3eFQoImF0dG5hbWUiKSkpOworCQkJd3hTdHJpbmcgYXR0ck5hbWUg PSBjb2x1bW5zLT5HZXRWYWwod3hUKCJhdHRuYW1lIikpOworCQkJY29sdW1u ID0gbmV3IHBnQ29sdW1uKGNvbGxlY3Rpb24tPkdldFRhYmxlKCksIGF0dHJO YW1lKTsKIAogCQkJY29sdW1uLT5pU2V0QXR0VHlwSWQoY29sdW1ucy0+R2V0 T2lkKHd4VCgiYXR0dHlwaWQiKSkpOwogCQkJY29sdW1uLT5pU2V0Q29sTnVt YmVyKGNvbHVtbnMtPkdldExvbmcod3hUKCJhdHRudW0iKSkpOwpAQCAtNjY1 LDE4ICs2NzksMTAgQEAgcGdPYmplY3QgKnBnQ29sdW1uRmFjdG9yeTo6Q3Jl YXRlT2JqZWN0cyhwZ0NvbGxlY3Rpb24gKmNvbGwsIGN0bFRyZWUgKmJyb3dz ZXIsIGMKIAkJCWNvbHVtbi0+aVNldFRhYmxlTmFtZShjb2x1bW5zLT5HZXRW YWwod3hUKCJyZWxuYW1lIikpKTsKIAkJCWNvbHVtbi0+aVNldEluaGVyaXRl ZENvdW50KGNvbHVtbnMtPkdldExvbmcod3hUKCJhdHRpbmhjb3VudCIpKSk7 CiAKLQkJCWlmIChpbmh0YWJsZXMpCi0JCQl7Ci0JCQkJaWYgKGN1cnJlbnRj b2wgPiBjdXJyZW50bGltaXQpCi0JCQkJewotCQkJCQlpbmh0YWJsZXMtPk1v dmVOZXh0KCk7Ci0JCQkJCWlmICghaW5odGFibGVzLT5Fb2YoKSkKLQkJCQkJ CWN1cnJlbnRsaW1pdCArPSBpbmh0YWJsZXMtPkdldExvbmcod3hUKCJjb2xz Y291bnQiKSk7Ci0JCQkJfQotCi0JCQkJaWYgKCFpbmh0YWJsZXMtPkVvZigp KQotCQkJCQljb2x1bW4tPmlTZXRJbmhlcml0ZWRUYWJsZU5hbWUoaW5odGFi bGVzLT5HZXRWYWwod3hUKCJpbmhyZWxuYW1lIikpKTsKLQkJCX0KKwkJCS8v IENoZWNrIHdoZXRoZXIgdGhlIGF0dHJpYnV0ZSBpcyBpbmhlcml0ZWQKKwkJ CWluaGVyaXRIYXNoTWFwOjppdGVyYXRvciBpdCA9IGluaE1hcC5maW5kKGF0 dHJOYW1lKTsKKwkJCWlmIChpdCAhPSBpbmhNYXAuZW5kKCkpCisJCQkJY29s dW1uLT5pU2V0SW5oZXJpdGVkVGFibGVOYW1lKGl0LT5zZWNvbmQpOwogCiAJ CQljb2x1bW4tPmlTZXRJc0xvY2FsKGNvbHVtbnMtPkdldEJvb2wod3hUKCJh dHRpc2xvY2FsIikpKTsKIAkJCWNvbHVtbi0+aVNldEF0dHN0YXR0YXJnZXQo Y29sdW1ucy0+R2V0TG9uZyh3eFQoImF0dHN0YXR0YXJnZXQiKSkpOwpAQCAt NzExLDkgKzcxNywxMCBAQCBwZ09iamVjdCAqcGdDb2x1bW5GYWN0b3J5OjpD cmVhdGVPYmplY3RzKHBnQ29sbGVjdGlvbiAqY29sbCwgY3RsVHJlZSAqYnJv d3NlciwgYwogCQkJCWJyZWFrOwogCQl9CiAKLQkJZGVsZXRlIGluaHRhYmxl czsKIAkJZGVsZXRlIGNvbHVtbnM7CiAJfQorCisJaW5oTWFwLmNsZWFyKCk7 CiAJcmV0dXJuIGNvbHVtbjsKIH0KIAo= --089e013cbc20095f90052237aff0 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-support --089e013cbc20095f90052237aff0--