public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4
Date: Mon, 16 Dec 2019 18:54:36 +0530
Message-ID: <CANxoLDdJXME7ZdSoD5ewZWpG8csOfPjuc3mh_W8UqY=-_V2z_Q@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mgjt9ju6057rQi87XpaA5CXSnwkYa=pgLf7wvW4nCs-g@mail.gmail.com>
References: <CAM9w-_mgjt9ju6057rQi87XpaA5CXSnwkYa=pgLf7wvW4nCs-g@mail.gmail.com>
Thanks, patch applied.
On Mon, Dec 16, 2019 at 5:40 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached patch which is related to RM4988, reduces the number of hits to edit_mode_types.sql
> (an expensive one).
> Currently, this is query is executed for every column one by one when
> table properties dialog is opened. I've added edit_mode_types_bulk.sql,
> which will fetch the edit types for all the distinct column types used in
> the table in a single DB trip and use that data for each column.
> Also, while generating RE-SQL for columns, edit_mode_types.sql will not
> be executed.
> This will definitely reduce time.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4
In-Reply-To: <CANxoLDdJXME7ZdSoD5ewZWpG8csOfPjuc3mh_W8UqY=-_V2z_Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox