Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUq8D-0001eL-SY for pgadmin-hackers@arkaria.postgresql.org; Tue, 20 Oct 2020 11:48:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kUq8C-0003Co-Rx for pgadmin-hackers@arkaria.postgresql.org; Tue, 20 Oct 2020 11:48:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUq8C-0003Cg-Im for pgadmin-hackers@lists.postgresql.org; Tue, 20 Oct 2020 11:48:44 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kUq8A-0000H0-6P for pgadmin-hackers@postgresql.org; Tue, 20 Oct 2020 11:48:43 +0000 Received: by mail-wr1-x432.google.com with SMTP id b8so1772985wrn.0 for ; Tue, 20 Oct 2020 04:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HFC5BUSC9mq947cxkaTYzTDQ0B3nCSLCP/iyy8JFOXg=; b=SMNOd8tIN357o+hDChace3fZDTThwWLHRUi8kTwJNAOjK1rOQ0eIGP5/XQNEBM117H rbeFYymXcyttVfvyeTBdAhfsNcBZlbbsHy5oNW6FimrxATCfqfdggbybvc1MIgaU0VBY 6NT0Jr3qI5VtkJhyNw+s6HMXN731DZ+/qrDil4tcY2LASc0wh9g1+XvOfXtzpKSkQa0g rE2SlOtxnT8IdvwHUXiLoAuyueh6CIJHNzX+E4UF9KE/+vh/1eZWIihQuJfp774rcha3 nIesxsr61Lb30qXuwENZG8ifT7qY7HCLrNNlyoGPB471ZHgXp/fXIV7kEszesM7OMRJY vIRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HFC5BUSC9mq947cxkaTYzTDQ0B3nCSLCP/iyy8JFOXg=; b=HmWQciPx54KSBodcpXJ8rvL7cmaHth4I7YjqZ9kS5cZqhqovgy5aWxFviatgATWwJX ap0aYMbql1cgv8hbIM4BqQJC4a9j50A0czFAT0pSvY16ooOj66oCcPtokCJ48m/HWxtc 4RZKuCStMdDSDV1AjTNb9mUvtWjNTLp5+r4OJUwtrvskZvpWKk6igFQcC35xmVqbpew6 x3SEzpqhG89vNx6ejpO3PK/JXvRUkG+k0+eJ0rdueXpYNVGob3JBy/zzc5BABK4GzxvG /EITYJlJOrk9s3vQX1tnPmQuCN2qSyohJGZrroAaqVjTUiOSR08ZcnKXbTpnmDGimi// fQbQ== X-Gm-Message-State: AOAM532VVzEQHdrVFK1MW+j7QdSjEqkBjlQorX9aSEYckzTyaLLBiB5R rCc2YixZ3hgn9GGctLPDcfbolFYrGAfdLQ1t1ZL7Ksqpvfwj8gHZS7e4Ennk652gWVIIvSO2vvq 5tJlrax5EF7vwwqDs4PhuKhJd2/Xm1LeN3GKsweyWAD7QSV5PfnguuEbi+JaVSoxqBTxqZ5ORhy xB8kfZKcLy30MVL7iu2rXIzGCObL0H9W6WLsdQv8ewEhnTc4YcfrY4+F/ooRsz54PPXjerT7w= X-Google-Smtp-Source: ABdhPJw3/YOpClTIGcdnAPjPKMp+hJAv7DteVNGIlbKCOSmZeiXZNrjYYo7FsLIaXJl07447K56CQNQvf/UwlYD4J0o= X-Received: by 2002:a5d:488e:: with SMTP id g14mr3125816wrq.203.1603194520746; Tue, 20 Oct 2020 04:48:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 20 Oct 2020 17:18:29 +0530 Message-ID: Subject: Re: [pgAdmin4][RM4232]: Change what is shown by default in tab titles To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ea5e7405b218cfb5" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ea5e7405b218cfb5 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Oct 20, 2020 at 9:07 AM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved the review comments and also added a %ARGS% placeholder > for the debugger. > PFA patch v2. > > Regards, > Nikhil Mohite. > > On Mon, Oct 19, 2020 at 10:58 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Nikhil >> >> Following are the review comments: >> >> - Jasmin test cases are failing. >> - Can we change the following strings in preferences: >> - "Query tool tab title placeholder" to "Query tool tab title" >> - "View/Edit tab title placeholder" to "View/Edit data tab title" >> - "Debugger tab title placeholder" to "Tab title" as this setting >> is already inside the Debugger section. >> - Change the help messages in the preferences dialog to: >> - "*Supported placeholders are %DATABASE%, %USERNAME%, and >> %SERVER%. Users can provide any string with or without placeholders of >> their choice. The blank title will be revert back to the default title with >> placeholders.*" (Make the same changes for Query tool, View/Edit, >> and Debugger tab title message) >> - For Debugger can we add %ARGS% because in the case of functions >> with arguments tab title is very long, so the user should have the option >> to discard arguments in the tab title. >> >> Update the documentation if you will make the above changes. >> >> On Tue, Oct 13, 2020 at 5:27 PM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Regarding RM-4232 Change >>> what is shown by default: >>> Added placeholders in preferences as following: >>> 1. Debugger: Added placeholder in the display section of the debugger. >>> 2. Query Tool and View/Edit data: Added placeholder in the display >>> section of the Query Tool. >>> >>> Updated the documentation for Query Tool and Debugger with new >>> screenshots. >>> >>> PFA patch. >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Software Engineer.* >>> *EDB Postgres* >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000ea5e7405b218cfb5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Oct 20, 2020 at 9:07 AM = Nikhil Mohite <nikhil.= mohite@enterprisedb.com> wrote:
Hi Akshay,

I= have resolved=C2=A0the review comments and also added a %ARGS% placeholder= for the debugger.
PFA patch v2.

Regards= ,
Nikhil Mohite.

On Mon, Oct 19, 2020 at 10:58 AM Akshay Jos= hi <a= kshay.joshi@enterprisedb.com> wrote:
Hi Nikhil=C2=A0

=
Following are the review comments:
  • Jasmin test cases= are failing.
  • Can we change the following strings in preferences:= =C2=A0
    • "Query tool tab title placeholder" to "Qu= ery tool tab title"
    • "View/Edit tab title placeholder"= ; to "View/Edit data tab title"
    • "Debugger tab title = placeholder" to "Tab title" as this setting is already insid= e the Debugger section.
  • Change the help messages in the prefer= ences dialog to:
    • "Supported placeholders are %DATABASE%= , %USERNAME%, and %SERVER%. Users can provide any string with or without pl= aceholders of their choice. The blank title will be revert back to the defa= ult title with placeholders." (Make the same changes for Query too= l, View/Edit, and Debugger tab title message)
  • For Debugger can= we add %ARGS% because in the case of functions with arguments tab title is= very long, so the user should have the option to discard arguments in the = tab title.
Update the documentation if you will make the above cha= nges.

On Tue, Oct 13, 2020 at 5:27 PM Nikhil Mohite <nikhil.mohite@enterpr= isedb.com> wrote:


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000ea5e7405b218cfb5--