Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i57Xs-0004S7-33 for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 12:04:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i57Xq-0001Aj-GE for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 12:04:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i57Xq-0001AK-7l for pgadmin-hackers@lists.postgresql.org; Tue, 03 Sep 2019 12:04:22 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i57Xf-0004Lz-0Q for pgadmin-hackers@postgresql.org; Tue, 03 Sep 2019 12:04:21 +0000 Received: by mail-qt1-x82e.google.com with SMTP id u40so10891898qth.11 for ; Tue, 03 Sep 2019 05:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zm9i403t1cXywuCxHnH+lAYAjH8xggCQBzh8+JKe8n8=; b=bKRSb5k6JaSUsz79iFvrt0zCMmt9Q8/5PxGZi2d0f30f6Ozy3P9+H6ZQC32clMrreY ne81vXVgRoB3+0a6O8n5cYWQOt+EKxNKYaV0x88PWvLTeOiTskViRJ57GLHAaB21UHQl wIURlgUybr0kxXoBxP22JE3K9y11ym2SP2ALAsM8bYPfXrmethtAgusK7qako/TJKhYQ nn3AHF8tvMPJ8f9hvZDCoXcSd+7+iC0O1krn0be+1CKhHBRMRqvgegF/x0r9MrkEAVlX Ej8Hv10Cgu3lxAuNYFwkuAl1WwMkMpxvOwfLz0vXXywnI9iXFCW38yVWH/R1PWrVO1Y7 dg/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zm9i403t1cXywuCxHnH+lAYAjH8xggCQBzh8+JKe8n8=; b=bNRZHqcl6a81ih/fY08cBeczt7FLHHr8YLoG24kmZnKKqRXIJPAxa/MSw35bdC+dmg BUHc5TpwCkjqSM8Fbjx+sc69mgKw4hNVR1SOyYsQEaEWGIUbnRfTx+K/0FcQjsFcgJGm bKwXqkhAFmJ07SIYTLz2rcx2HlN7hnIarMU1znq+7hzfYsfL/OxqCc/bCeSTQSQ3DYUb 2wuBJnHQ07i4dg+QqRHi75PidI2RaZ/1hjvDxQOy6z8CdM5ZmWsFcNtd3Q+dXDBe3LJK 5ylrXLbg76RnUSMgjfMideJV+YzXkFzmIG2Sra9s0yAx+3wUEHrpYLvTB1WYQfy16DsI QNxA== X-Gm-Message-State: APjAAAWDrrE44CPFhMBjO/7KKaDgjQQ9oJr8Jpc9manzImXJKf3rPnni Nov/hNkBQJiZRaFBc795U2f2df5CDWXCkJQ21yVIVXD9l6E= X-Google-Smtp-Source: APXvYqwFSmDiUgQruCJPYoz2ihejLzCyHWsyRdv+LNsAN4Hv2nMxD63zmKsYo43paJNM/BCuSP8g+TsjZwydmiRMtbA= X-Received: by 2002:ac8:5354:: with SMTP id d20mr32187786qto.119.1567510629474; Tue, 03 Sep 2019 04:37:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 3 Sep 2019 17:06:58 +0530 Message-ID: Subject: Re: RE-SQL tests patch for packages node To: navnath gadakh Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000040942a0591a4829f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000040942a0591a4829f Content-Type: text/plain; charset="UTF-8" Hi Navnath You forgot to add "create_package_with_all_options_msql.sql" and "alter_package_headers_and_comment_msql.sql" file in your patch. Please send the updated patch. On Tue, Sep 3, 2019 at 1:36 PM navnath gadakh < navnath.gadakh@enterprisedb.com> wrote: > Hi, > > Please find the modified patch. > > On Mon, Sep 2, 2019 at 5:43 PM Akshay Joshi > wrote: > >> Hi Navnath >> >> Following are the review comments: >> >> - GRANT statement is not visible in RE-SQL for create and alter both. >> (May be bug in Packages please fix that too) >> >> Done. > >> >> - Delete packages is missing in json file. >> >> Done. > >> >> - Add test cases to revoke privileges(delete all the privileges). >> Check Languages node for reference. >> >> Done. > >> >> On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh < >> navnath.gadakh@enterprisedb.com> wrote: >> >>> Hi Dave, >>> Please find the patch for M-SQL test cases for *Packages* >>> module. >>> >>> Thanks! >>> >>> On Fri, Jul 12, 2019 at 4:02 PM Dave Page >>> wrote: >>> >>>> Thanks, applied. >>>> >>>> On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < >>>> navnath.gadakh@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find the modified patch for packages as test cases were >>>>> failing on some servers. >>>>> Thanks! >>>>> >>>>> >>>>> On Thu, Jul 11, 2019 at 1:53 PM Dave Page >>>>> wrote: >>>>> >>>>>> Thanks, applied. >>>>>> >>>>>> On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Navnath >>>>>>> >>>>>>> I have tested the patch and it is not working for EPAS 9.4, 9.5 and >>>>>>> 9.6. Attached is the modified patch which fix the issue. >>>>>>> Please work on child node (functions, procedure and variables) of >>>>>>> Packages on top of modified patch. >>>>>>> >>>>>>> On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh < >>>>>>> navnath.gadakh@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> I have attached the patch for RE-SQL test cases for *Packages* >>>>>>>> node. >>>>>>>> >>>>>>>> Thanks! >>>>>>>> >>>>>>>> -- >>>>>>>> *Regards,* >>>>>>>> *Navnath Gadakh* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards* >>>>>>> *Akshay Joshi* >>>>>>> >>>>>>> *Sr. Software Architect* >>>>>>> *EnterpriseDB Software India Private Limited* >>>>>>> *Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> VP, Chief Architect, Tools & Installers >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Regards,* >>>>> *Navnath Gadakh* >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >>> -- >>> *Regards,* >>> *Navnath Gadakh* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Regards,* > *Navnath Gadakh* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000040942a0591a4829f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Navnath

You forgot to add "= ;create_package_with_all_options_msql.sql" and "alter_package_hea= ders_and_comment_msql.sql" file in your patch. Please send the updated= patch.

On Tue, Sep 3, 2019 at 1:36 PM navnath gadakh <navnath.gadakh@enterprisedb.com&= gt; wrote:
Hi,

Please find the modified patch.

On Mon, Sep 2, 2019 at 5:43 P= M Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Navnath
Following are the review comments:
  • GRAN= T statement is not visible in RE-SQL for create and alter both. (May be bug= in Packages please fix that too)
Done.=C2=A0
  • Delete packages is missing in json= file.
Done.=C2= =A0
  • Add test cases to revoke privileges(delete all the privileges= ). Check Languages node for reference.
Done.=C2=A0

On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh <navnath.gadakh@enterpr= isedb.com> wrote:
Hi Dave,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Please find the patch f= or=C2=A0M-SQL test cases for Packages module.

Thanks!

On Fri, Jul 12, 20= 19 at 4:02 PM Dave Page <dave.page@enterprisedb.com> wrote:
Thanks, applied= .

On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh <navnath.gadakh@enterprisedb.= com> wrote:
Hi Dave,

=C2=A0 =C2=A0 =C2=A0Please find the modified patch for packages as = test cases were failing on some servers.=C2=A0
Thanks!


On Thu, Jul 11, 2019 at = 1:53 PM Dave Page <dave.page@enterprisedb.com> wrote:
Thanks, applied.
On T= hu, Jul 11, 2019 at 8:07 AM Akshay Joshi <akshay.joshi@enterprisedb.com> = wrote:
Hi=C2=A0Navnath

I have tested the patch and it = is not working for EPAS 9.4, 9.5 and 9.6. Attached is the modified patch wh= ich fix the issue.=C2=A0
Please work on child node (functions, pr= ocedure and variables) of Packages on top of modified patch.=C2=A0=C2=A0

On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh <navnath.gadakh@enterprisedb= .com> wrote:
Hi Dave,

=C2=A0 =C2=A0 I have attached the patch for RE-SQL test cases for = Packages node.
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
Thanks!

--
Regards= ,
Navnath Ga= dakh


--
T= hanks & Regards
= Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India = Private Limited
Mobile: +91 976-788-8246


--
Dave Page
VP, Chief Architect,= Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise P= ostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
<= div>Regards,
= Navnath Gadakh


--
Dave PageVP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake


--
<= div dir=3D"ltr">
Regards,
Navnath Gadakh
=


--
Thanks & Regards
Akshay Joshi
=
Sr. Software Arc= hitect
EnterpriseDB Sof= tware India Private Limited
Mobile: +91 976-788-8246


--
Regards,
<= b>Navnath Gadakh


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000040942a0591a4829f--