Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jY29R-0002El-AP for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 May 2020 06:42:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jY28u-0001Gj-Q2 for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 May 2020 06:42:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jY28u-0001Gc-CW for pgadmin-hackers@lists.postgresql.org; Mon, 11 May 2020 06:42:24 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jY28r-00013N-Lb for pgadmin-hackers@postgresql.org; Mon, 11 May 2020 06:42:24 +0000 Received: by mail-il1-x134.google.com with SMTP id m5so7353170ilj.10 for ; Sun, 10 May 2020 23:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=acu/hLSbFYHi5fqZs1eF91i5f1Yvh3V0F3wA630IivQ=; b=bLFOZg0Fw3frhnh2kTUe0fbVy6Xe+DGygqzkyFWwHBiK/WdrdwCVeALVt/h+/hE11/ vxauTATD/lEld2SPcb3NS7Nz6963SdaORVD5QptgKKuO/rdrV3ZhSgdzMIJmi5P+uRBC JTo4k3i2sTj8OlEeIDWy+hEZTFWWyMapDvktLu2l6W06iwGh2cVDSUyVB0N/7sL5DC+X JGpmftv53phixGdj5P3oId4ptBOhANq4j/tjDR20fz5w+1zYAf0TrKJqTeO9YJiIdqA8 m+z9+VQDvCSB9z2Wh4kzlwYLf4kiZqA9rWUCZ1qvynGDA8cDfqY9wZaanQtR+/8eSu03 wFzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=acu/hLSbFYHi5fqZs1eF91i5f1Yvh3V0F3wA630IivQ=; b=ISeQZf7jBfczSYK4tJCeULsQuHl0WEiiMt/972HDRovidFPRO1iwvJMk7thvttX0iS PObqaN2hIO1meLh5/U48oqXAmiwuRVTjm6POdnWXfrpc8RPjrcZu8SEOkNyQH2EQBuQS kvPk6x3ns9oNaAiYuBN8WFRdwYB4i57P73O77BO0tUCpTWbCUmJCN/1OyStupcMbG9qR rkIMXfxS2htRS7/TI5Xg9KEXSNFL0gePnUkHq0vF3NNF/P8byxl3pcNqznGLD9KEXEkh s9RjW4sfjfmBNyEZ7pNma/xebQuB73yfQgjqbq3xBnQ+BTiF9ZC/rYdgLe0/PDSvnIQY gNJw== X-Gm-Message-State: AGi0PuYO8Qgtu9ZEQtgdfbP/rCz7jw14UZePomrqWee5SWVFJY8TtQTb afT1ISSbh0Age7LiEzh1gIu9OQ6zrMXNKpcZKfKRu0DCX1yHoqHtTTm0DwDSpMp0UkUkCc8v26d 3XytT4LHlrldSynZ0bLOTtKa6FLq6xCNzJgNA0yhoUwpZUor2TSvt+mHJezCf801BfKoAe1aMfG Fqvh550kHWQVRLdw+rSYiqihB5v3kTsmc9X8+iKHNVJ2Ew/JenPR7Qm5UyOA== X-Google-Smtp-Source: APiQypLBBAswLgHzxpaqg4mMffGfKkQ6YWHs3xB7FHxnSLiKzGbfkjBlhb+/DWwxklV6ox4d3vMTVp9KtgcxfeAYbSs= X-Received: by 2002:a92:3c82:: with SMTP id j2mr14560396ilf.121.1589179339762; Sun, 10 May 2020 23:42:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 11 May 2020 12:12:08 +0530 Message-ID: Subject: Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework To: Yogesh Mahajan Cc: pgadmin-hackers , Shubham Agarwal , navnath gadakh Content-Type: multipart/alternative; boundary="00000000000008167a05a559a627" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000008167a05a559a627 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, patch applied. On Fri, May 8, 2020 at 3:13 PM Yogesh Mahajan < yogesh.mahajan@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached rebase patch. Looks like there were some commits > after my today's git pull. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > On Fri, May 8, 2020 at 2:35 PM Akshay Joshi > wrote: > >> Hi Yogesh >> >> Unable to apply the patch on the latest code. Please rebase and send it >> again. >> >> On Fri, May 8, 2020 at 2:05 PM Yogesh Mahajan < >> yogesh.mahajan@enterprisedb.com> wrote: >> >>> Attaching patch >>> >>> Thanks, >>> Yogesh Mahajan >>> QA - Team >>> EnterpriseDB Corporation >>> >>> Phone: +91-9741705709 >>> >>> >>> On Fri, May 8, 2020 at 1:57 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Yogesh >>>> >>>> You forgot to attach patch :) >>>> >>>> On Fri, May 8, 2020 at 1:35 PM Yogesh Mahajan < >>>> yogesh.mahajan@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the updates patch with above review comments. >>>>> Patch adds below functionality to existing framework - >>>>> 1.Ability to run features in parallel using solenoid(selenium + >>>>> docker). >>>>> a.Selenoid setup steps are included in /regression/README >>>>> b.'python runtests.py --pkg feature_tests --parallel' will >>>>> trigger parallel feature tests. >>>>> 2.Removes dependency for pyperclip python module. >>>>> 3.New script in ../tools/update_selenoid_browsers.py updates browser >>>>> images at local selneoid server setup. >>>>> >>>>> >>>>> Thanks, >>>>> Yogesh Mahajan >>>>> QA - Team >>>>> EnterpriseDB Corporation >>>>> >>>>> Phone: +91-9741705709 >>>>> >>>>> >>>>> On Tue, May 5, 2020 at 3:58 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Yogesh >>>>>> >>>>>> Following are the review comments: >>>>>> >>>>>> - *pyjq* package is not required as we used it only in one place. >>>>>> A result is a normal dictionary that can be easily looped through= . >>>>>> - Remove "*if (SUPPORT_SSH_TUNNEL is True and ...*" logic from >>>>>> config.py, we have already removed that. >>>>>> - Remove yarn.lock file. >>>>>> - Remove *pyperclip *from the regression/requirements.txt as we >>>>>> are not using it. >>>>>> - Please mentioned the value of *pgAdmin_default_server *should >>>>>> not be '*127.0.0.1*' in the README file even though everything >>>>>> runs on the same machine. >>>>>> - Please mentioned that if we set the value of the browser >>>>>> version is *null* then selenoid will take the latest available >>>>>> browser version. >>>>>> - Got the below error if selenoid_url is not provided: >>>>>> - list index out of range >>>>>> Unable to find Selenoid Status >>>>>> >>>>>> *test_config.json.in *: >>>>>> >>>>>> - "selenoid_info" should be renamed to "selenoid_config". Proper >>>>>> alignment is required. >>>>>> - "cross_Browsers" should be renamed to "cross_browsers" or >>>>>> "run_on_browsers" or "run_tests_on_browsers". Provide entries for= supported >>>>>> browsers with version set to null so that it will run on the late= st browser >>>>>> version. >>>>>> - "selenoid_url": "Selenoid Url" should be changed >>>>>> to "selenoid_url": "http://>>>>> machine>:4444/wd/hub". >>>>>> >>>>>> If you change the names in test_config.json.in then please update >>>>>> the same in README as well. >>>>>> >>>>>> >>>>>> On Mon, May 4, 2020 at 4:27 PM Yogesh Mahajan < >>>>>> yogesh.mahajan@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Akshay, >>>>>>> >>>>>>> Please find the updated patch. >>>>>>> >>>>>>> Thanks, >>>>>>> Yogesh Mahajan >>>>>>> QA - Team >>>>>>> EnterpriseDB Corporation >>>>>>> >>>>>>> Phone: +91-9741705709 >>>>>>> >>>>>>> >>>>>>> On Mon, May 4, 2020 at 2:51 PM Akshay Joshi < >>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Yogesh >>>>>>>> >>>>>>>> The patch is not applied to the master branch. Can you please >>>>>>>> rebase and send the patch again. >>>>>>>> >>>>>>>> On Fri, May 1, 2020 at 12:28 PM Yogesh Mahajan < >>>>>>>> yogesh.mahajan@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please find updated patch modified according to review comments - >>>>>>>>> Patch implements below things - >>>>>>>>> 1.Enable the current framework to provide option to execute >>>>>>>>> Feature tests in parallel on selenium grid set up. >>>>>>>>> - Addition of new switch to start parallel features tests. >>>>>>>>> - New parameters with respect to selenoid in >>>>>>>>> test_config.json.in >>>>>>>>> - Addition of new script to check solenoid updates. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Yogesh Mahajan >>>>>>>>> QA - Team >>>>>>>>> EnterpriseDB Corporation >>>>>>>>> >>>>>>>>> Phone: +91-9741705709 >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Apr 21, 2020 at 1:18 PM Shubham Agarwal < >>>>>>>>> shubham.agarwal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Yogesh, >>>>>>>>>> Below are the review comments- >>>>>>>>>> >>>>>>>>>> 1. runtests.py >>>>>>>>>> a. The exception traceback logic at line number 653 in >>>>>>>>>> runtests.py is not correct since it is particular to the thread >>>>>>>>>> but there is much more code in that block which can throw some >>>>>>>>>> exception. >>>>>>>>>> b. line number 447 -> The drop_database function will only try >>>>>>>>>> to drop the database with the name which is newly created >>>>>>>>>> at 431 line number, its probability is 1% instead of this you ca= n >>>>>>>>>> write a logic so that it will drop all the database which starts= with name >>>>>>>>>> =E2=80=98acceptance_test_db'. >>>>>>>>>> c. line 584 - Why we are including resql test case execution >>>>>>>>>> in GUI execution logic. >>>>>>>>>> d. Change the function name run_test as script name is also >>>>>>>>>> runtests.py >>>>>>>>>> >>>>>>>>>> 2. test_utils.py >>>>>>>>>> a. Remove the headless chrome code from >>>>>>>>>> get_remote_webdriver() in test_utils.py since we are using >>>>>>>>>> solenoid and it is not required anymore. >>>>>>>>>> b. Create separate functions to instantiate the firefox >>>>>>>>>> driver and chrome driver logic since the same code is used in mu= ltiple >>>>>>>>>> files. >>>>>>>>>> c. launch_url_in_browser() -> you can simplify the definition of >>>>>>>>>> the function like: >>>>>>>>>> retry =3D 60 >>>>>>>>>> =EF=BB=BF *while *retry > 0: >>>>>>>>>> try: >>>>>>>>>> driver.get(url) >>>>>>>>>> except WebDriverException: >>>>>>>>>> retry -=3D 1 >>>>>>>>>> 3. Execution logs are not printing as per the logic some time, I >>>>>>>>>> ran the suite for two servers and attached are the execution log= s. >>>>>>>>>> 4. Readme - >>>>>>>>>> Please provide the Valid selenoid URL to be provided in the >>>>>>>>>> test_config.json, with all the steps mentioned in the readme it = is not >>>>>>>>>> clear. >>>>>>>>>> Revisit the readme and write the missing steps. >>>>>>>>>> 5. copy_selected_query_results_feature_tests.py- >>>>>>>>>> Create the function to avoid duplicate code. The code for pastin= g >>>>>>>>>> the values is repeating 8 times in the test code. >>>>>>>>>> 6. Provide the valid docstring in newly introduced functions and >>>>>>>>>> also valid comments while calling it. for ex.- _update_preferenc= e() >>>>>>>>>> function is >>>>>>>>>> introduced in pg_utilities_backup_restrore_test.py but from the >>>>>>>>>> function name, it is not clear what preferences are going to upd= ate in it. >>>>>>>>>> 7. test_index_constraint_add test case is failing due to the >>>>>>>>>> latest change, please merge and update this test case >>>>>>>>>> >>>>>>>>>> On Thu, Apr 16, 2020 at 2:41 PM navnath gadakh < >>>>>>>>>> navnath.gadakh@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> I think I am not the right person to review this patch now as I >>>>>>>>>>> already reviewed this code offline in the last week. I know the= approached >>>>>>>>>>> Yogesh has followed, also given some review comments on it. >>>>>>>>>>> Someone else please review it. >>>>>>>>>>> >>>>>>>>>>> Thanks! >>>>>>>>>>> >>>>>>>>>>> On Mon, Apr 13, 2020 at 2:49 PM Akshay Joshi < >>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Navnath >>>>>>>>>>>> >>>>>>>>>>>> Can you please review it? >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Apr 13, 2020 at 2:40 PM Yogesh Mahajan < >>>>>>>>>>>> yogesh.mahajan@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> Please find the attached patch for running *features tests* >>>>>>>>>>>>> using solenoid(selenium grid + docker). >>>>>>>>>>>>> KIndly review. >>>>>>>>>>>>> To sun feature tests in parallel, required prerequisites can >>>>>>>>>>>>> be checked in '~/web/regression/README' file. >>>>>>>>>>>>> Also detailed instructions are added in the same file. >>>>>>>>>>>>> After applying the patch, any existing process for execution >>>>>>>>>>>>> of API/Features tests remains the same. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Yogesh Mahajan >>>>>>>>>>>>> QA - Team >>>>>>>>>>>>> EnterpriseDB Corporation >>>>>>>>>>>>> >>>>>>>>>>>>> Phone: +91-9741705709 >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>>> >>>>>>>>>>>> *Sr. Software Architect* >>>>>>>>>>>> *EnterpriseDB Software India Private Limited* >>>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Regards, >>>>>>>>>>> Navnath Gadakh >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Thanks & Regards, >>>>>>>>>> Shubham Agarwal >>>>>>>>>> EnterpriseDB Corporation >>>>>>>>>> >>>>>>>>>> The Postgres Database Company >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Thanks & Regards* >>>>>>>> *Akshay Joshi* >>>>>>>> >>>>>>>> *Sr. Software Architect* >>>>>>>> *EnterpriseDB Software India Private Limited* >>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> >>>>>> *Sr. Software Architect* >>>>>> *EnterpriseDB Software India Private Limited* >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > --=20 *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000008167a05a559a627 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Fri, May 8, 2020 at 3:13 PM Yoges= h Mahajan <yogesh.mah= ajan@enterprisedb.com> wrote:
Hi Akshay,

Please = find the attached rebase patch. Looks like there were some commits after my= today's git pull.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Fri, May 8, 2020 at 2:35 PM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi=C2=A0Yogesh

Unable to = apply the patch on the latest code. Please rebase and send it again.
<= /div>
O= n Fri, May 8, 2020 at 2:05 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com<= /a>> wrote:
<= div dir=3D"ltr">Attaching patch=C2=A0

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Fri, May 8, 2020 at 1:57 PM Akshay Joshi = <aksh= ay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Yogesh

You forgot to attach patch :)

On Fri, May 8, 2020 at 1:35 PM Yogesh M= ahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,
Please find the updates patch with above review comments.=
Patch adds below functionality to existing framework -=C2=A0
1.Ability to run features in parallel using solenoid(selenium + dock= er).
=C2=A0 =C2=A0 =C2=A0a.Selenoid=C2=A0setup steps are included= in /regression/README
=C2=A0 =C2=A0 =C2=A0b.'python runtests= .py =C2=A0--pkg feature_tests --parallel' will trigger parallel feature= tests.
2.Removes dependency for pyperclip python=C2=A0module.
3.New script in ../tools/update_selenoid_browsers.py updates=C2=A0b= rowser images=C2=A0at local selneoid server setup.


Thanks,
Yoges= h Mahajan
QA - Team
EnterpriseDB Corporation
Phone: +91-9741705709

=
On Tue= , May 5, 2020 at 3:58 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wro= te:
Hi=C2=A0Yogesh

Following are the review comments:
  • pyjq package is not required as we used it onl= y in one place. A result is a normal dictionary that can be easily looped= =C2=A0through.
  • Remove "if (SUPPORT_SSH_TUNNEL is True and .= .." logic from config.py, we have already removed that.
  • Re= move yarn.lock file.
  • Remove=C2=A0pyperclip from the regressi= on/requirements.txt as we are not using it.
  • Please mentioned the va= lue of=C2=A0pgAdmin_default_server should not be '127.0.0.1' in the README file even though everything runs on the same machine.=
  • Please mentioned that if we set the value of the browser version i= s null then selenoid=C2=A0will take the latest available browser ver= sion.
  • Got the below error if selenoid_url is not provided:
      • =
    • list index out of range
      Unable to find Selenoid Status
  • "selenoid_info" shoul= d be renamed to "selenoid_config". Proper alignment is required.<= /li>
  • "cross_Browsers" should be renamed to "cross_browser= s" or "run_on_browsers" or "run_tests_on_browsers"= . Provide entries for supported browsers with version set to null so that i= t will run on the latest browser version.
  • "selenoid_url":= "Selenoid Url" should be changed to=C2=A0"selenoid_url"= ;: "http://<IP address of Selenoid Installed machine>:4444/wd/hu= b".
If you change the names in test_config.json.in then please update= the same in README as well.

On Mon, May 4, 2020 = at 4:27 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
<= /div>
Hi = Akshay,

Please find the updated patch.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741= 705709


On Mon, May 4, 2020 at = 2:51 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Yoge= sh

The patch is not applied to the master branch. Can yo= u please rebase and send the patch again.

On Fri, May 1, 2020 at 12:28= PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,
Please find updated patch modified according to review comment= s=C2=A0-=C2=A0
Patch implements below things=C2=A0-=C2=A0
1.Enable the current framework to provide option to execute Feature test= s in parallel =C2=A0on selenium grid set up.
=C2=A0 =C2=A0- Addit= ion of new switch to start parallel features tests.
=C2=A0 =C2=A0= - New parameters with respect to selenoid in test_config.json.in
=C2=A0 =C2=A0-= Addition of new script to check solenoid=C2=A0updates.



Thanks,
Yogesh Mahajan
QA - Team
Enterprise= DB Corporation

Phone: +91-9741705709

On Tue, Apr 21, 2020 at 1:18 PM Shubham Agarwal <shubham.agarwal@ente= rprisedb.com> wrote:
Hi Yogesh,
Below are the re= view comments-

1. runtests.py
=C2=A0 =C2=A0 a. The exception traceback logic at line number= 653 in runtests.py is not correct since it is particular to the thread
but there is much more code in th= at block which can throw some exception.
b. line = number 447 -> The drop_database function will only try to drop the datab= ase with the name which is newly created
at 431 line number, its probability is 1% instead of this you ca= n write a logic so that it will drop all the database which starts with nam= e =E2=80=98acceptance_test_db'.
=C2=A0 c. line 584 -=C2=A0Why we are including resql te= st case execution in GUI execution logic.
=C2=A0 =C2=A0 d.=C2=A0Change the function name run_test as script name is also runtest= s.py

<= /div>
2. test_utils.py
=C2=A0 =C2=A0 a.=C2=A0Remove the headless chrome code from get_remote_webdriver(= ) in test_utils.py since we are using solenoid and = it is not required anymore.
=C2=A0 =C2=A0 b. Create separate functions t= o instantiate the firefox driver and chrome driver logic since the same cod= e is used in multiple files.
c. launch_url_in_browser() = -> you can simplify the definition of the function like:
=C2=A0 =C2=A0=C2=A0retry =3D 60
=EF=BB= =BF=C2=A0 =C2=A0 =C2=A0 =C2=A0 while=C2=A0retry > 0:
=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 try:
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 driver.get(url)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 except = WebDriverException:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0retry -=3D 1
3. Execution logs are not pri= nting as per the logic some time, I ran the suite for two servers and attac= hed are the execution logs.
4. Readme -
Pleas= e provide the Valid selenoid URL to be provided in the test_config.json, wi= th all the steps mentioned in the readme it is not clear.
Revisit the readme and write the missi= ng steps.
5. copy_select= ed_query_results_feature_tests.py-
Create the function to avoid duplicate code. The code for pas= ting the values is repeating 8 times in the test code.
<= div>6. Provide the valid docstring in newly intr= oduced functions and also valid comments while calling it. for ex.- _update= _preference() function is
7. test_index_constraint_add test case is failing= due to the latest change, please merge and update this test case

On Thu, Ap= r 16, 2020 at 2:41 PM navnath gadakh <navnath.gadakh@enterprisedb.com> = wrote:
Hi,
<= font face=3D"arial, sans-serif">I think I am not the right person to review= this patch now as I already reviewed this code offline in the last week. I= know the=C2=A0approached Yogesh has followed, also given some review comme= nts on it.
Someone else p= lease review it.=C2=A0
Thanks!

=
On M= on, Apr 13, 2020 at 2:49 PM Akshay Joshi <akshay.joshi@enterprisedb.com> = wrote:
Hi Navnath

Can you please review it?

On Mon, Apr 13, 2020 at 2:40 PM= Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Ple= ase find the attached=C2=A0patch for running features tests using so= lenoid(selenium=C2=A0grid + docker).
KIndly review.
Also detailed=C2=A0instructions are added in the same=C2= =A0file.
After applying t= he patch, any existing process for execution of API/Features=C2=A0tests rem= ains the same.


<= div>
Than= ks,
Yogesh Mahajan
=
QA - Team
EnterpriseDB Corporation

Phone: +91-9741= 705709


--
Thanks & Regards=
A= kshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Regards,
Navnath = Gadakh


--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000008167a05a559a627--