Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVvYH-0002yl-G4 for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Oct 2020 11:48:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kVvYG-0004xI-ET for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Oct 2020 11:48:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVvYG-0004w5-82 for pgadmin-hackers@lists.postgresql.org; Fri, 23 Oct 2020 11:48:08 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kVvYD-0005F7-Oz for pgadmin-hackers@postgresql.org; Fri, 23 Oct 2020 11:48:07 +0000 Received: by mail-io1-xd41.google.com with SMTP id z5so1415814iob.1 for ; Fri, 23 Oct 2020 04:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yDZxbQzxpc1eZ5PfQhlD0TDWgCnHStlyYNdjE8HbtWw=; b=lm5n4kvEG69swNqd4BsNPsiO8jpGdy83+hT3wVGb8yLkPGhkp7xDK6f2Hlt6/53vRz HXZtOaKu+mXEuVSorQggIjIo8vIl9lKog06NC2nX+qOMRE6Ey3V1zMUWe6Lix3DP22RL pw16JnEZVdAm8+5kG7+CFtaplKtA5o/5/LDxtdM8CSOVevaeECSqiG4d1DHQPEu80iuh jKzb1KfaDBPN96nQjagVDmd7xTF84FmTJ0guoJGjrwcF625RQzZ1C30HCNkLjzrbASHM LGMm+xtyNMWT6EBiGIIN3M5Daw+xeCVq2Ggjwz/fW2CZJcIyA3AYk+5qecwjfvtm9r7a lEBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yDZxbQzxpc1eZ5PfQhlD0TDWgCnHStlyYNdjE8HbtWw=; b=bpuiPF2b2G5yNZ0XiSFZWSPz2iy7Jyf651TZy8tJsNZUIGeeSzy9/7vmLrGIaIRLEq Q93S5QG8iwY2RvMwYqNc2DHVuoETogJXaYVEx3eFs+9w63AeBVzvKBHQY6LZg686JQzP /waelafhsURfbQ+MZYM6o+mXbqlSZRWzOP4HSI+ar1fqIBt3DO0HN2mg5rhLFtcP00SE 0yTZq7yITTZIyrt5L+UF6mMp5XDDsmqej8rDdD6ttBhW71CbrI2D1c0eOPdxTGOhWt4/ vtJHf4Lu6fPzU+/csORtF3PUGjGmuz5MYLtqCuyxdc9YHjZp9ZBu/d42pfyW3iEf1TAL hFLg== X-Gm-Message-State: AOAM530gZvbKMqqZONxkIZ81Kdc5Bd2gvkXV/zUXDNzpTmBox8P48T3c 4iDAomrLLnL4WR7V/bhmbLUlNKuILmkEOu1dB7J76SID3FLsyJWBA7KPCUDbZRTozmzPtNPxJ0b AFIER02RjP6YwMgjqfbfFL9NPG5DEuxqreVtvAkBqjXc5OvikqyWYJ1/0cTvHTHRXX+WEeRSl52 V2/g1ldPm1rGYu202yfZlaz7bY9qmtV3O6TckZTdKlXNNnbVI1Y28bIe76aA== X-Google-Smtp-Source: ABdhPJx3XMEOkdTdspr1Q2xn/7EGVoBZ1TG9wvOybAnyf0xObUCZiH2U3v2LmApNFXJhIwn+Z//QRR3nHUQj1BX0xNg= X-Received: by 2002:a05:6638:606:: with SMTP id g6mr1647519jar.0.1603453684012; Fri, 23 Oct 2020 04:48:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 23 Oct 2020 17:17:53 +0530 Message-ID: Subject: Re: [pgAdmin][RM3318] Download Backup Files To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000400e2c05b25527fe" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000400e2c05b25527fe Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Fri, Oct 23, 2020 at 3:35 PM Rahul Shirsat < rahul.shirsat@enterprisedb.com> wrote: > Hi Akshay, > > Please find below comments on review points. > > On Wed, Oct 21, 2020 at 4:56 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >> - Add "..." to the Storage Manager menu - *DONE* >> - Storage manager icon is not visible on process watcher if we >> provide file name without directory. - *DONE* >> - Renaming the directory not working from Storage Manager. - As >> discussed in scrum update on 23'Oct, this issue would be taken care in >> RM5943 >> >> Please fix and send the patch. >> >> On Tue, Oct 20, 2020 at 9:27 PM Rahul Shirsat < >> rahul.shirsat@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the below patch which allows users to download the backup >>> and export files generated on shared drive. >>> >>> -- >>> *Rahul Shirsat* >>> Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000400e2c05b25527fe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Fri, Oct 23, 2020 at 3:35 PM = Rahul Shirsat <rahul.s= hirsat@enterprisedb.com> wrote:
Hi Akshay,

Please find below comments on review points.
On Wed, O= ct 21, 2020 at 4:56 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote= :
Hi=C2=A0Rahul

Following are the=C2=A0review comments:=
  • Add "..." to the Storage Manager menu - DON= E
  • Storage manager icon is not visible on process watcher if we = provide file name without=C2=A0directory. - DONE
  • Renaming th= e directory not working from Storage Manager. - As discussed in scrum updat= e on 23'Oct, this issue would be taken care in RM5943=C2=A0
= Please fix and send the patch.

On Tue, Oct 20, 2020 at 9:27 PM Rahul S= hirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the below patch=C2=A0which allows users to download the = backup and export files generated on shared drive.

--
= Rahul Shirsat
Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000400e2c05b25527fe--