Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qR5iE-000WGx-EP for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Aug 2023 06:52:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qR5iC-003DTY-St for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Aug 2023 06:52:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qR5iC-003DTP-9C for pgadmin-hackers@lists.postgresql.org; Wed, 02 Aug 2023 06:52:00 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qR5i8-0005R4-In for pgadmin-hackers@postgresql.org; Wed, 02 Aug 2023 06:51:58 +0000 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b9fa64db41so23839271fa.1 for ; Tue, 01 Aug 2023 23:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1690959114; x=1691563914; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Csk1Z3KGRZvqGUb9ZXeN333elwIAqO3nkkrC0fv0nhQ=; b=ec72+1EFe4gSv1pl4jqg2ncvoNhKAw0Mvw4FayPrioc1P1klgNvsi6HTYdHcFskqhU AIZDdn/4FGl2sxwPId3i8BuKpETFduXXa3YsbjmhNXSaGiS44pqUmV1DvAypGJpRCnKM HUdGwqIMwjSty93PWg9oJ9rle/a7T0IxslSlb1uNmdoFC2/kjPuS2O6p6K2vs2QGXZhx MG2a0xr1DBLtNwmAKNpeFZGWcsTdhBcqvNtB7ay/5KsRtFKtSxKaz1nJdEqn5an34gy8 bfzwS+1bFjqWq1vA/MAwQq8lbCtDmxNwy2G2qUcfVH4nBKFuZGZQ5m49bXMo2g1eYZ0n B+eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690959114; x=1691563914; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Csk1Z3KGRZvqGUb9ZXeN333elwIAqO3nkkrC0fv0nhQ=; b=fnwY6jsCrKWWTxom7z4QTkb/10FMKOHj5Kxb+k4RKV+Rkaap6PmW0umoLbSW3eMQT4 at0oz4FCiavWPCIPty58TI9e+0zu0ehWSDoa1Ra9IsFGX43vrVlKsuULa2Exfhu6h/7Q 76sUw64uWxxFdx5zRpUd3KSxoAqE4r8tWrB+a7asfZSI2HV4uDRp/ximJXFwEM8EZcVe 3RNzd3fc8JRR5X0Jyeo6r55bz2/K+IsvFONXN+BjdyN5uRzBUUubofskXXWshkEuJyZr rmg3DKCxY/7XVcVJvUJOlMF/pQ04FfJJe20jE85osYlp6BIwZlQEmbQxKdtpsDO+myBs 5BTg== X-Gm-Message-State: ABy/qLZM7ldSp2wgCeFTDJ/CvkU8c2X9kGa8B3eWDTtPIkiyvKfBWgo2 ojnAmd5owtSX8EGv7AHPvpLWDRO68zja/8TvWxowVA== X-Google-Smtp-Source: APBJJlHpff+ihnWaStBAOhZb1/MunuK+OM50kSPVG946OeNE33nldOfjEVqN+Z+TGKJiDTUFYyle7kk7iEUDkT0QtOc= X-Received: by 2002:a2e:98d0:0:b0:2b6:9ed0:46f4 with SMTP id s16-20020a2e98d0000000b002b69ed046f4mr4417104ljj.23.1690959114484; Tue, 01 Aug 2023 23:51:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 2 Aug 2023 12:21:43 +0530 Message-ID: Subject: Re: Implement new options to the Subscription of pgAdmin 4 To: Anil Sahoo Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000595c190601eb1974" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000595c190601eb1974 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Anil I would suggest getting the 'Origin' field after streaming and making two switch controls in one row as we did in the Backup dialog. If you are adding a help message to the switch controls then leave it as it is. Apart from that it looks good to me. On Tue, Aug 1, 2023 at 11:56=E2=80=AFAM Anil Sahoo wrote: > Hi Hackers, > > I am currently working on the features #4805 and #6454. There are some ne= w > options being added to the WITH clause of subscription that are listed > below. > For PostgreSQL 14 and above: > > 1. binary(boolean): Specifies whether the subscription will request > the publisher to send the data in binary format. > 2. streaming(boolean): Specifies whether streaming of in-progress > transactions should be enabled for this subscription. > > For PostgreSQL 15 and above: > > 1. two_phase(boolean): Specifies whether two-phase commit is enabled > for this subscription. > 2. disable_on_error(boolean): Specifies whether the subscription > should be automatically disabled if any errors are detected by subscri= ption > workers during data replication from the publisher. > > For PostgreSQL 16 and above: > > 1. password_required(boolean): Specifies whether connections to the > publisher made as a result of this subscription must use password > authentication. > 2. run_as_owner(boolean): If true, all replication actions are > performed as the subscription owner. If false, replication workers wil= l > perform actions on each table as the owner of that table. > 3. origin(string): Specifies whether the subscription will request the > publisher to only send changes that don't have an origin or send chang= es > regardless of origin. > > Attaching the respective screenshots of the updated UI for reference. > Please review it. > > Thanks > Anil Sahoo > > -- > > > > *Anil Sahoo* > > Software Engineer > > www.enterprisedb.com > > Power to Postgres > > > > > > --000000000000595c190601eb1974 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Anil

I would suggest getting=C2= =A0the 'Origin' field after streaming and making two switch control= s in one row as we did in the Backup dialog. If you are adding a help messa= ge to the switch controls then leave it as it is.

= Apart=C2=A0from that it looks=C2=A0good to me.

On Tue, Aug 1, 2023 at = 11:56=E2=80=AFAM Anil Sahoo <anil.sahoo@enterprisedb.com> wrote:
Hi Ha= ckers,

I am currently working on the features #4805 and #6454. There are som= e new options being added to the WITH clause of subscription that are liste= d below.
For PostgreSQL 14 and above:<= /font>
  1. binary(boolean):=C2=A0Specifies whether the subscription will request the publisher to= send the data in binary format.
  2. streaming(boolean):=C2=A0Specifies whether streaming of in-progre= ss transactions should be enabled for this subscription.
    3. =
For PostgreSQL 15 and above:
  1. two_phase(boolean):=C2=A0Sp= ecifies whether two-phase commit is enabled for this subscription.
  2. disable_on_error(boolean):=C2= =A0Specifies whether the subscription should be automatically disabled if a= ny errors are detected by subscription workers during data replication from= the publisher.
For P= ostgreSQL 16 and above:
  1. password_required(boolean):=C2=A0Specifies whether connections= to the publisher made as a result of this subscription must use password a= uthentication.
  2. run_as_o= wner(boolean):=C2=A0If true, all replication actions are performed as the s= ubscription owner. If false, replication workers will perform actions on ea= ch table as the owner of that table.
  3. origin(string):=C2=A0Specifies whether the subscription wil= l request the publisher to only send changes that don't have an origin = or send changes regardless of origin.
Attaching the respective sc= reenshots of the updated UI for reference. Please review it.<= /div>
Thanks
Anil Sahoo

--

Anil Sahoo

Software Engineer

www.enterprisedb.com

Power to Postgres

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0

--000000000000595c190601eb1974--