MIME-Version: 1.0
References: 
 <CAOBg0AM=b7hfJjTJAXu=wGkKHEsV_zoZpSO-QU6Z-G9p2wVF0w@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AM=b7hfJjTJAXu=wGkKHEsV_zoZpSO-QU6Z-G9p2wVF0w@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 21 Sep 2020 17:24:06 +0530
Message-ID: 
 <CANxoLDdUj_RKgQWFE6F7noEJbDz+P_3-njnn2mf10TSa0V9wdw@mail.gmail.com>
Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from
 an Open Query Tool Tab
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000008d981b05afd18255"
Precedence: bulk

--0000000000008d981b05afd18255
Content-Type: text/plain; charset="UTF-8"

Hi Nikhil

Following are the initial review comments:

   - Open View/Edit data on any table and click on the same database
   connection and then click on the Execute button. Got "get_primary_keys()
   takes 1 positional argument but 2 were given" error.
   - In my opinion, we should hide the option to change the database
   connection for View/Edit Data.
   - If the user clicks on the same database connection multiple times then
   no need to change the backend connection and transaction id. Add validation
   at the backend, no action required in this case.
   - The role option is missing from the "connect to server" dialog.
   - The Password field should not be there on the "connect to server"
   dialog. Sometimes we saved the password so asking a password every time is
   not correct. Check the pgAdmin 3 behavior.

Code review still remains.

On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
nikhil.mohite@enterprisedb.com> wrote:

> Hi Team,
>
> Regarding RM-3794 <https://redmine.postgresql.org/issues/3794> allow
> the user to change the database connection from an open query tool:
> I have implemented the feature and also added documentation for it.
>
> PFA patch.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--0000000000008d981b05afd18255
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Nikhil<div><br></div><div>Following are the initia=
l review comments:<div><ul><li>Open View/Edit data on any table and click o=
n the same database connection and then click on the Execute button. Got &q=
uot;get_primary_keys() takes 1 positional argument but 2 were given&quot; e=
rror.</li><li>In my opinion, we should hide the option to change the databa=
se connection for View/Edit Data.</li><li>If the user clicks on the same da=
tabase connection multiple times then no need to change the backend connect=
ion and transaction id. Add validation at the backend, no action required i=
n this case.</li><li>The role option is missing from the &quot;connect to s=
erver&quot; dialog.</li><li>The Password field should not be there on the &=
quot;connect to server&quot; dialog. Sometimes we saved the password so ask=
ing a password every time is not correct. Check the pgAdmin 3 behavior.</li=
></ul>Code review still remains.</div></div></div><br><div class=3D"gmail_q=
uote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Sep 17, 2020 at 4:15 PM=
 Nikhil Mohite &lt;<a href=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil=
.mohite@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex"><div dir=3D"ltr">Hi Team,<div><br></div><div>Regard=
ing <a href=3D"https://redmine.postgresql.org/issues/3794" target=3D"_blank=
">RM-3794</a> allow the=C2=A0user to change the database connection from an=
 open query tool:</div><div>I have implemented the feature and also added d=
ocumentation for it.</div><div><br></div><div>PFA patch.<br><div><br></div>=
<div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><b><font face=3D"verdana, san=
s-serif">Thanks &amp; Regards,</font></b><div><b><font face=3D"verdana, san=
s-serif">Nikhil Mohite</font></b></div><div><b><font face=3D"verdana, sans-=
serif">Software Engineer.</font></b></div><div><a href=3D"https://www.enter=
prisedb.com/" target=3D"_blank"><b><font face=3D"verdana, sans-serif">EDB P=
ostgres</font></b></a></div><div><b><font face=3D"verdana, sans-serif">Mob.=
No: +91-7798364578.</font></b></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Sr. Software Architect</span></b></font></div><font color=3D"#00=
0000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.com" targ=
et=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:rgb(51,=
51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-=
size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></span></b>=
<br></div></div></div></div></div></div></div>

--0000000000008d981b05afd18255--