Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEsmX-0006Lx-Jl for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 10:52:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEsmW-0003bj-Cj for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 10:52:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEsmW-0003bb-1R for pgadmin-hackers@lists.postgresql.org; Thu, 19 Mar 2020 10:52:08 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEsmT-0002WM-Eh for pgadmin-hackers@postgresql.org; Thu, 19 Mar 2020 10:52:06 +0000 Received: by mail-il1-x133.google.com with SMTP id j69so1739304ila.11 for ; Thu, 19 Mar 2020 03:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UYRZbtQgEwy1StgnfG2LDTUEMMGHcgUnE5xFpzT/Ch8=; b=kpT2XSmWqjVUleiMx3kynZ5m3eJqzFRngWojyzDYndmxIKW8+O9uug6yEgxl35Za4O icVeocBtQs0bhT8OtW4/ZlZfpQr8kO5Cs61ogi0MM0vTvVY6k9zF0cue4ezsNjLNOVVK BwPuSANBuG7vpAzTP7Js3GPc1879G9G614Vl+SgfkeogX16kOjugiGnc+tOIv5pop7eE xwHJ4Oqgn9nuo2mrOipK310CpqdZKABt2KtzjGhwDpYOWYS9LRj9DDEzqcbbiN4bjViE 59HU5U161ELCDqYKLRxDrQYUKZkRelgVOZou+o6crb24l24BRFLOL+z+hcfxEvlwDjAT 2Cqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UYRZbtQgEwy1StgnfG2LDTUEMMGHcgUnE5xFpzT/Ch8=; b=onteg3/4G3MRzs5t8Qdd9v7oZd/qtqos+getvpwmENKs0OhztMmdxNOl8WuBJjF0A0 O36pFkIJn4hO3L+v8Bch6khlNqTVmH8UMrIsJ/+cBkmbZMmwKp1uuCuFxCIHKPqExdyG 1NRvG+fvvue/1kG2bG96NaEiENgqg8Yo2GNDxJz41NwO3qAUx8MqyJ1oE/FTrO/Ox9eX 597LKsZuMLBnqYpWKrQ2pEmeP47AVmr72SsQK3i0P5fHA/YX8vnR23YQL7kq63zGJGGx /9TXt88v8+HODGfljz355tcZrd39eoZ2MDUJlryjyo4yFMB0AVA5Ks9eiJ8lUSlfBXQj JSMw== X-Gm-Message-State: ANhLgQ3rVnGrd/Ma+7izgoBnawYgB0i0Gkajs/7fPggVEqe79O2DGLG8 Y7G7VRogcr0BOXGAr2fiULwHaYN7+eVYk0p8bVWj7hxN9IF1/KT1KbhRzbxSTljwXrDcsXDyaKW L5lDaU8gXnFX8LiFz2RxuOVVEq12OVZ3iS59zAOLjvE5mxmZzKr/nNo32+FJl2GjhJAUttsMQxh rn3KJFCouH/LYrI+7XRDAdI/P5ZG2vcRqfOWMFqDmdu7t1XkKqAoA= X-Google-Smtp-Source: ADFU+vubbiDy51A4LGM+fLZSiC2T2JDexzHlJKS6whdv1YV4c+0wBRTsTE+AO197Lp60VVqJuGbiOByWl/AL8pt6Bdg= X-Received: by 2002:a92:8901:: with SMTP id n1mr2729871ild.176.1584615124403; Thu, 19 Mar 2020 03:52:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 19 Mar 2020 16:21:53 +0530 Message-ID: Subject: Re: [Accessibility] RM4608 Few issues in the dialogs. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000098a7ed05a132f5ec" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000098a7ed05a132f5ec Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Mar 19, 2020 at 2:48 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > Please find the things which I have fixed in this patch. > > Fixed some accessibility issues: > 1) Aria-label additions at few missing places. > 2) Label additions with 'sr-only' class where hidden labels required. > 3) Converted label to span to solve accessibility error. > > I also incorporated the review comments given by Khushboo related to > RM4237. It was related to DateTime picker control using the keyboard. > > On Thu, Mar 19, 2020 at 2:32 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Pradip >> >> Can you please list down the things that you have fixed in this patch. >> >> On Thu, Mar 19, 2020 at 2:26 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the patch for accessibility errors in some of the dialogs. >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000098a7ed05a132f5ec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Mar 19, 2020 at 2:48 PM Prad= ip Parkale <pradip.pa= rkale@enterprisedb.com> wrote:
Hi= Akshay,
Please find the things which I have fixed in this patch.=

Fixed some accessibility = issues:
1) Aria-label additions at few missing places= .
2) Label additions with =C2=A0'sr-only' cla= ss where hidden labels required.
3) Converted label t= o span to solve accessibility error.

I also incorporated the review comments=C2=A0given by Khushboo related t= o RM4237. It was related to DateTime picker control=C2=A0using the keyboard= .

On Thu, Mar 19, 2020 at 2:32 PM Akshay Joshi <akshay.joshi@enterpri= sedb.com> wrote:
Hi Pradip

Can you please list d= own the things that you have fixed in this patch.=C2=A0

On Thu, Mar 19= , 2020 at 2:26 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrot= e:
Hi Hackers,

Please find the patch for accessibility= =C2=A0errors in some of the dialogs.


<= /div>--
Thanks & Regards,
Pradip Pa= rkale
QMG, EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000098a7ed05a132f5ec--