public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Yogesh Mahajan <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][Patch] - Feature #6395 - Feature request: Log Rotation
Date: Tue, 25 May 2021 20:19:38 +0530
Message-ID: <CANxoLDdeu5Y4HYnZCqJt7GzTiUrAzOmNK-OBrOvsSdt=ZFz4bA@mail.gmail.com> (raw)
In-Reply-To: <CAMa=N=PeMQUrvz-TFK7To4og+q6d0bcfRQp3XDzBTwHtBWPhCg@mail.gmail.com>
References: <CAMa=N=OAkNDvwX+c6VA1+9PDBtdHt+fTYKm8nwm8jt-BOh=9BQ@mail.gmail.com>
<CANxoLDcgwrETt6B0PuLLTshr8CyPqFegVL3OOP7xOfb1bXFYPg@mail.gmail.com>
<CAMa=N=PeMQUrvz-TFK7To4og+q6d0bcfRQp3XDzBTwHtBWPhCg@mail.gmail.com>
Thanks, patch applied.
On Tue, May 25, 2021 at 4:59 PM Yogesh Mahajan <
[email protected]> wrote:
> Hello,
>
> Please find the attached file incorporated with the above comments except
> the 2nd one.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Tue, May 25, 2021 at 1:09 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Yogesh
>>
>> Following are the review comments:
>>
>> - LOG_ROTATION_MAX_LOGS should be renamed to
>> LOG_ROTATION_MAX_LOG_FILES
>> - Rollover file name should have '.log' extension at the end instead
>> of "pgadmin4.log.2021-05-25_12-17-43"
>> - Add comments in the 'enhanced_log_rotation.py' file.
>> - 'enhanced_log_rotation.py' file line no 23 should be "max_bytes =
>> max_bytes * 1024 * 1024" instead of "max_bytes = max_bytes * 1000000"
>>
>>
>> On Tue, May 25, 2021 at 10:54 AM Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch which rotates the pgadmin log file with
>>> context to the parameters specified in the config file.
>>>
>>> # Log rotation setting
>>> LOG_ROTATION_SIZE = 10 # In MBs
>>> LOG_ROTATION_AGE = 1440 # In minutes
>>> LOG_ROTATION_MAX_LOGS = 90 # Maximum number of backups to retain
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][Patch] - Feature #6395 - Feature request: Log Rotation
In-Reply-To: <CANxoLDdeu5Y4HYnZCqJt7GzTiUrAzOmNK-OBrOvsSdt=ZFz4bA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox