Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTjAc-0002ND-ME for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Apr 2021 10:42:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lTjAb-0007lH-Ee for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Apr 2021 10:42:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTjAb-0007lA-9M for pgadmin-hackers@lists.postgresql.org; Tue, 06 Apr 2021 10:42:53 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lTjAX-0005Ca-ON for pgadmin-hackers@postgresql.org; Tue, 06 Apr 2021 10:42:52 +0000 Received: by mail-io1-xd2f.google.com with SMTP id n198so12827111iod.0 for ; Tue, 06 Apr 2021 03:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b9zXqL0pBu27LOGCyQt47Pff2VXWXi0BX2XpEH0ovEc=; b=YpT6AlrsMemtO76aGujRHVnm9zEBw/YaDHUYtjXlGZnIBbW6WQbbAiccW15zu4hhgq lBDnj2SQhCYJ/vpA3xc04fzAMXRZnqBcwqW61jigAl7ZcgqAqP/grXz6/L1XLdRTbE3Y nOYzcC3Zpqs7q+yxb2OrgxiczQ6DWifmVgs57C7D6xnJDQTEYSa3yo533cG71FNnzW1l dnJHt3BYhonpb0l+IgbxT8C18HD3NSLBULSyJ9QVFnt8KtVIYbhhn9BlNXohf2wym3Dr aJ68LsQDsUapv9VhVCL2vWJWIt/WmoK17pz1bsh+CFU8J6B3K3l+E77Kllq4MJ0n+6kW ST6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b9zXqL0pBu27LOGCyQt47Pff2VXWXi0BX2XpEH0ovEc=; b=S1/bTWoTXuc1Ny8umdLKq7gQ66YMk3EHzPE8Z4tt5vk6wvMuyHLdXf6b2hhpDrUeD2 aYlgJ2UR/m+iy8yBAXYYUhuekg0LOQVYZWyuJ8mYbKZeqibK3+gyju5ab0kNXRLZua/h ht2PHOMvar0r0Ng2M+04fC0x3L+fujJMkE1Tf9Viii5jwkqKNk09jIYwC2FHVdiKiDuk 2L6wl5OJuDZvbwqfBxrNdZ7wXk8gWR2lDh5xPkMcmyt+1M2Bma1Gl0EaQsB+62vRyHoa tzKS3XXFlYCxHb1rD1eqxCmxFezR7t+JSrM5tAg0KDHXG0AXdni7e5EMrXsj1Mi6gG8i MxfA== X-Gm-Message-State: AOAM533brR5fFC1crvxzRVVsZ+lcUnLP5libergyzmZ5abXspapFxW+M bP+JAQVddbWTclet2NvUzQ7sdohMEYte1JWwXvJGyQ+G+aXwRqUuc3kaIVH4CuOynYZ5MKDWA7J 5Se0ALKSGdgWiAyondAZN0UYxwXh2a/vssRsAYQ3qA3ocADoKfp9Agf5twpOGDUqh1/v8VsFUks g7BqsOZP1gpdpopA1teKib0eHHJsRbraah3dMEyxHYLHDShN58QL1ukh4Uhi1wPFU= X-Google-Smtp-Source: ABdhPJxRa7OyJZlcwfVQ/Mw5viTSSit6Z8r6oP7yCpnpmmr6OYHw65RWgq59QWXgc+0TtqsMTn1KX69ujiJBg11Wl98= X-Received: by 2002:a5d:8707:: with SMTP id u7mr22669786iom.18.1617705767427; Tue, 06 Apr 2021 03:42:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 6 Apr 2021 16:12:36 +0530 Message-ID: Subject: Re: [pgAdmin] [patch] RM6333 Help dialog issue if we set "Open in new browser tab" for Query tool & ERD. To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009e7cbe05bf4b7942" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000009e7cbe05bf4b7942 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Apr 6, 2021 at 11:32 AM Rahul Shirsat < rahul.shirsat@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which resolves the issue of help dialogue > for Query tool & ERD tool on nwjs app. > > Also in the flow, verified Schema diff & Debugger where no issues found as > these can be opened in the new tab. > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000009e7cbe05bf4b7942 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Apr 6, 2021 at 11:32 AM Rahu= l Shirsat <rahul.shirs= at@enterprisedb.com> wrote:
Hi Hackers,

Please f= ind the attached patch which resolves=C2=A0the issue of help dialogue for Q= uery tool & ERD tool on nwjs app.

Also in the = flow, verified Schema diff & Debugger where no issues found as these ca= n be opened in the new tab.

--
Rahul Shirsat
Senior Software Engi= neer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000009e7cbe05bf4b7942--