Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gltue-0000bs-7a for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:08:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gltuc-0001Ow-Uw for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:08:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gltuc-0001J4-LW for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 11:08:10 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gltuV-0002t1-6n for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 11:08:09 +0000 Received: by mail-qk1-x730.google.com with SMTP id o8so13949240qkk.11 for ; Tue, 22 Jan 2019 03:08:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fjHuPzggv82uDV78Y7c4fwQuTqPvqmpTrn7gnxhtniM=; b=ofzBJI8DuqSuuLNHdaY7c/AxKHl/YrEM+fy+MaJVa3I3WcM2wMoP7zjwsLZNkNd/UO xLhW55uOZV7JMExCvcWnVTfTXYfWa0YfEL16dd2Rat+sLTOQVELsiDfwHd6KiQmixLOs 2eGI5S/r6op396Pkvx0oB43pTlBMP45ROFv3+0aTEfVSh81dWIKXwj0AAM6CoZG3wQoh YnbMDg0KBa0viL6IAhZdBk/ERre9ybM8vQxsAeu7cb4TzQEsTVFgQnQXaHSqXTITJIjk pS0XU4N2HMwbFLBvjcNllaWBiYnS2Nlxkf6z+PhUax0eXRnr5Pqh07KYNw6dFLC3cfya nVqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fjHuPzggv82uDV78Y7c4fwQuTqPvqmpTrn7gnxhtniM=; b=UlNJhNaD0daVtz1Hr9YtJfb/dFEyOOU/a12Vwd+Yw4hTC7MHQRGFq/p92pgqfeavfP 3hMQHfXVoNPcWxtvPYhHFAMepY4ltkvS0cwvPQ0Dpu45EDb6pOgfNgJczmODbBHFNr5Y 7VbqA5wkXnNXozeSKPvvRIhm2wJsT/HfeJm62KDUJ/eKAXLR/h2Nz6916ZGDh8OKtZea 1q2fS7Goo9F3iQDA3s22G4lEShKVZE2Ln1UfcYO78mS6um80CFqVyMEZ+Oh+Q6gB5nHH YN0vByzbm3OoaEJ7onpBeW73bLGRNtkzrppDeIDGQxy3w0e0Z4fPgq6A7E0UinMasGKG y6Bg== X-Gm-Message-State: AJcUukfXur/Oc0Ug056eaMPNnFy8Fx5giSKzlSph0NT7QZnuwp7KdKjA vzEeRVlEcITv/y2lwoAIBttTgaIBJ1NE5XnsYjyCaQ== X-Google-Smtp-Source: ALg8bN7v71TK93ge2hLfNooh48+ZC+NGNHxb3OwET8rKrsWtJyxCdq/Jif458mgGPCgVu+kxrreOpB0Rqyh4yKkQELM= X-Received: by 2002:a37:8541:: with SMTP id h62mr27652267qkd.213.1548155282310; Tue, 22 Jan 2019 03:08:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 22 Jan 2019 16:37:51 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell To: Harshal Dhumal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a8eaa5058009fd42" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a8eaa5058009fd42 Content-Type: text/plain; charset="UTF-8" Thanks patch applied On Tue, Jan 22, 2019 at 3:02 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Harshal, > > The Selec2Cell and PrivilegeCell are working properly but I think we > should also consider below: > > 1. The Backgrid and sub-node should have accessibility including every > button, cell and control. > 2. The Backgrid table header is accessible through keyboard but it should > be highlighted when it gets focus. > > @Akshay, we can commit this patch but we should create the separate RM for > above fixes. > RM # 3919 has been created by Harshal. > > Thanks, > Khushboo > > > On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Can you please review it. >> >> On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> Please find attached patch to fix backgrid navigation using keyboard >>> for Select2Cell and PrivilegeCell >>> >>> -- >>> *Harshal Dhumal* >>> *Sr. Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000a8eaa5058009fd42 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied=C2=A0

On Tue, Jan 22, 2019 at 3:02 PM Khushboo Vashi <khushboo.vashi@enterpri= sedb.com> wrote:
Hi Harshal,

The Selec2Cel= l and PrivilegeCell are working properly but I think we should also conside= r below:

1. The Backgrid and sub-node should have access= ibility including every button, cell and control.
2. The Backgrid= table header is accessible through keyboard but it should be highlighted w= hen it gets focus.

@Akshay, we can commit this pat= ch but we should create the separate RM for above fixes.

=C2=A0 =C2=A0 =C2=A0RM # 3919 has been created by= Harshal.

Thanks,
Khushboo

=

On Mon, Jan 2= 1, 2019 at 4:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
H= i Khushboo=C2=A0

Can you please review it.
On Th= u, Jan 17, 2019 at 7:22 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com= > wrote:
Hi,
Please find attached patch to fix backgrid navigation = using keyboard
for Select2Cell and PrivilegeCell

--=C2=A0
Harshal Dhumal
S= r. Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>


--
<= font color=3D"#3333FF">Akshay Joshi
Sr= . Software Architect

<= /span>

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Aks= hay Joshi
Sr. Software Architect

<= /div>
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">
Phone: +91 20-3058-9517
Mobile: +9= 1 976-788-8246
--000000000000a8eaa5058009fd42--