Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiEii-0007tq-GQ for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 09:05:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiEih-0001lo-4g for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 09:04:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiEig-0001lh-LC for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jul 2019 09:04:58 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiEid-0008F6-T7 for pgadmin-hackers@postgresql.org; Tue, 02 Jul 2019 09:04:57 +0000 Received: by mail-qk1-x734.google.com with SMTP id r6so13358732qkc.0 for ; Tue, 02 Jul 2019 02:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LPswh4/RoYAEDAxMhEJ4LPpr2vZVUhKLHV/bbc45anc=; b=to1RtGvzEeT8bC1cPEwbiZ2C1Go3g/Pz6AsDC9EPgoY5fxJuP57VPMYxM4H4ZvlpTb kBrJs41TG5d2muCAndIJVbIaVwzwa7AOFAmjRC+S9NqUPsUv5J+h+xRQVPAWEknhylv2 3V40ay0WChBjIlPnsIKfKVeSOsglm9CxX1790j+zkfH/dB5DD3UjlRP+AYW52JHc5S7U F8/cl08sTu+0n1v3r+mOmOjgJI4UsV9oOZGsukg5AoBwZOfwzWgAeS+A8mMN3b8jnMOy 0yXT08AONzs7KgKsyij68zma9JL6eltYf3aWFI/kjmxSkAsTxYv01oSidFUUkjCAHKA7 1OMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LPswh4/RoYAEDAxMhEJ4LPpr2vZVUhKLHV/bbc45anc=; b=ggFemBagOjd+96fTbOzhomIwdafc0UXsYZ1i4nNMZ0dFVz5oDp0aQDlKENJ6cHI6fN czUtAPZrWnK3TusPeascqEwR6NsunOxlxEwJhfQxGCwmrOoplr02lntjUyMEVFihXX+U UBECRzfz/3f01caroP+LJSVFZN+V+py3d2SABauFmjOovisQ9MS4Nu26LkWd5kpoomew zkFTQS2QWBDQps3HXKCcTBdtR4HghRB6qJmOUpN1cEDM2WI3yZslbEZ4i3cn9Cws3GKD 8gmyV2lrTNxtSqMSLA5dv/VsKBA+H3Gqx3VMAHtqjjVzVbWUOTeiQo3GF715gDU3tMZk gwMw== X-Gm-Message-State: APjAAAUMVOkKEfuKkQay/tpGaMAV2hh0ilBE4zQAVToKtzNgfdLxii8m J1hcxGYgjepbof8kzXjcQgZNW8Esdrrwxt7t/UK82Inp X-Google-Smtp-Source: APXvYqxpt3106SDgPB8UUOr2JdQqOSsutcJnfvce3fKgOBMUM03jJRQmsNVGT17OAFsHDjGsx/5F177rzLtKxdYlUH8= X-Received: by 2002:a05:620a:12db:: with SMTP id e27mr24771403qkl.352.1562058294847; Tue, 02 Jul 2019 02:04:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 2 Jul 2019 14:34:42 +0530 Message-ID: Subject: Re: [pgAdmin][RM4421] Inno setup script version compare fix To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c885e3058caf0922" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c885e3058caf0922 Content-Type: text/plain; charset="UTF-8" Hi Aditya I have asked Paresh to review the patch, he has given some review comments. Please fix those and the updated patch asap. On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix a potential issue where version compare while > upgrading will be incorrect. Currently, it is comparing strings. So while > comparing '4.9' and '4.10' it will consider '4.9' as greater. > The patch will convert the values to float and compare. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000c885e3058caf0922 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya=C2=A0

I have asked Paresh to = review the patch, he has given some review comments. Please fix those and t= he updated patch asap.=C2=A0=C2=A0

On Tue, Jul 2, 2019 at 1:38 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the pa= tch to fix a potential issue where version compare while upgrading will be = incorrect. Currently, it is comparing strings. So while comparing '4.9&= #39; and '4.10' it will consider '4.9' as greater.
The patc= h will convert the values to float and compare.

Kindly review.

--
<= font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Thanks and R= egards,
Aditya Toshniwal<= /font>
Softwa= re Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Pl= ant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000c885e3058caf0922--