Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hrzlN-0002XQ-9X for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 07:08:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hrzlM-0002gs-3X for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 07:08:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hrzlL-0002fc-OV for pgadmin-hackers@lists.postgresql.org; Mon, 29 Jul 2019 07:08:03 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hrzlJ-0003WF-16 for pgadmin-hackers@postgresql.org; Mon, 29 Jul 2019 07:08:03 +0000 Received: by mail-qt1-x844.google.com with SMTP id y26so58662837qto.4 for ; Mon, 29 Jul 2019 00:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7cFhQg103NRukOHp8BBsn6wztr8jZPbLGN6n/EX4Zbk=; b=MgYuGeKiUFj9LyYq5YsASFqAhwfMb2IQgDEOWKl7sEJPB9jLYmtGfLaKPxM63KUNqJ TlAUaJDA1CRmJqBFJEfMId+D+2TvX94EFUDZ/Oko/T8N5+pZDy0ssjOIS8UmRh82Bpsv dCHyBkn4y8Yyq3cbf4DWW5aipWNjwnVdCsiyW0hW7m54LnnHb0NkW9xcs37RTEvz4MWR ztsmF0KGN33Qhu1lC0D2RZXCFM09n3RRIFZB2gUnVwDPMUrX1/k8VLVK8fmF1svopoqg jFvrhiGu/QJw5LUsDkAnZjXLEBKaYLtNeIdtga+nKpmsB6BvYu9BG/cNTe2oR7sT1kUh eMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7cFhQg103NRukOHp8BBsn6wztr8jZPbLGN6n/EX4Zbk=; b=i2D3tFb5fxHaFzJmbFyP0FoLSUrga5bhEHqmD34yoSinPR+yKgdQAM/5zUpVqnzXE7 6X0195Q5jVQJ3tgBi71zFRdwfG7TavCko+NxmaBMjMJ/spzRGAV+eFRrwU3QfXZRWweo HDmF+MXbs6wcck1Q91jW0uETBFeDNCIWCMcxPanSYZHDruZ3w9U5rOuV1q6DcjRpyDvq Iy0qXUjXLfZSY66X74RyCs8hH35/m06ZPeeqdAx+xCFDrNeIr4l6kI1mJ+XJfFXDNzt8 3mtGDIQcGXA4dpipnZ+5CNxzr0foDTTvc0UmTYKOuHyLKF6434J+f8ebcAO+PFJccG3u z85w== X-Gm-Message-State: APjAAAXLSzfmIALxi6EiLYVqUj/oQsg4mFyKx9J587QtlfgauJB6L0Iq K8NMvwFw1shCvUV+FEViOFIx4zSYMNJ/khVIBa40AQ== X-Google-Smtp-Source: APXvYqzbRovY0leqSOdTKfgur9e7iMruzpJmi6x+aD1W61KfLjpgBEddV2QiAgRHFMsxJ5xP/0fY+VFCWbQubNPPx9A= X-Received: by 2002:a0c:e908:: with SMTP id a8mr29312580qvo.214.1564384078047; Mon, 29 Jul 2019 00:07:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 29 Jul 2019 12:37:47 +0530 Message-ID: Subject: Re: [GSoC] Support editing resultsets from tables with OIDs To: Dave Page Cc: Yosry Muhammad , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000043bf83058ecc8db3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000043bf83058ecc8db3 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Mon, Jul 29, 2019 at 11:12 AM Akshay Joshi wrote: > > On Fri, Jul 26, 2019 at 5:33 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> > > Sure, I am looking it. > >> >> On the subject of the regression test - I assume at one point the >> messages window was including the command tags in it's output. This failure >> would indicate we broken that. Anyone got any ideas how that happened? >> >> On Thu, Jul 25, 2019 at 1:01 PM Yosry Muhammad >> wrote: >> >>> Hi, >>> Please find a patch attached to add supporting of resultsets from tables >>> with OIDs as updatable resultsets (with updated test cases and docs) - this >>> is a part of a GSoC project. Please review ! >>> This patch also includes a small refactor of the previous patch and a >>> small bug fix that occurred when the query resultset had no rows but was >>> updatable (row additions were not permitted, although they should be). >>> >>> >>> On a different note, one of the feature tests fails (on master), >>> probably due to a small typo. In query_tool_tests.py this function call: >>> >>> self.page.find_by_xpath( >>> '//div[contains(@class, "sql-editor-message") and ' >>> 'contains(string(), "CREATE TABLE")]' >>> ) >>> >>> on lines 371-374 produces an exception that the element cannot be found, >>> this is probably due to the fact that the message returned by the query >>> executed before this call does not contain the string "CREATE TABLE". Just >>> letting you know about this. >>> >>> Thanks and regards! >>> -- >>> >>> *Yosry Muhammad Yosry* >>> >>> Computer Engineering student, >>> The Faculty of Engineering, >>> Cairo University (2021). >>> Class representative of CMP 2021. >>> https://www.linkedin.com/in/yosrym93/ >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000043bf83058ecc8db3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Mon, Jul 29, 2019 at 11:12 AM Aksh= ay Joshi <akshay.joshi@= enterprisedb.com> wrote:

On Fri, Jul 26, 2019 at 5= :33 PM Dave Page <dpage@pgadmin.org> wrote:
Akshay; can you take a look at this and = commit if appropriate please? I'm somewhat busy at the moment :-(
=

=C2=A0 =C2=A0Sure, I am looking it.=C2=A0<= /div>

On the subject of the regression test - I assume at one po= int the messages window was including the command tags in it's output. = This failure would indicate we broken that. Anyone got any ideas how that h= appened?

On Thu, Jul 25, 2019 at 1:01 PM Yosry Muhammad <yosrym93@gmail.com>= wrote:
Hi,
Please find a patch attached to add supporting = of resultsets from tables with OIDs as updatable resultsets (with updated t= est cases and docs) - this is a part of a GSoC project. Please review !
This patch also includes a small refactor of the previous patch and = a small bug fix that occurred when the query resultset had no rows but was = updatable (row additions were not permitted, although they should be).
<= /div>


On a different note, one of the fea= ture tests fails (on master), probably due to a small typo. In query_tool_t= ests.py this function call:
self.page.find_by_=
xpath(
    '//=
div[contains(@class, "sql-editor-message") and '
    'contains(strin=
g(), "CREATE TABLE")]'
)
on lines 3= 71-374 produces an exception that the element cannot be found, this is prob= ably due to the fact that the message returned by the query executed before= this call does not contain the string "CREATE TABLE". Just letti= ng you know about this.

Thanks and regards!
--=C2=A0

Yos= ry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterp= riseDB UK: http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company


--
<= div>Thanks & Rega= rds
Akshay Joshi
Sr. Software Architect
=
EnterpriseDB Software India Private Limited<= /b>
Mobile: +91 976-788-8246
=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000043bf83058ecc8db3--