Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDpGi-0003fm-HC for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Sep 2020 13:27:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kDpGh-0007Br-F0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Sep 2020 13:27:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDpGh-0007Bk-9S for pgadmin-hackers@lists.postgresql.org; Thu, 03 Sep 2020 13:27:11 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kDpGa-00079h-Ge for pgadmin-hackers@postgresql.org; Thu, 03 Sep 2020 13:27:10 +0000 Received: by mail-io1-xd2f.google.com with SMTP id u126so2602051iod.12 for ; Thu, 03 Sep 2020 06:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7Lot8jEtJU/7R0F3HkyZhaKdqtkI6jkI3n666qTy/WM=; b=I3TTxoUOaIVWa6SfOKXtCcS5j+e6jdxAN8PmGpGGges51+yPgBgUflGE/flFapG0yr HrRdy+7qGWWRRiqsXawKr/20TG1L5TbJwpyGV6Iq3gRQQQZuNcLwZl3LS60noF8XHpF0 PxcY1jYCtJVGxoSqVD2485rPBYygBMr8O4GVK62tchztVsKB/1y/JWFErwLXrEo3dWiD 7Y0BYyk9kqliDZG6RWs+qe3MrVbjDnwRl8FjTpwIwatWtthWO+yF2ea+f1U3lXnczOjQ AHybO8HUDTtZCdJTRl+7ET7drGZUEilBTAvGb1xDS7EuKP/AiIlAZgZOq6kO10TU5nud ZlUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Lot8jEtJU/7R0F3HkyZhaKdqtkI6jkI3n666qTy/WM=; b=W7G39NSYJrlvdOEK0eZ6zN6vuhXQJjb1RQoctqt2YEUMu/Q+/UpumhiR4Ok6/lPapZ WJdum6861irpdNewjfyDvAaz/CU+0jmb6pah6lXkoXHqSNJIqacRIQD4jmb4woDvUHco IFSL+cOVboIe+W8WwmNekdtXF8jOrkAy/Vil4P67/E0DjrufVO1CTg6jUzt2uOKceJz5 Yv/zKgxhTtgPtAyHPoN9HGE+nAKAwQoYWJ1kch3gI5ybnDdXr2V0SgE3wXmeIrBp7LPV HVE5o/6iJAehaboBouRMGbPQgOe/BZTx/3Bqm/B4rOxbAeU3tSy4HLioxRNU8aQtDV9R 4ZBw== X-Gm-Message-State: AOAM530vNp4UbC6vldsmxP22iGvk6yqZdrTpDLIb4yDFY5bSMdsHG4EJ GugZp9LH5rLxYFmSMOH/NG/YulO/5dDOcQEuB53g6rsbA9wlrLLlJrBpFKYiVc4w6SLXR3cY+de 2q21Jed32c5rA0yhT4xiwMGy4nDue3PmlS/8DVNOOTVBPfkrdfquNENThKy9cx/dSAMgK2366fY e+EKo1zGhinF8xN0O2MXPSqRWCYLPo/rqatk/QDntU7vIspcI+2rZ9uQr8Jw== X-Google-Smtp-Source: ABdhPJwnJ8vjvM1AZ/tM3qCnvQNgf2I527mahR6+HFe8gqnFzMXqR8uLnhcSWbwHhMh6OF/MmFSrIrffg01qi4T/WZA= X-Received: by 2002:a6b:194:: with SMTP id 142mr3063691iob.18.1599139622454; Thu, 03 Sep 2020 06:27:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 3 Sep 2020 18:56:51 +0530 Message-ID: Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000024a0a105ae68b5ec" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000024a0a105ae68b5ec Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Sep 3, 2020 at 3:38 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to reduce cognitive complexity as below: > web/pgadmin/misc/file_manager/__init__.py 20 to 15 > web/pgadmin/tools/grant_wizard/__init__.py 55 to 15 > web/pgadmin/tools/sqleditor/__init__.py 33 to 15 > > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000024a0a105ae68b5ec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Sep 3, 2020 at 3:38 PM A= ditya Toshniwal <ad= itya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to reduce cognitive complex= ity as below:
web/pgadmin/misc/file_manager/__init__.py 20 to 15
web/= pgadmin/tools/grant_wizard/__init__.py 55 to 15
web/pgadmin/tools/sqledi= tor/__init__.py 33 to 15

Please review.

--
=
Thanks,
<= span style=3D"color:rgb(18,22,70)">Aditya = Toshniwal
pgAdmin hacker=C2=A0| Sr. Software Enginee= r | edbpostgres.com=
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= div>pgAdmin Hacker | = Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

<= /div>
--00000000000024a0a105ae68b5ec--