Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVXfK-00016Y-95 for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Nov 2019 09:13:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iVXXI-0003WA-SG for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Nov 2019 09:05:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVXXI-0003TJ-Kp for pgadmin-hackers@lists.postgresql.org; Fri, 15 Nov 2019 09:05:00 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVXXF-0006iK-3H for pgadmin-hackers@postgresql.org; Fri, 15 Nov 2019 09:04:59 +0000 Received: by mail-io1-xd2b.google.com with SMTP id v17so9611644iol.12 for ; Fri, 15 Nov 2019 01:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9EO4rgsz0py23MeiQy+3CYE7SpWSJax7kpt6vpNSnXk=; b=SEsTA7Aw7weRCQTODcCiELUHIeVpzFqzKnlsUTyS3W0HtLoVqsJrRv44lW4WZGhYRN eA48u2KM8vViwlguGw2+uAp4hRMpArsz4TTnf40g7JIjZTLOIZAb4RVI74g2TcLY67Qn BgTDXGEMUIlASMqtc+qYjz3xssBo12N68alFPmwifAngQCASE/sN9r62aNNeNzg+qsSW HoAjkgFBybIiuBSW0USiq9famB9s8qPJ8doalTO+/ZkjsizCaGx+SFppOuhrPytuGJbV UBQ2vCwd0lpFWZdd9kbgJEoW5/7kIh2dV6QcrFda/7M07wSAOphJVHUM2CkwG0aN1Ag2 Kd8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9EO4rgsz0py23MeiQy+3CYE7SpWSJax7kpt6vpNSnXk=; b=Ior1xZF9vDs13ITON630fK+DrolDcH6o7+BkX7z2E4QeZu5Lm4bJUJjlgC/oVUjY9N +4U3WFopSgc3uU6oZjKukSigc1NeRuqs7c1TAavjuof7/0uM7QsXU2tjk/Q+IHF+gxOt NNrkDLLrg6+NUsghfuoMO4kDf2phToKTKTUunClfEByDwQgSTdP5v8x23VYc5rCUTnuS pXmQmMv2dar7OJp0AfpNCoQ5tZTZN24K+9pHMOSe8h3inkFFGWQYchJ8NNBcGjuo4/nW asSQJaLUoeFXSUHr3ssTWvEo/+wYBWxEt2k1Bimw1ABXJu/cyBomeA3yYdcfxkqcwLx3 g/4Q== X-Gm-Message-State: APjAAAXFCMU7DPQs+TG/RP0/FeBhH3N+vDL5cyzYyxpF/52+K/P+AGiy +47AzcvmWRXrY0dH2SnADoYDkTFLis1hVpLx8Zcwztu+Xn3/PAnlNEV5UEPtu/IVlDxM4lwIu2N RCv7HtIWiSSLCBn8g1sVVp/PnQ215i6vjkLpza4inupSIE40HQXlZAguYw130i3+RSNDUz2h6xz d5MS1YuP140Dsv4dupYrtquZLefIEpQlUMcmVUwBj9W+96NoL/jZs= X-Google-Smtp-Source: APXvYqx7Jb8nbcH8pmTrNeGG4A5cFZpTgsD2pSCrT2911DWITP1qpYANSrr/NOXmBnt53ALg6fuaUBtA6s084sHZxhE= X-Received: by 2002:a5d:8896:: with SMTP id d22mr6143336ioo.121.1573808694753; Fri, 15 Nov 2019 01:04:54 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 15 Nov 2019 14:34:43 +0530 Message-ID: Subject: Re: [pgAdmin][RM4818] Unable to handle loss of connection to server To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000003214f205975ee404" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003214f205975ee404 Content-Type: text/plain; charset="UTF-8" Hi Aditya Following are the review comments: 1. The default connection timeout should be *10* seconds. 2. In case the network is disabled and when we expand the "Servers" node the database server(for which network is disabled) should be shown in the disconnected state. 3. For the above case when you try to connect to the server and at the same time trying to fetch the properties of the valid database server, it takes long time to fetch it. 4. Case when the network is disabled, the database servers password is saved and pgAdmin4 tries to connect the server, after connection timeout, there is no message to the user, only spinner gets disappeared. We should show a message. 5. We should improve the error messages "timeout expired" and "Connection to the servers has been lost." to the more meaningful messages like "Check the network settings, check the firewall status." 6. Install database server on Windows and Enable Windows Firewall. Try to connect to the same database server. Spinner is not showing, as a user I am not able to understand is there any action started at the backend or not. As a user, I'll keep trying to connect multiple times and after the connection timeout of each request dialog pops up. On Thu, Nov 14, 2019 at 12:15 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the workaround patch to set the default connection timeout to > 30 seconds instead of the current value of infinite - 0, zero. The input is > present in the server properties dialogs advanced tab. The workaround > applies to the RM4724 as well. > The permanent solution would be to expand the nodes asynchronously - > https://redmine.postgresql.org/issues/4933 > > Also fixed a bug where sql editor is not closing if the server is > disconnected in between. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000003214f205975ee404 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

Following are the review= comments:
  1. The default connection timeout should be 10 s= econds.
  2. In case the network is disabled and when we expand the &quo= t;Servers" node the database server(for which network is disabled) sho= uld be shown in the disconnected state.
  3. =C2=A0For the above case wh= en you try to connect to the server and at the same time trying to fetch th= e properties of the valid database server, it takes long time to fetch it.<= /li>
  4. =C2=A0Case when the network is disabled, the database servers passw= ord is saved and pgAdmin4 tries to connect the server, after connection tim= eout, there is no message to the user, only spinner gets disappeared. We sh= ould show a message.
  5. We should improve the error messages "tim= eout expired" and "Connection to the servers has been lost."= to the more meaningful messages like "Check the network settings, che= ck the firewall=C2=A0status."
  6. Install database server on Windo= ws and Enable Windows Firewall. Try to connect to the same database server.= Spinner is not showing, as a user I am not able to understand is there any= action started at the backend or not. As a user, I'll keep trying to c= onnect multiple times and after the connection timeout of each request dial= og pops up.

On Thu, Nov 14, 2019 at 12:15 PM Aditya To= shniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the workar= ound patch to set the default connection timeout to 30 seconds instead of t= he current value of infinite - 0, zero. The input is present in the server = properties dialogs advanced tab. The workaround applies to the RM4724 as we= ll.
The permanent solution would be to expand the nodes asynchronously -=C2= =A0https://redmine.postgresq= l.org/issues/4933

Also fixed a bug where sql editor is not closing= if the server is disconnected in between.

Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0Enterprise= DB India |=C2=A0Pune<= /font>
"Don't Complain about Heat, Plant a TREE"
=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000003214f205975ee404--