Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i57hD-0004rs-RY for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 12:14:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i57hC-0000XH-Q6 for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 12:14:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i57hC-0000UB-Gr for pgadmin-hackers@lists.postgresql.org; Tue, 03 Sep 2019 12:14:02 +0000 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i57h9-0004mk-J8 for pgadmin-hackers@postgresql.org; Tue, 03 Sep 2019 12:14:02 +0000 Received: by mail-qt1-x82f.google.com with SMTP id a13so19578911qtj.1 for ; Tue, 03 Sep 2019 05:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A71DnkvX1va6GfZRl2zdf2SM+ZDCRIq+UdJlqVmNc3U=; b=ygy7eLeG0oxTqiw0Wbs3orRYBXp9vdjtmiuV4xMfSAKaUIaqVjjTE50fCxtgiZYH3l 9L64og/y0epdrbaUM1cmwyVy5R1YD0V6fW8rybFnlH239qri/VTY0/gEvFbymWMqRfNB Uik+F+b6ZgISTTsHkpywMliuBRhDJaHR7IabpomWSGFimyJVqj9jwli4divNLwekY3Jb zSeq+dM7fTQfQICx52e5gMtfcq3ctvjQEvPcudlyg6P4JVVKhhxZXr6vybPyTsJThER8 ChgeAStZ0qZrAY/rlLD3281gI2Ud4mOmSKx3GDGt9oUunyRKGnnl4EYjFd8nzyiTO4pY EXwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A71DnkvX1va6GfZRl2zdf2SM+ZDCRIq+UdJlqVmNc3U=; b=J23UPnEPBPAJx3jnC41ONqCWXKlk9tIdqyvEfa7LTCqd99hd9Fw8x+7PQrnILRYVxN Cgn61nKpPmY+hUyARKN9n3xWCm9lXeHZigiT3UuPAIc6PL5GH+4PSSylpMfEXoVsfXjK /tQBvBoTxAQIisTgQOT3lVryrNEVUiGYzWDWOzpbA/oBvwovEyrzcl3xfE4NmxU++pIZ MQNT3hgoA17GiZbWxU8c6g6fFbsugciSUOAzzPdZZni+gDDaSq0uMPeem5Ps49dr8Tme FqOBXpgQyb3sLViNvDnm+sQkwiKq+ZCVmuzzVOA3nLwxQ8Z+j3kumHMx/uW40qUEGq6r pldQ== X-Gm-Message-State: APjAAAX6pG7dJQJ+5O7Eyz63QZqBiid/6eEGJoRpsR81eK6ynCYORTIQ ZtZe1daEY/P8BVD91PWRJlLpPrFKftjvGWEhGeDF1g== X-Google-Smtp-Source: APXvYqyW57MLcZ16Y1b/QZ+Hh5aqqvblkfTpfG/NbMQuju1sVRoRZlfXMbuxn+hwc5eocSMpCBSLYNKGEW042e+aGGc= X-Received: by 2002:ac8:e8d:: with SMTP id v13mr8840597qti.96.1567512337486; Tue, 03 Sep 2019 05:05:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 3 Sep 2019 17:35:26 +0530 Message-ID: Subject: Re: RE-SQL tests patch for packages node To: navnath gadakh Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000000eaf1b0591a4e84c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000eaf1b0591a4e84c Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Tue, Sep 3, 2019 at 5:17 PM navnath gadakh < navnath.gadakh@enterprisedb.com> wrote: > Please check now. > > On Tue, Sep 3, 2019 at 5:07 PM Akshay Joshi > wrote: > >> Hi Navnath >> >> You forgot to add "create_package_with_all_options_msql.sql" and >> "alter_package_headers_and_comment_msql.sql" file in your patch. Please >> send the updated patch. >> >> On Tue, Sep 3, 2019 at 1:36 PM navnath gadakh < >> navnath.gadakh@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the modified patch. >>> >>> On Mon, Sep 2, 2019 at 5:43 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Navnath >>>> >>>> Following are the review comments: >>>> >>>> - GRANT statement is not visible in RE-SQL for create and alter >>>> both. (May be bug in Packages please fix that too) >>>> >>>> Done. >>> >>>> >>>> - Delete packages is missing in json file. >>>> >>>> Done. >>> >>>> >>>> - Add test cases to revoke privileges(delete all the privileges). >>>> Check Languages node for reference. >>>> >>>> Done. >>> >>>> >>>> On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh < >>>> navnath.gadakh@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> Please find the patch for M-SQL test cases for *Packages* >>>>> module. >>>>> >>>>> Thanks! >>>>> >>>>> On Fri, Jul 12, 2019 at 4:02 PM Dave Page >>>>> wrote: >>>>> >>>>>> Thanks, applied. >>>>>> >>>>>> On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < >>>>>> navnath.gadakh@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> Please find the modified patch for packages as test cases were >>>>>>> failing on some servers. >>>>>>> Thanks! >>>>>>> >>>>>>> >>>>>>> On Thu, Jul 11, 2019 at 1:53 PM Dave Page < >>>>>>> dave.page@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Thanks, applied. >>>>>>>> >>>>>>>> On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Navnath >>>>>>>>> >>>>>>>>> I have tested the patch and it is not working for EPAS 9.4, 9.5 >>>>>>>>> and 9.6. Attached is the modified patch which fix the issue. >>>>>>>>> Please work on child node (functions, procedure and variables) of >>>>>>>>> Packages on top of modified patch. >>>>>>>>> >>>>>>>>> On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh < >>>>>>>>> navnath.gadakh@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Dave, >>>>>>>>>> >>>>>>>>>> I have attached the patch for RE-SQL test cases for >>>>>>>>>> *Packages* node. >>>>>>>>>> >>>>>>>>>> Thanks! >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Regards,* >>>>>>>>>> *Navnath Gadakh* >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Thanks & Regards* >>>>>>>>> *Akshay Joshi* >>>>>>>>> >>>>>>>>> *Sr. Software Architect* >>>>>>>>> *EnterpriseDB Software India Private Limited* >>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Regards,* >>>>>>> *Navnath Gadakh* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> VP, Chief Architect, Tools & Installers >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Regards,* >>>>> *Navnath Gadakh* >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> *Regards,* >>> *Navnath Gadakh* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Regards,* > *Navnath Gadakh* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000000eaf1b0591a4e84c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Tue, Sep 3, 2019 at 5:17 PM navnat= h gadakh <navnath.gad= akh@enterprisedb.com> wrote:
Please check now.=C2=A0

On Tue, Sep 3, 2019 at 5:07 PM Akshay Joshi <akshay.joshi@enterprisedb.co= m> wrote:
Hi=C2=A0Navnath

You forgot to add &quo= t;create_package_with_all_options_msql.sql" and "alter_package_he= aders_and_comment_msql.sql" file in your patch. Please send the update= d patch.

On Tue, Sep 3, 2019 at 1:36 PM navnath gadakh <navnath.gadak= h@enterprisedb.com> wrote:
Hi,

Please find the modified patch.
=
On Mon= , Sep 2, 2019 at 5:43 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wro= te:
Hi=C2=A0Navnath

Following are the review comments:<= /div>
  • GRANT statement is not visible in RE-SQL for create and a= lter both. (May be bug in Packages please fix that too)
Done.=C2=A0
  • Delete packa= ges is missing in json file.
Done.=C2=A0
  • Add test cases to revoke privileges(dele= te all the privileges). Check Languages node for reference.
=
Done.=C2=A0

On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh= <n= avnath.gadakh@enterprisedb.com> wrote:
Hi Dave,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Plea= se find the patch for=C2=A0M-SQL test cases for Packages module.

=
Thanks!

On Fri, Jul 12, 2019 at 4:02 PM Dave Page <dave.page@enterprisedb.com> wrot= e:
Thanks, applied.

On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh <navnath.g= adakh@enterprisedb.com> wrote:
Hi Dave,

=C2=A0 =C2=A0 =C2=A0Please find the modified pat= ch for packages as test cases were failing on some servers.=C2=A0
Thanks!


On Th= u, Jul 11, 2019 at 1:53 PM Dave Page <dave.page@enterprisedb.com> wrote:
=
Th= anks, applied.

On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi <akshay.joshi@enter= prisedb.com> wrote:
Hi=C2=A0Navnath

I have teste= d the patch and it is not working for EPAS 9.4, 9.5 and 9.6. Attached is th= e modified patch which fix the issue.=C2=A0
Please work on child = node (functions, procedure and variables) of Packages on top of modified pa= tch.=C2=A0=C2=A0

On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh <navnath.= gadakh@enterprisedb.com> wrote:
Hi Dave,

=C2=A0 =C2=A0 I have attached the patch for RE-= SQL test cases for Packages node.
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
Thanks!
<= div>
--
Regards= ,
Navnath Ga= dakh


--
= Thanks & Regards<= /span>
Akshay Joshi
= Sr. Software Architect
EnterpriseDB Software India Private Limited<= /font>
Mobile: +91 976-788-8246


--
Dave Page
VP, Chief Architect, Tools & Install= ers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake


--
Regards,
Navnath Gadakh
<= /div>


--
Dave Page
VP, Chief Architect= , Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise = PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
<= div>Regards,
= Navnath Gadakh


--
Thanks = & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Priv= ate Limited
Mobile: +91 976-788-8246
=


--
Regards,
Navnath Gadakh
=


--
Thanks & Regards
Akshay Joshi
=
Sr. Software Arc= hitect
EnterpriseDB Sof= tware India Private Limited
Mobile: +91 976-788-8246


--
Regards,
<= b>Navnath Gadakh


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000000eaf1b0591a4e84c--