public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Regarding non-ascii characters in the path for Windows installer
Date: Thu, 16 Jan 2025 16:52:42 +0530
Message-ID: <CANxoLDdq6E8uMHMqcMw_Qz4EFV_Fx4m_4fvwkmnU=YkFxEdqDg@mail.gmail.com> (raw)

Hi Dave/Hackers

I am looking into issue 5204
<https://github.com/pgadmin-org/pgadmin4/issues/5204; where the pgAdmin 4
Windows installer throws an error of "Please provide a valid path," when
the user name contains non-ASCII characters.

We have added a function IsPathValid to validate the path in the "
installer.iss.in" file, because of this function Windows installer throws
an error.

[image: Code.png]
Can we remove this logic? Thoughts/Suggestions?



Akshay Joshi

Principle Software Architect

enterprisedb.com

*  Blog*: https://www.enterprisedb.com/akshay-joshi
*  GitHub*: https://github.com/akshay-joshi
*  LinkedIn*: https://www.linkedin.com/in/akshay-joshi-086497216


Attachments:

  [image/png] Code.png (121.9K, 3-Code.png)
  download | view image

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Regarding non-ascii characters in the path for Windows installer
  In-Reply-To: <CANxoLDdq6E8uMHMqcMw_Qz4EFV_Fx4m_4fvwkmnU=YkFxEdqDg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox