Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jHKx9-00072L-TK for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 Mar 2020 05:21:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jHKx8-0000Sd-Mb for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 Mar 2020 05:21:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jHKx8-0000ST-7f for pgadmin-hackers@lists.postgresql.org; Thu, 26 Mar 2020 05:21:14 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jHKx3-0006r5-1I for pgadmin-hackers@postgresql.org; Thu, 26 Mar 2020 05:21:13 +0000 Received: by mail-il1-x133.google.com with SMTP id j69so4194439ila.11 for ; Wed, 25 Mar 2020 22:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9QhF6LgIJ0jelD/niP1OXGfLlKH+mOQvt+LEUQ9J9OY=; b=gq8lvy+w33hcxpc2rtpOvg6c6i+8QynI8+6c+4yAgNoHBl7iiJP/fMsqI2z8CS3To5 0NMprrRRnHxOC/q/I93z6c7+OtHtix8QpCuuzELder1hr5Hm/l+6NohWvxph69dIPyNQ Sd0xPdaPnY2SrC/0ghUXMEbNs6zQk9LbQQWgQMfphHFmatzsrU4vrDuqsdtMX7JtdF99 VOFjiQXCtpKt9zuT/8H677SsSmuQM7V8mfKPcSldLLICQlihAvC0OA7Z4oPg7A5rmSYP T24uUusVBPEqYaLS26Wa795+TFYRVCBsDaF4Yc4u1gHfsom1i+NBBK3/Pmcv56lOmdCN l+mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9QhF6LgIJ0jelD/niP1OXGfLlKH+mOQvt+LEUQ9J9OY=; b=p0Vxm4g+kK40Om9EI4sp1f5D2GLQ2wqQLT98vMRPCFzahr9sGVB3XkSItxIuhZRdAh SOkVQMB6ogBpqZWFWxVUns1JrYZrpvM9/8cqQiq7RHhfp7mKJlyTqu8cVwOx0l+8R9ia x4xm13uUOn+ZxQDilcHBRpLUQDZP3cOurm9DO2NgLP7i1HLap9+dOqXaAQN3M59aPSsZ W/chS9p2PoAyM5ekq1bJBjHmQ6dW1D245e45U2FN4Xxnmmqx08+EvBmVHT0uQuCQ3F8g KpgWTVAVCttWgCQmlKYmAsYgOb00cCbm7tOTW6yeTiFIQhL4gQAIbQ7ETQyD08HYKPeW wOOQ== X-Gm-Message-State: ANhLgQ0wIBAQ+IOemhWgBCmR1aDrS9cpxKXEYkfcnkO0nWflDhza0DbY EDKLYualmQNF2h1tAlHQ6cBamvZ2LxuVirReEV7dD4bJ8aeS47p6Y9idvXMrlVJh572KrlkIMGb FZqiIecCI5KxWnesqcn1do7KtUbQEOxnN5c5luuyeuDWh5JdlJ1twTbCxiBzy7/ua5tDKJBFp8f vzVHsfMW/RKFR25CkWeriKES5eaGaj8DynGPrJOSFXdfgs1DUewPE= X-Google-Smtp-Source: ADFU+vvCVjgziUW67ycIDd2VFu5HaHnd7Q0riIUMz8ouG3dvS1NpCimZEPbnTN4i4K+Xs/zrFTF/rdUhxkyH84B8zC8= X-Received: by 2002:a92:8901:: with SMTP id n1mr7485469ild.176.1585200067972; Wed, 25 Mar 2020 22:21:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 26 Mar 2020 10:50:57 +0530 Message-ID: Subject: Re: Fix in switch cell tab navigation To: Ganesh Jaybhay Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f354f105a1bb2691" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f354f105a1bb2691 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Mar 26, 2020 at 10:30 AM Ganesh Jaybhay < ganesh.jaybhay@enterprisedb.com> wrote: > Hi Khushboo, > > I have removed the condition added for subgrid-cell. Please find the > attached updated patch > > Regards, > Ganesh Jaybhay > > On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Ganesh, >> >> You have put a check on *subgrid-cell* class, which does not exist in >> the entire source code. >> Also, can you please let me know of any module which you have tested, so >> I can test accordingly though the code for the same looks good to me. >> >> Thanks, >> Khushboo >> >> >> On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay < >> ganesh.jaybhay@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for below minor fix in the switch cell tab >>> navigation: >>> >>> After pressing the tab key on switch cell, sometimes focus doesn't go to >>> the immediate next editable cell. It goes to the different cell for >>> fraction of seconds and again comes to the next editable cell. >>> >>> Please review. >>> >>> Regards, >>> Ganesh Jaybhay >>> >> -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000f354f105a1bb2691 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Mar 26, 2020 at 10:30 AM Gan= esh Jaybhay <ganesh.j= aybhay@enterprisedb.com> wrote:
Hi Khushboo,

I have re= moved the condition added for subgrid-cell. Please find the attached update= d patch

Regards,
Ganesh Jaybhay

On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi <khushboo.vashi@enterprisedb= .com> wrote:
Hi Ganesh,

You have put a check on= =C2=A0subgrid-cell class, which does not exist in the entire source = code.
Also, can you please let me know of any module which you ha= ve tested, so I can test accordingly though the code for the same looks goo= d to me.

Thanks,
Khushboo

=

On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <ganesh.jaybhay@enterpris= edb.com> wrote:
Hi Hackers,

Att= ached is the patch for below minor fix in the switch cell tab navigation:

After pressing the tab key on switch cell, sometime= s focus doesn't go to the immediate next editable cell. It goes to the = different cell for fraction of seconds and again comes to the next editable= cell.

Please review.

Reg= ards,
Ganesh Jaybhay


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000f354f105a1bb2691--