Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDf6o-0000aT-65 for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Jun 2023 05:49:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qDf6m-0000th-UH for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Jun 2023 05:49:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDf6m-0000tY-LP for pgadmin-hackers@lists.postgresql.org; Mon, 26 Jun 2023 05:49:52 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qDf6j-000WUd-30 for pgadmin-hackers@postgresql.org; Mon, 26 Jun 2023 05:49:51 +0000 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b6a0d91e80so7340651fa.3 for ; Sun, 25 Jun 2023 22:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1687758588; x=1690350588; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=imnIzJToCqXnhypQRzS+0fkWNKzJxANrLlpx/7a835o=; b=cNaMwuqUeTAZWJzYgwkOeY1dyhsRW91/mmD3w2TLmQ9vxfCjoftb+51U/4hkGE/gxX t3Iux8HFbn9eJ09M5tLQYqe8Z9ogClBx6Fo+LI8ETAqsAfimvKZAYLSXPqvzPQi3xNgb jjRCUdGgN5Xa04+omNFdsWqESEa4HN63TCIpn2+lTl3Oje9guoo/rnGxB02K8uX3eFFJ 7VRq6lSnRc1HLAez3Lm0VfwVLb6AsFfzJATvAaTJdpYAQcd/U/mPcBJO+BTr8VsMjR8t kbnSF7HlOY/SITencLOn9Vpn3H8NenIMFaqqS7lfQiaj4NAPk7ZBWUmyo0mOd1dxXqiX 4VZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687758588; x=1690350588; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=imnIzJToCqXnhypQRzS+0fkWNKzJxANrLlpx/7a835o=; b=jaw1LcK6kCQbAnlT6t7hqOXqivUl3/KQqa9TtyKgHIUa1+kOTuWIGz9beYk82ebUuR 1fBlf8QVNaQk/2q35IuPJ1ziA7EIaZ4Z7WQX/yFW1AQq76umqB3WD+Uq1Xex0bKLSQ5X D5wwKrdQpeq/BQHI4L4pXY0EPOkeDvZpISCX8qZQr2vKwpMS5OKjMLHefpEntboO+DRv rvSlAs2UJGU26rywB0nbS8GGoo12JsMIfgTeSNRYEa84H8O2fm45wUGjD3Gym7wqPWRi 7nfB6EXaObtMxo6AOprW+0zzxlY2yaghhhO5Npek05MaUkNa1r3q+jsHRUEQgTO5wrz5 Z2yQ== X-Gm-Message-State: AC+VfDwuyXlCWI+nwfJR8af3V0rgf0nItQsDfiB9ufo9uBgZ9yHsvH9e LUGvm+xRTznzvxc9mQpVncD7G4+BffaIF/x4s7Fclvqp6PeGZbVE X-Google-Smtp-Source: ACHHUZ4t9/EyOwgPHm5A4llyvBK8c8NepMSwTyTsHI9q6ivK9Gu0N+Mtd5+UgvPFZGSRgQL6o9uu2Xs7JAyEygKAZP0= X-Received: by 2002:a05:6512:401b:b0:4fb:7592:7e03 with SMTP id br27-20020a056512401b00b004fb75927e03mr727228lfb.20.1687758587431; Sun, 25 Jun 2023 22:49:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 26 Jun 2023 11:19:36 +0530 Message-ID: Subject: Re: Adding storage parameters on index To: Pravesh Sharma Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000122b3805ff01eb67" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000122b3805ff01eb67 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Pravesh On Fri, Jun 23, 2023 at 2:28=E2=80=AFPM Pravesh Sharma < pravesh.sharma@enterprisedb.com> wrote: > Hi All, > > I am working on feature #6374 > which is > adding storage parameters while creating an index. I have made changes in > the definition tab of create index to have all the required parameters. > Attached is the new design, please review it. > > I also have a few points which require suggestions. > > 1. Storage parameters are different for different access methods. If > an access method does not support a parameter we can either disable it= or > hide it (I am thinking of hiding it based on the access method). > > Disable the controls. > > 1. There is a storage parameter named *buffering *which is by > default auto and takes on/off value. What type of control should I use= for > it? Should it be a switch or a drop down with three options on, off an= d > auto, if we have a switch user won't be able to move to auto. > > It should be a drop-down with all three options. > > 1. There is a parameter *vacuum_cleanup_index_scale_factor *that was > added on PostgreSQL 11 but was removed on PostgreSQL 13, should we add= this > too? > > No need to add the above parameter. > > > Thanks > Pravesh Sharma > > -- > > > > Pravesh Sharma > > Software Engineer > > +91 9406461406 > > www.enterprisedb.com > > Power to Postgres > > > > > > --000000000000122b3805ff01eb67 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Pravesh

On Fri, Jun 23, 2023 at 2:28=E2= =80=AFPM Pravesh Sharma <pravesh.sharma@enterprisedb.com> wrote:
Hi All,

<= div>I am working on feature=C2=A0#6374=C2=A0which i= s adding=C2=A0storage parameters while creating an index. I have made chang= es in the definition=C2=A0tab of create index to have all the required para= meters. Attached is the new design, please review it.

<= div>I also have a few points which=C2=A0require suggestions.
    =
  1. Storage parameters=C2=A0are different for di= fferent=C2=A0access methods. If an access method=C2=A0does not support=C2= =A0a parameter we can either disable it or hide it (I am thinking of hiding= it based on the access method).
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Disable the control= s.
=
  1. There is a storage parameter named<= span>=C2=A0buffering=C2=A0which is by default=C2= =A0auto and takes on/off value. What type of control should=C2=A0I use for = it? Should it be a switch=C2=A0or a drop down with three options on, off an= d auto, if we have a switch user won't be able to move to auto.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 It should be a drop-down with all three options.
    There is a parameter=C2=A0vacuum_cleanup_index_s= cale_factor=C2=A0that was added on PostgreSQL 11 but was r= emoved on PostgreSQL 13, should=C2=A0we add this too?
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 No need to add the above parameter.


=
Thanks
Pravesh Sharma

--
<= /table> --000000000000122b3805ff01eb67--

Pravesh Sharma

Software En= gineer

+91 9406461406

www.enterprised= b.com

Power to Postgres

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <= /span> =C2=A0 =C2=A0 <= span style=3D"font-size:11pt;font-family:Roboto,sans-serif;color:rgb(17,85,= 204);vertical-align:baseline;white-space:pre-wrap">