public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgadmin4][Patch]: RM #3423 Drop option is not available for the procedure
Date: Thu, 21 Jun 2018 16:40:24 +0530
Message-ID: <CANxoLDdtUKEUWFbabQR_bAUX6AxbtD5Tusf_1TXfV0OLKTWQJw@mail.gmail.com> (raw)

Hi Hackers,

Attached is the patch to fix RM #3423 Drop option is not available for the
procedure. Please review it.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Attachments:

  [application/octet-stream] RM_3423.patch (1.0K, 3-RM_3423.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
index 765d6e2..5f8409b 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
@@ -17,8 +17,6 @@ define('pgadmin.node.procedure', [
       });
   }
 
-  var pgSchemaNode = pgBrowser.Nodes['schema'];
-
   // Inherit Functions Node
   if (!pgBrowser.Nodes['procedure']) {
     pgAdmin.Browser.Nodes['procedure'] = pgBrowser.Node.extend({
@@ -62,8 +60,8 @@ define('pgadmin.node.procedure', [
         },
         ]);
       },
-      canDrop: pgSchemaNode.canChildDrop,
-      canDropCascade: false,
+      canDrop: true,
+      canDropCascade: true,
       canCreateProc: function(itemData, item) {
         var node_hierarchy = this.getTreeNodeHierarchy.apply(this, [item]);
 


reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgadmin4][Patch]: RM #3423 Drop option is not available for the procedure
  In-Reply-To: <CANxoLDdtUKEUWFbabQR_bAUX6AxbtD5Tusf_1TXfV0OLKTWQJw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox