Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKgXW-0005wZ-Fh for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Sep 2020 11:32:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kKgXV-0006uy-Du for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Sep 2020 11:32:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKgXV-0006tn-7P for pgadmin-hackers@lists.postgresql.org; Tue, 22 Sep 2020 11:32:53 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kKgXN-0000d2-9s for pgadmin-hackers@postgresql.org; Tue, 22 Sep 2020 11:32:52 +0000 Received: by mail-il1-x134.google.com with SMTP id y9so16922309ilq.2 for ; Tue, 22 Sep 2020 04:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mz53VMW32vINMXTQVPq6xXl9/SYT5cu7wgYSuh2WOOU=; b=yqrVTYFzCQuOS5kIBOGSnMSjBeP2KpHm4pgWjA4qMA0VfM1H0GHoR/8mK5H9SCCxjq KPbW1XcQ7hF3A3DcQ5OrmmZNHg+Vf0zT0ho/w8bu2nX3TBTJ1PqIfuqC2GQ7JQxG0wcD 1nOEe79DIMfIePeALz7O004l9OXe2UinkgDotzgb19pBOgRmhlDPEdErd+X6FhRbD7i5 ktLlRz5OANKUbYIKMHsT9xBBBQDpveXaOfVyMXVCYQcLDXSYWoGRXP0MB1kj0FMFI09v M3/8EvVTeVm2HtSG15nYTk8tv1Fjuzd+4zcFzbbjdgAto5vfBTd+oNgCFkSj3rWSgZia xXnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mz53VMW32vINMXTQVPq6xXl9/SYT5cu7wgYSuh2WOOU=; b=LJ+G9KNAHBdZaYsg6MsoLt8TREbPRpzt2qIXc8eSo+EU2CegNxnSZ1ByNauFq+E/W+ P90DVKo2QN0ZwdBGRS6//O/uFmPtwbmtCQSyLNrRKkJxpIENHNTc4og3axSZVUfjgEBs a3F0fA7wCR7sNcqzgfPb/j8MQF2M8Osn4Fj2QoBeCL/d+kBuPW+pAZyhXvvYc3tyEOMD Z1vwDFq/tW+jJUKnDT4IJZrGHbtqoelzjW5jtg09PYnT6lV72qVmIq6zdy5PfrAKXqDw iA6lf9aU/7rmboFKM4qabP8+iOh8UmZxH+oQeiQUerbU6EWoq/zl2tg3smfnnFdlJRbU hckQ== X-Gm-Message-State: AOAM530cuMKdnPhAPCDAehDwpdVtszYnf2f0IX8pJrQcbKES5dT+eCBI 2T8bzmd4wrUPFeTuVYmiJWZCs578AdQ4kGNl74kMDTTb7LX2lzLgy95m5hvvCt+Paj3J+IhB0Ua i3zP/xpr/X5JgVmI5ZGaZsqL80ENwcM3UncCjWeoVBsY4VEiXkJvK5UfBNgjbd8ytIwBwbNkyvD swJ6kBhcInoKx8A5UCb7xHI77h+u8wBGlh3JyofLPM1Aqtg0N7S82v6118mQ== X-Google-Smtp-Source: ABdhPJxJwIBkUtgKWlXR5TXPgttum9IBFRTbw6ERCgkLllb8EHghFm/be0MF0CmbKwbxyR0OfRIs/7hS+0++9jWI+WQ= X-Received: by 2002:a92:d842:: with SMTP id h2mr1164416ilq.176.1600774362160; Tue, 22 Sep 2020 04:32:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 22 Sep 2020 17:02:29 +0530 Message-ID: Subject: Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000039066605afe5535e" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000039066605afe5535e Content-Type: text/plain; charset="UTF-8" Thanks, patch applied On Tue, 22 Sep, 2020, 12:44 Nikhil Mohite, wrote: > Hi Akshay/Team, > > I checked the code and found an issue in the "msql" function, due to which > test cases were failing. > I have fixed the issue, PFA updated patch for the same. > Sorry for the inconvenience. > > > Regards, > Nikhil Mohite. > > > > On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Nikhil >> >> Test cases are failing for all the database server with the following >> error: >> return True, sql.strip('\n') >> AttributeError: 'tuple' object has no attribute 'strip' >> >> Please check and resend the patch. >> >> On Tue, Sep 22, 2020 at 10:56 AM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> I have added few more test cases for the "Functions" module as per >>> RM-5330 >>> PFA patch. >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Software Engineer.* >>> *EDB Postgres* >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > --00000000000039066605afe5535e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied

On Tue, 22 Sep, 2020, 12:44 Nikhil M= ohite, <nikhil.mohite@= enterprisedb.com> wrote:
Hi Akshay/Team,

I checked the code and= found an issue=C2=A0in the "msql"=C2=A0function, due to which te= st cases were=C2=A0failing.
I have fixed the issue, PFA updated p= atch for the same.
Sorry for the=C2=A0inconvenience.=


Rega= rds,
Nikhil Mohite.

<= br>

On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil

Test cases are failing for all the database server with the follow= ing error:
=C2=A0 =C2=A0 return True, sql.strip('\n')
= AttributeError: 'tuple' object has no attribute 'strip'
=

Please check and resend the patch.
On Tue, S= ep 22, 2020 at 10:56 AM Nikhil Mohite <nikhil.mohite@enterpr= isedb.com> wrote:
Hi Team,

I have added few mo= re test cases for the "Functions" module as per = RM-5330
PFA patch.

--
Thanks= & Regards,
Nikhil= Mohite
Software= Engineer.
= Mob.No: +91-7798364578.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000039066605afe5535e--