MIME-Version: 1.0
References: 
 <CAJ9T6SvWCLEOctFXnynEefeo-df40RoE-m6JjCqjvOPXzJ01fg@mail.gmail.com>
In-Reply-To: 
 <CAJ9T6SvWCLEOctFXnynEefeo-df40RoE-m6JjCqjvOPXzJ01fg@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Thu, 3 Sep 2020 18:24:21 +0530
Message-ID: 
 <CANxoLDduNdt4Uyz-mxUHMLhVd9jKzmKvUNmWg4m0nzjwQq4j8w@mail.gmail.com>
Subject: Re: [pgAdmin][SonarQube] : Remove duplicates string literals.
To: Pradip Parkale <pradip.parkale@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000e7adf805ae68408d"
Precedence: bulk

--000000000000e7adf805ae68408d
Content-Type: text/plain; charset="UTF-8"

Hi Pradip

Following are the review comments:

   - ROLE_NOT_FOUND already in wrapped in gettext() then no need to use
   like gone(_(ROLE_NOT_FOUND)). In fact, can we use

   self.not_found_error_msg()instead of new constant.

   - Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext,
   also we can use this constant for string "

   Error retrieving roles from the database server"


On Thu, Sep 3, 2020 at 4:30 PM Pradip Parkale <
pradip.parkale@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a patch for removing duplicates string literals.
>         /server_groups/servers/roles/__init__.py  - 8 places
>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000e7adf805ae68408d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Pradip <br></div><div><br></div><div>Following are=
 the review comments:</div><div><ul><li>ROLE_NOT_FOUND already in wrapped i=
n gettext() then no need to use like gone(_(ROLE_NOT_FOUND)). In fact, can =
we use <br><pre style=3D"background-color:rgb(255,255,255);color:rgb(8,8,8)=
;font-family:&quot;Menlo-Regular&quot;,monospace;font-size:9pt"><span style=
=3D"color:rgb(148,85,141)">self</span>.not_found_error_msg()instead of new =
constant.</pre></li><li>Same with ERROR_FETCHING_ROLE_INFORMATION it&#39;s =
already in gettext, also we can use this constant for string &quot;<br><pre=
 style=3D"background-color:rgb(255,255,255);color:rgb(8,8,8);font-family:&q=
uot;Menlo-Regular&quot;,monospace;font-size:9pt"><span style=3D"color:rgb(0=
,128,128);font-weight:bold">Error retrieving roles from the database server=
&quot;</span></pre></li></ul></div></div><br><div class=3D"gmail_quote"><di=
v dir=3D"ltr" class=3D"gmail_attr">On Thu, Sep 3, 2020 at 4:30 PM Pradip Pa=
rkale &lt;<a href=3D"mailto:pradip.parkale@enterprisedb.com">pradip.parkale=
@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi Hackers,<div><br></di=
v><div>Attached is a patch for removing duplicates string literals.</div><d=
iv><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 /server_groups/servers/roles/__init__.p=
y =C2=A0- 8 places</div></div><div><br></div><div><br clear=3D"all"><div><b=
r></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"font-size:12=
.8px">Thanks &amp; Regards,<br></div><div style=3D"font-size:12.8px">Pradip=
 Parkale<br>Software Engineer | EnterpriseDB Corporation</div></div></div><=
/div></div></div>
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=
=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"co=
lor:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:=
collapse">Thanks &amp; Regards</span></b></font></div><div><font color=3D"#=
3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;fon=
t-size:13px;border-collapse:collapse">Akshay Joshi</span></b></font></div><=
div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:=
arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmin Hacker | =
Sr. Software Architect</span></b></font></div><font face=3D"arial, sans-ser=
if" color=3D"#000000"><b><a href=3D"http://edbpostgres.com" target=3D"_blan=
k">EDB Postgres</a></b></font><br><div><b style=3D"color:rgb(51,51,255)"><s=
pan style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;b=
order-collapse:collapse">Mobile: +91 976-788-8246<br></span></b><br></div><=
/div></div></div></div></div></div>

--000000000000e7adf805ae68408d--