Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJZZL-0000hq-5h for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 09:21:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jJZZK-0004Ee-1J for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 09:21:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJZZJ-00049T-H8 for pgadmin-hackers@lists.postgresql.org; Wed, 01 Apr 2020 09:21:53 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jJZZG-0002ui-Mu for pgadmin-hackers@postgresql.org; Wed, 01 Apr 2020 09:21:52 +0000 Received: by mail-io1-xd41.google.com with SMTP id k9so24931306iov.7 for ; Wed, 01 Apr 2020 02:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mi2YOM9j69qMIZz39rVWdXnR65GEXXb5PV+oVOLXk7Y=; b=VxngSf9IWG28KCWE5tq2E9VcB8/aKB3qdWqgOdv+a+4vzEoCgeH0uGeAUEfz1QjQxa g/NCQbyVRpLMpgMDLAHunE+H9+U5Y8VHlh3weqhkh11ATPxzANtXuGFAHLirAarclCv6 STPv2Sii0OicINewghMc5WjXqIj2b+Tzm2k0btLzwC8iNC+d7/jVXjWNGlxjH++6SpqC euaz/bsVL5Gqqp74mla0CEPvUJEZvGduGsE3i8mb/j9HZJIdY5dKEe3u47GlxBaV3hLU z5WD+pAqCp7pF7IBf51bhaP0c911Ld/XpGd7Yxq08jU0xsLN+SGMyB3LIkFv4Whk0afi jElw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mi2YOM9j69qMIZz39rVWdXnR65GEXXb5PV+oVOLXk7Y=; b=Dm2IwcS0BvuLcfThUvWl8IqRA4aGPSN6KTCMla0cuU/e8Kpzy1PjS5JoCzmfTvXqSf KorgJd5CQi3xiH1gvOTRKeBJ3n/3F4kUVqj1f5gO0ukzL1JPFlHXhS1btKxtLyAh2d7Q JPzfvrakZQZ+xXS6pLmbFhV6qfHD7c6d5PWyZK/7HCCJKIXkDBouJvsqgBfo7JhKDr4L JaJF8Je5eytAIN5IQVlKz5yEfqjyZ66NwG2NZdlDmh942m/2xhx1CQR0Ojx9v8KaujyH RPGnft+aGlvsrbxxrQr4/2KjRxyLiY81PnXv3Nk5YI4fvskwp/CXbzejYrCQoBzNdfTe bdoQ== X-Gm-Message-State: ANhLgQ1+Wa3IjzdCtygnlTsoz01em+IdT8H5L2wq7ZxR5sUOcKbN6884 wJBjYpIMsOPxcnYeDB4VPogEk57tomL502tjQwKF9QJc1js44Fe4ezV68IPq6aTQagIS4P/nWuc 4UEA3N8DhaYqZmPTpW4ZBF8heiXL1VnIwaYQwFCx6g+SwhGao6w3R7TTNgQ00v1qxwvbdxymmr2 Z50b+XDrhPLnpHXl/imEJ3Bkiu+2XAIfwHXn8VwbhngiizZtvemR4= X-Google-Smtp-Source: ADFU+vsaSKTNXiv8GB1G8UVZ3kp6CsGds1ygKS+4DU4E0tELgKF14zMP0NbwLqpPnN3s7VzEJD5wR4eolkLTHj/QdUY= X-Received: by 2002:a5e:990d:: with SMTP id t13mr19502181ioj.52.1585732909593; Wed, 01 Apr 2020 02:21:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 1 Apr 2020 14:51:32 +0530 Message-ID: Subject: Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c9126505a2373699" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c9126505a2373699 Content-Type: text/plain; charset="UTF-8" Hi Aditya API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. Please fix and resend the patch. On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch to add support for parameters toast_tuple_target (PG > v11+) and parallel_workers(PG 9.6+) of table. Refer - > https://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS > . > > Both the parameters are added in the advanced tab of table dialog. > > The patch also fixes a related issue - RM5180, where autovacuum_enabled > parameter is added automatically in the RE-SQL when table has been created > with WITH parameter. > > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000c9126505a2373699 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya

API/RESQL test cases are fail= ing for EPAS/PG 9.6 and maybe above. Please fix and resend the patch.
=

= On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wr= ote:
Hi Hackers,

Attached is a=C2=A0patch to add support for parameters toast_tu= ple_target (PG v11+) and parallel_workers(PG 9.6+) of table. Refer -=C2=A0<= a href=3D"https://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREAT= ETABLE-STORAGE-PARAMETERS" target=3D"_blank">https://www.postgresql.org/doc= s/11/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS.

Bo= th the parameters are added in the advanced tab of table dialog.

The= patch also fixes a related issue - RM5180, where=C2=A0autovacuum_enabled p= arameter is added automatically in the RE-SQL when table has been created w= ith WITH parameter.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software En= gineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a = TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000c9126505a2373699--