public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3
Date: Mon, 28 Sep 2020 17:56:45 +0530
Message-ID: <CANxoLDdvDexWtGgcjO8JDGs9ZwsyD6tKDaWm9b9aO7H0OtZ2yg@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELer_FxoVqaJ1oRU84fE1Tv=9Zu_b17qYMDCqn9Q500DJQ@mail.gmail.com>
References: <CAFOhELf509ywGw44dA6rFoc+tmZvNqVEK2DsYMhF1dUbNB8wRA@mail.gmail.com>
	<CANxoLDc6Uqg4gsUs2WWXtOeVET5Zs2ZxtAG3QQ-v26SkrgND1g@mail.gmail.com>
	<CAFOhELer_FxoVqaJ1oRU84fE1Tv=9Zu_b17qYMDCqn9Q500DJQ@mail.gmail.com>

Thanks, patch applied.

On Mon, Sep 28, 2020 at 2:18 PM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Wed, Sep 23, 2020 at 5:42 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Khushboo
>>
>> Following are the GUI review comments:
>>
>>    - If we provide anyone value either Name or SQL it throws Alertify
>>    error message with 'name' or 'SQL'. The error message should be correct.
>>
>>            [image: Name_Error.png]
>>
> Fixed.
>
>>
>>    - We should not enable the 'Save' button if the value of Name or SQL
>>    is not entered by the user. Either both values should be there or both
>>    should be blank.
>>
>> Fixed.
>
>>
>>    - Click on anywhere inside the empty cell where the clear row icon is
>>    not visible, it pops up the message to clear the row which is already
>>    empty.
>>
>>            [image: Clear_Row.png]
>>
> Fixed.
>
>>
>>    - Save any macro and then open the "Manage Macros..." dialog again
>>    click on the SQL control for the existing macro, cursor is not at the
>>    appropriate place.
>>
>>             [image: CodeMirror_Error.png]
>>
> Fixed.
>
>>
>>    - Macros are not working for multiple users. Create some macro from
>>    User1 and then log in using User2, macros created by User1 are visible to
>>    User2 and when I try to update it is not updating.
>>
>> Fixed.
>
>>
>> On Mon, Sep 21, 2020 at 2:19 PM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for RM 1402 - Macro support like pgAdmin3.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


Attachments:

  [image/png] Name_Error.png (8.0K, 3-Name_Error.png)
  download | view image

  [image/png] Clear_Row.png (19.4K, 4-Clear_Row.png)
  download | view image

  [image/png] CodeMirror_Error.png (35.1K, 5-CodeMirror_Error.png)
  download | view image

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3
  In-Reply-To: <CANxoLDdvDexWtGgcjO8JDGs9ZwsyD6tKDaWm9b9aO7H0OtZ2yg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox