MIME-Version: 1.0
References: 
 <CAFOhELejKEuCvut78N2u8y05YU2XiD3y4=NU0N1R2j+04DOnew@mail.gmail.com>
In-Reply-To: 
 <CAFOhELejKEuCvut78N2u8y05YU2XiD3y4=NU0N1R2j+04DOnew@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Wed, 20 Jan 2021 13:53:30 +0530
Message-ID: 
 <CANxoLDdvJ78_X2=OAwt21UYA-DvBNtqk1cr+tSdoeG4=DdOXaA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] - Fixed various issues of the Macros
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000302e3005b950ac48"
Precedence: bulk

--000000000000302e3005b950ac48
Content-Type: text/plain; charset="UTF-8"

Thanks, patch applied.

On Wed, Jan 20, 2021 at 12:55 PM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix below the issues of the macro module:
>
> #5905 - Save button is enabled by-default
> #5906 - Consistent behaviour should be displayed if user clear manage macro
> #5907 - We need to fix the behaviour of Clear All Rows if user does not
> enter any value
> #5929 - Message "Not connected to the server or the connection to the
> server has been closed." displayed if user created SQL with invalid syntax
>
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000302e3005b950ac48
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patch applied.</div><br><div class=3D"gmail_quote"=
><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jan 20, 2021 at 12:55 PM Khu=
shboo Vashi &lt;<a href=3D"mailto:khushboo.vashi@enterprisedb.com">khushboo=
.vashi@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex"><div dir=3D"ltr">Hi,<br><br>Please find the attached=
 patch to fix below the issues of the macro module:<br><br>#5905 - Save but=
ton is enabled by-default<div>#5906 - Consistent behaviour should be displa=
yed if user clear manage macro<br>#5907 - We need to fix the behaviour of C=
lear All Rows if user does not enter any value<br><div>#5929 - Message &quo=
t;Not connected to the server or the connection to the server has been clos=
ed.&quot; displayed if user created SQL with invalid syntax<br></div></div>=
<div><br></div><div><br></div><div>Thanks,</div><div>Khushboo</div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--000000000000302e3005b950ac48--