public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Pradip Parkale <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up
Date: Mon, 24 May 2021 16:44:53 +0530
Message-ID: <CANxoLDdvJewB488GhL-ByzGuVERto=3Bw=w9ObyR8meK3qDQYA@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6Svgp3gKnyRNjS-XkX69e-kNXUDU1BesV1s=ESgNxp2GAA@mail.gmail.com>
References: <CAJ9T6Svgp3gKnyRNjS-XkX69e-kNXUDU1BesV1s=ESgNxp2GAA@mail.gmail.com>

Hi Pradip

Following are the review comments:

   - Following labels should be changed
      - Browser Details -> Browser
      - OS -> Operating System
      - Config DB -> pgAdmin Database File
   - Server Configuration Text Area should be *readonly* and it should have
   a "col-sm-9" class instead of "col-sm-3".
   - If the user resizes the About dialog then instead of showing blank
   space can we automatically resize the Server configuration text area?
   - The height of the About dialog in the Server mode should be less as we
   are not showing "Server Configuration".
   - In Runtime, we should merge the 'Browser details' in 'NW.js version'
   like *0.51.2 (Chromium 89.0.4389.114)* OR at least prefix 'Chromium'
   before the version in the 'Browser details'.
   - Found string difference in OS details for Runtime and Desktop mode.
      - OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7"
      in Dekstop mode.
      - Windows: "Win64" in Runtime, while "Windows 10" in Desktop which
      also not correct, I am using "Windows Server 2016".
   - Following issue found on Firefox (First Image) configuration in a
   single line, Safari (Second image) too many scroll bars.

                  [image: Firefox.png].      [image: Safari.png]

On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <
[email protected]> wrote:

> Hi Hackers,
>
> Please find the attached patch for #6231. I have added OS, NW.js, browser
> details, and some server configuration in the About pgAdmin pop-up.
>
> Server configuration won't be visible to the non-admin users in server
> mode.
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


Attachments:

  [image/png] Firefox.png (122.7K, 3-Firefox.png)
  download | view image

  [image/png] Safari.png (154.4K, 4-Safari.png)
  download | view image

view thread (13+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up
  In-Reply-To: <CANxoLDdvJewB488GhL-ByzGuVERto=3Bw=w9ObyR8meK3qDQYA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox