MIME-Version: 1.0
References: 
 <CAKtn9dPZQWV8aT+mW5DRU3dZYwKyKyanGST7-juuEdV4Dhp1AA@mail.gmail.com>
In-Reply-To: 
 <CAKtn9dPZQWV8aT+mW5DRU3dZYwKyKyanGST7-juuEdV4Dhp1AA@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Thu, 27 May 2021 12:19:31 +0530
Message-ID: 
 <CANxoLDdvQGWZT7DbmMmssLxy3biY+--KeQx40AkTXzmp7kizLg@mail.gmail.com>
Subject: Re: [Patch][pgAdmin] RM4203 Rename Database by another user
To: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f42ac505c34a2939"
Archived-At: 
 <https://www.postgresql.org/message-id/CANxoLDdvQGWZT7DbmMmssLxy3biY%2B--KeQx40AkTXzmp7kizLg%40mail.gmail.com>
Precedence: bulk

--000000000000f42ac505c34a2939
Content-Type: text/plain; charset="UTF-8"

Hi Rahul

Following are the review comments:

   - Why you have changed the order of the toolbar button on the browser
   tree? It should not.
   - *sqleditor.js (check_db_name_change function)*
   - var declaration should be comma-separated instead of writing var,
      again and again.
      - Add proper comments.
      - Remove dots from the string "Database moved/renamed.."
      - "Please note that the database you are working on has been moved or
      renamed to ${data.actual_db_name}. Refresh databases in browser panel or
      click OK to continue.." should be changed to "Current database has been
      moved or renamed to ${data.actual_db_name}. Click on the OK button to
      refresh the database name."


On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <
rahul.shirsat@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issue of renaming the
> database by another user.
>
> A minor issue of navigation button alignment is also fixed in this patch.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000f42ac505c34a2939
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Rahul<div><br></div><div>Following are the review =
comments:</div><div><ul><li>Why you have changed the order of the toolbar b=
utton on the browser tree? It should not.=C2=A0</li><li><b>sqleditor.js (ch=
eck_db_name_change function)</b><br></li><ul><li>var declaration=C2=A0shoul=
d be comma-separated instead of writing var, again and again.</li><li>Add p=
roper comments.</li><li>Remove dots from the string &quot;Database moved/re=
named..&quot;</li><li>&quot;Please note that the database you are working o=
n has been moved or renamed to ${data.actual_db_name}. Refresh databases in=
 browser panel or click OK to continue..&quot; should be changed to &quot;C=
urrent database has been moved or renamed to=C2=A0${data.actual_db_name}. C=
lick on the OK button to refresh the database name.&quot;=C2=A0<br></li></u=
l></ul></div><div><br></div></div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat=
 &lt;<a href=3D"mailto:rahul.shirsat@enterprisedb.com" target=3D"_blank">ra=
hul.shirsat@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><br></div><div=
>Please find the attached patch which resolves the issue of renaming the da=
tabase by another user.</div><div><br></div><div>A minor issue of navigatio=
n button alignment is also fixed in this patch.<br clear=3D"all"><div><br><=
/div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><div di=
r=3D"ltr"><div style=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12=
px"><b style=3D"color:rgb(96,96,97)">Rahul Shirsat</b><br></div><div style=
=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12px"><font color=3D"#=
5f5e5f">Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.=
</font></div></div></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div d=
ir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);=
font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Thank=
s &amp; Regards</span></b></font></div><div><font color=3D"#3333FF"><b><spa=
n style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;bor=
der-collapse:collapse">Akshay Joshi</span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">pgAdmin Hacker | Principal Softw=
are Architect</span></b></font></div><font color=3D"#000000" face=3D"arial,=
 sans-serif"><b><a href=3D"http://edbpostgres.com" target=3D"_blank">EDB Po=
stgres</a></b></font><br><div><b style=3D"color:rgb(51,51,255)"><span style=
=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-col=
lapse:collapse">Mobile: +91 976-788-8246<br></span></b><br></div></div></di=
v></div></div></div></div>

--000000000000f42ac505c34a2939--