Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMpv1-0008D5-K8 for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 09:25:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMpuz-0006Bv-Fu for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 09:25:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMpuz-0006Bo-5W for pgadmin-hackers@lists.postgresql.org; Fri, 10 Apr 2020 09:25:45 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jMpuw-0003Qs-Pz for pgadmin-hackers@postgresql.org; Fri, 10 Apr 2020 09:25:43 +0000 Received: by mail-il1-x134.google.com with SMTP id d2so933737ilc.0 for ; Fri, 10 Apr 2020 02:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TcL80b3MMaO8v5DQshIVnuO3bw0EwD0lD4vjjMeLJWs=; b=NplyMYL4GdV5PaSS6LyD/bpuxQV8YX0co4H+wTzrJawsTKQYiUILF/OL7xmdhmDDXZ k404KejuuHP7aAmsKyvCcH/zbKZEYdU6GE6fL2T7H8wc9U8L3YuN42cINHGALjxr8mM+ BI9NNQ7whLqTrM0mhXeIqtN7zRXMWRGhYCoak040seplxMh0wyOT7+C7eK7xa0u4JMUn cBF62UBguFEQPZRei8Wg0B+oZSTTqZqqF2fx1xMhyPvxRf9orMwAYCMfwqvTk8sv2NWm MlLj+dRwhwaCpGMxP3psM/6bwsJzCxnJPAtvzNjr11LhDk6Kde94H6NHWdhHkPK8+BK0 nNDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TcL80b3MMaO8v5DQshIVnuO3bw0EwD0lD4vjjMeLJWs=; b=BFmAgsIUnNYKWAIN12K0tYr9FcKtH+Px2xmbLlX9MTjpj0JnGT+iFs0CIPQdks2IDp xvrMtYTkK/R93j1tYPQZjr27q7bCa3EzwuY2RlW1xrZXpLheHFtxTeEk/LNcdV1g6hH7 IgOEK/7c+b9HWKiKrqIEApNpRoOgVRAPEalKn3yJ86xvAFrRluQPLGT+lpgGUnZ+37ut YdUPw1QmGg9fB/CxtPVTfe65ajs5BY3HAwY1Qyv2sXVLFkzEed12Z5LF4sfQPUpN1wuh YjafN3oGFd5UA7udY16wQqKH57MTkt8X3wmhorIcEzAD7eS8M8KX3zAGcYGwFxT0AswB VFzQ== X-Gm-Message-State: AGi0Pua+IZ5oBWcH4xdHxlVvvXYyoJMgidnWOoycnWX0nB849/XYi8hF BYaQ+46psF+AIj3xFsgiLaZF2j3q3V3QW4STNq9aAZBtFZ2NcOGEDxnnYft3kPRa5XOfUdpWBWk 5JAV8LMjyqNmKJXXdxlasD1wgxMt7lanmxXyQJQjh4RTVtXj37LV3Vn1Aj7jpta2EtFLI1PfNv1 VUX4l328scUcsQ9nyHUow0mD9ZFTZWfsb+dqeqroiNiJqtyoDMfi4= X-Google-Smtp-Source: APiQypKsSlXK1Vwa/XUmr67K7D846MyXVUbUg2kaHjMsVNEajv3mllXHGzWhc2SpnMH8VgqxB/EJj1QAT9iU1f6Y9tk= X-Received: by 2002:a92:8c45:: with SMTP id o66mr4418568ild.236.1586510741745; Fri, 10 Apr 2020 02:25:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 10 Apr 2020 14:55:30 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID. To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000031c9ea05a2ec51a3" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000031c9ea05a2ec51a3 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Fri, Apr 10, 2020 at 11:58 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Akshay, >> >> On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Khushboo >>> >>> Schema Diff test cases are failing with this patch. Please fix and >>> resend the patch. >>> >>> Fixed. > > Thanks, > Khushboo > >> Can you please re-verify as I don't think schema diff test cases are >> failing due to this patch. >> >> Thanks, >> Khushboo >> >>> On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym >>>> properties does not show OID. >>>> >>>> As per the current implementation, we completely ignored OID and >>>> instead considered the name as the unique field, now with this patch OID >>>> will be used as an unique id and also will display OID in the properties >>>> tab. >>>> >>>> Thanks, >>>> Khushboo >>>> >>>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000031c9ea05a2ec51a3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Fri, Apr 10, 2020 at 11:58 AM Khus= hboo Vashi <khushboo.= vashi@enterprisedb.com> wrote:
Hi,

<= div>Please find the attached updated patch.

Thanks= ,
Khushboo

On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi &= lt;khu= shboo.vashi@enterprisedb.com> wrote:
Hi Akshay,

On Wed, Apr 8, = 2020 at 12:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
<= /div>
Hi= =C2=A0Khushboo

Schema Diff test cases are failing=C2=A0w= ith this patch. Please fix and resend the patch.

Fixed.

Thanks,
Khushboo=C2=A0
Can you please re-verify as I don= 9;t think schema diff test cases are failing due to this patch.
<= br>
Thanks,
Khushboo=C2=A0
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 -=C2=A0[EPAS] Synonym prope= rties does not show OID.

As per the current implementation, we completely= ignored OID and instead considered the name as the unique field, now with = this patch OID will be used as an unique id and also will display OID in th= e properties tab.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000031c9ea05a2ec51a3--