Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSAV6-0005kT-A2 for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Apr 2021 03:29:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lSAV5-0002KV-7k for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Apr 2021 03:29:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSAV4-0002KO-VI for pgadmin-hackers@lists.postgresql.org; Fri, 02 Apr 2021 03:29:35 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lSAV2-0000A0-57 for pgadmin-hackers@postgresql.org; Fri, 02 Apr 2021 03:29:34 +0000 Received: by mail-il1-x133.google.com with SMTP id z9so3810379ilb.4 for ; Thu, 01 Apr 2021 20:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jO5wcgNzCnCiuLZ08/vUogXAwj1YU0IocBXcsxmJWkE=; b=RocsyNCe/iQ92RiQ1ZxOHI5oEMBsFLhV8o8Xomf8Ng6wpeGGnqoDLDcA4Mfmte1qgO oDcBth84ebFpyPGh27I2MlpEAr438PHRkJtOiR4TicVXe/tTi2ARj0aTfjwcJetUmBNh z/DePKHD1JGTZrPHKcsqjmbE2N1dp1gWYn5SfUO8bX3/BOFqXPpZhxOXkNLilL0epwM3 3zvrbIkEKsE38R/QLfZkmgZm0Rky3zgUBeEmmN2ISxCCQpM5GwqDha3pDGVFdsJraVgr RhmN4mTEXE65/NGLPteq7zHvJCh4NDNP3SlS35u1fQIrzm6ztsQywFTruCmiPjHOS5Fp rEDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jO5wcgNzCnCiuLZ08/vUogXAwj1YU0IocBXcsxmJWkE=; b=hfGGe3l5ysyxT2Nx0M4syxDtm5w7ako05QAfEbfkFLqcZkqU/+4VeN4RkkWHIKyFw+ MKCt4DfmMdiD0G0emMaGhr9/i2dPXKIlmRZoVNbszYYJ03DoPioyvZf359XrBWfDffiD qkj7MPPIFRgY/WQy4511tktzPBfV+LftePWQxb3OnFZ38BIdbK6fh9wojcd5Ng9lqyUi VNd2aPQjiTBHOegS0/PVrzq2o9AmIhQkt++4Zl7M/kAI/KTjvFdjlSNJxves+gBq2XyB FJ1mYBD9GEaSa11Ms9u5F/2++VyurkhrudJi8T+aDwrMoJ2+UiRoXnEutECtWf+DOmSY DhTQ== X-Gm-Message-State: AOAM533n9Swzygk10A1ulOeql3yHBPhigT4zmjkZ33d9BUsPDOBPu8JD UsnrrIoVKa1b2dgU1tsgtVnZOtPbSXyLImPltzj1s2TWt75VIzVuZYuMjXmL7prvUDDubIHhGBb KH5DylK5Hq9mbGKUoJbhxd+DI4EOg2WMpWG65mT/vYMDs/G6lMZG/YLCCPNhgJxN9caoFvtqjYK yqqifAqm284bz2KiXL7iiOrEMwibF2CBqzKlY8Sd3n0W9B0NlDL1eppRnWppdB+1k= X-Google-Smtp-Source: ABdhPJzfEubR+9fI6Zud6WAzeFhSo7DJ/fJqFQrWzFDu90O+LcTIHXH1zUA7bY89BzcdrlGIZJPXFudOQhcZwpBoFCI= X-Received: by 2002:a05:6e02:1a2f:: with SMTP id g15mr9632487ile.176.1617334171436; Thu, 01 Apr 2021 20:29:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 2 Apr 2021 08:59:20 +0530 Message-ID: Subject: Re: [pgAdmin][Patch] RM6076 - No error thrown while importing server if servers.json has incorrect keys/insufficient keys To: Yogesh Mahajan Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c5a40d05bef4f460" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000c5a40d05bef4f460 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Apr 1, 2021 at 5:43 PM Yogesh Mahajan < yogesh.mahajan@enterprisedb.com> wrote: > Hello Team, > > Please find an attached patch which shows the exact error if the json file > used to load the server has missing keys/incorrect key value. > > Thanks, > Yogesh Mahajan > EnterpriseDB > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000c5a40d05bef4f460 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Apr 1, 2021 at 5:43 PM Yoges= h Mahajan <yogesh.mah= ajan@enterprisedb.com> wrote:
Hello Team,

Please find an attached patch which shows the exact = error if the json file used to load the server has missing keys/incorrect k= ey value.

= Thanks,
Yogesh Mahajan
EnterpriseDB


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000c5a40d05bef4f460--