Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG1Jr-00026V-Nn for pgadmin-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 14:43:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kG1Jq-0007ti-Lz for pgadmin-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 14:43:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG1Jq-0007tb-C7 for pgadmin-hackers@lists.postgresql.org; Wed, 09 Sep 2020 14:43:30 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kG1Jo-0003ym-0L for pgadmin-hackers@postgresql.org; Wed, 09 Sep 2020 14:43:29 +0000 Received: by mail-io1-xd2e.google.com with SMTP id g128so3365539iof.11 for ; Wed, 09 Sep 2020 07:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=00tZU9yBRE/5Urp7ptTA61wvYt7kFVt80eSiqFI+FjE=; b=WNGESHspWjmNWApEHRMk0a8Dc6cWJUD1smdJDY/TP3Nmrrc98L126Bmvu29PRQobwb GMW2F2WEj2cQVxbYXz16noSK3OzeKCCGW5vyZiyXBpeymaK9ocWQUIkoqG+kCFkjH4xd 0l8LnaIl/3qTW1C8AmTZKo3sfIn3HjVWLB9ilMVidmlFeMiInlK6fkEGxTouqWzd9jtK aUg992T3VgYsQLw5g+0wHM4ywWh4HrepJ5/eINVy8b5IDYAzox+g2hQVHybVT1WQFYqr BxTCeUwkN8bveEOhYzSM//ONe2GEF81xRS7ag/CaV1lTPfseiSaxFYrGMGuquRy3yb4h +OhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=00tZU9yBRE/5Urp7ptTA61wvYt7kFVt80eSiqFI+FjE=; b=UDUuyEWnXqlBUVpyK6OT/YpicQ5Z/0Z9UrHOoJPlLZSXr7tgvT3PmClQQM+ryCkb3h wF/oPckstAiaMRZHgh9wjWc/gbkMPn50xyUvOWHenV0ryqgNyzzf6W1AowWd7DP+OwTe wrG7H/KrD5iTuE9MD60Jfh+k9jsf64Pvszn4Ar+lxsxg1QibM5+u2G95KkAeJmrolUGO AMtwSTEvZUM8fijukGOSzx8scI6E2Buh7Ao5nlL8t5LvmMaJdIjEg6Ti/mLNObiH55Co m0OgW7lXX595tWdBycIV66mwpqJPcik8u1ssEplUtHG7KJtNQTNhZpybsbHnj2Ctg1x9 SkqQ== X-Gm-Message-State: AOAM531oBQ5dNSu0vwY8Tk70R6C3En3wqw6XMHpFFaXcN30tuoYOkZkm sOdmRkuPQIOaK0Z1SmCrlfF8cLxN3PdHOTS0v5WXiY5/E1eunB/M8rl2uAapd11Zap9OF7C2hOv o9Mzg5aPFSbhBhB5/5In5xzDoG5SwLAZG83va1ee6oKp38bCFu1Jt8adCo22C4ijolVJC3UsJvO zwA7k0L+NjTJav/NtJic7hcvp7k71vFuRgB7qRR+xuHPKf449NxxlKRBuFJw== X-Google-Smtp-Source: ABdhPJxm7PJCPhWkWcqonnqQyJBuuAiQ+BFxLpAyIyU+vk0V9sBAbnB69oJS0rjQ9ZX1rK739iAopgvAH+CHrty2i9s= X-Received: by 2002:a5e:c70b:: with SMTP id f11mr3811165iop.140.1599662606944; Wed, 09 Sep 2020 07:43:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 9 Sep 2020 20:13:13 +0530 Message-ID: Subject: Re: [pgAdmin][RM5815] Generate script is not working in new window To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000072a70605aee2796b" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000072a70605aee2796b Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Sep 9, 2020 at 3:19 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > If schema diff is opened in a new tab and "Generate script" is clicked > (with query tool setting "open in new tab" set to true) then it shows a > forever spinner because of pop up blocks. > > Attached patch will show an alert message in that case so that the user > can allow pop up and generate the script again. > > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000072a70605aee2796b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Sep 9, 2020 at 3:19 PM A= ditya Toshniwal <ad= itya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

If schema dif= f is opened in a new tab and "Generate script" is clicked (with q= uery tool setting "open in new tab" set to true) then it shows a = forever spinner because of pop up blocks.

Attached patch will show an = alert message in that case so that the user can allow pop up and generate t= he script again.

Please review.

--
Thanks,
Aditya Toshni= wal
pgAdmin hacker=C2=A0| Sr. Software Engineer | = edbpostgres.com
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Thanks & Regards
Akshay Joshi
<= div>pgAdmin Hacker | = Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

<= /div>
--00000000000072a70605aee2796b--