MIME-Version: 1.0
References: 
 <CAMavuw3D1u7QCxL3rfKHBzykjDZ5N+tqq1aeOwAnSP=nW8-4Vg@mail.gmail.com>
In-Reply-To: 
 <CAMavuw3D1u7QCxL3rfKHBzykjDZ5N+tqq1aeOwAnSP=nW8-4Vg@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 23 Mar 2020 16:00:21 +0530
Message-ID: 
 <CANxoLDdxMRw_DZOjTrkTQwUau0VQ+wwMpezQkzAdUsZNeBJO2w@mail.gmail.com>
Subject: Re: pgAdmin 4 - gettext usage fixes
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 "Libor M." <liborm85@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000ed520805a1831f57"
Precedence: bulk

--000000000000ed520805a1831f57
Content-Type: text/plain; charset="UTF-8"

Hi Aditya

Can you please review this?

On Mon, Mar 23, 2020 at 5:00 AM Libor M. <liborm85@gmail.com> wrote:

> Hello,
> I fixed using gettext function and add more usages for translations,
> specifically:
>
> - fixed usage gettext('') instead of _('') in javascript files
> - fixed usage gettext('') instead of `${gettext('')}` in javascript
> files, because "pybabel extract" not support extracting from this
> syntax
> - added a lot of gettext for support translations
>
> Diff file is attached.
>
> Best regards,
>
> Libor M.
>
> E-mail: liborm85@gmail.com
> GitHub: https://github.com/liborm85
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

--000000000000ed520805a1831f57
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Aditya<div><br></div><div>Can you please review this?</=
div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_at=
tr">On Mon, Mar 23, 2020 at 5:00 AM Libor M. &lt;<a href=3D"mailto:liborm85=
@gmail.com">liborm85@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex">Hello,<br>
I fixed using gettext function and add more usages for translations,<br>
specifically:<br>
<br>
- fixed usage gettext(&#39;&#39;) instead of _(&#39;&#39;) in javascript fi=
les<br>
- fixed usage gettext(&#39;&#39;) instead of `${gettext(&#39;&#39;)}` in ja=
vascript<br>
files, because &quot;pybabel extract&quot; not support extracting from this=
<br>
syntax<br>
- added a lot of gettext for support translations<br>
<br>
Diff file is attached.<br>
<br>
Best regards,<br>
<br>
Libor M.<br>
<br>
E-mail: <a href=3D"mailto:liborm85@gmail.com" target=3D"_blank">liborm85@gm=
ail.com</a><br>
GitHub: <a href=3D"https://github.com/liborm85" rel=3D"noreferrer" target=
=3D"_blank">https://github.com/liborm85</a><br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"=
><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:=
13px;border-collapse:collapse">Thanks &amp; Regards</span></b></font></div>=
<div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family=
:arial,sans-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</sp=
an></b></font></div><div><font color=3D"#3333FF"><b><span style=3D"color:rg=
b(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:collap=
se">Sr. Software Architect<br></span></b></font></div><div><span style=3D"b=
order-collapse:collapse"><font color=3D"#000000" face=3D"arial, sans-serif"=
><b>EnterpriseDB Software India Private Limited</b></font><br></span></div>=
<div><b style=3D"color:rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font=
-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Mobile: +=
91 976-788-8246</span></b><br></div></div></div></div></div></div></div></d=
iv></div>

--000000000000ed520805a1831f57--