Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwQJ7-0003wh-8J for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 14:26:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lwQJ5-0004xG-EF for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 14:26:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwQJ5-0004x8-4t for pgadmin-hackers@lists.postgresql.org; Thu, 24 Jun 2021 14:26:15 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lwQJ2-0006N5-06 for pgadmin-hackers@postgresql.org; Thu, 24 Jun 2021 14:26:14 +0000 Received: by mail-io1-xd33.google.com with SMTP id h2so8376536iob.11 for ; Thu, 24 Jun 2021 07:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ba3j6XkEBIeE+eGdVxd1OUUs8R7q1hpNnxmbYkAMJlA=; b=CLfz296Gzkgl2WKDvC2VCJA4xpIfIR7c2tPyQUeWrAcIHyMJxyY1zc5580IyDGsVBn +78cgnsOuAvwWSBeNIwG7Pv3b/JKKprQMMa+ZcLTdJXEK3uyfGAG+pdjSmuEb0uXLOvH rvYKSn75L17bzhKjhDs31x/F3cqmNfka8f6jDNddM+esR0V2qdmiXs7cboLbAgs0sq4f 9s4exI6uO3uKSJpmq8vqvJZZaRoukIOtkNaDf24shBuTH6wTndP6X9zi9N0dZ0YcGRcX QXhB2EVBytBRte8SyqcW7u5YZTXOC2qd/DcBibc+U+si/Coc8rwUr40+VTQEsR06grTU 8yFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ba3j6XkEBIeE+eGdVxd1OUUs8R7q1hpNnxmbYkAMJlA=; b=kBi+epGkpUGdJzlW4Sqy+/xDhw7UHRSlf0wz696rVP/JH63eAxB9iHB5VadwQjFZ31 WDLShNm6BxrE2r147gpKdKtOArqqXhs+2u9m7BWNrj5orVmODHpgB5inZiAkW80cmR7t IcZBj8Vvjac99FRtJcqAf8HTIeSjuf1C6RWj2+dY8D5MpIzeXKTH/fxdtzgustmUn1V1 7AF1V9m80CvV/xYl9zuX/PR0IBbEgVyuvriaFGFF0kwTMGHO8PeE6+XsuzNcairiFe6p IsqAAz0d/Hq/P4VV3PeBHGKNa/Edg0gWNY8iD9BD917pTtlWLnnYWomhNJMRzTzRXxLj fBPQ== X-Gm-Message-State: AOAM531V3FIhd2H3L24JhB49toAUuaeWnTtfBW+czg3u5oJzlf+981ZK enqCbDPB8NTx0vOU/hdziBPCQQBpF7kLbXJmkD6V3XmVNdkVA2wdH4pkrXpbWibjhTQK2XpQP2b HmESaq3E4a8WHpqQoINY3euAJUOYpfmY+PRolNcNBuxmqGq6JyCf837tmIV5ETgqClPXMkG5UzO t5ZxSDBBFolU6ZWEHvn4Ly7f0pw4yjlgiK6cFuvGyduI/3NYpqy/fZq1KthQ== X-Google-Smtp-Source: ABdhPJws9G0/JTK8n7iPL92YTN7WV+xbLObTg7heAYjsKPKlgUJFofZux5w/vnRiS7rduLaNhuf64xUCEV5h7KkfYDA= X-Received: by 2002:a02:ccab:: with SMTP id t11mr4932064jap.1.1624544768401; Thu, 24 Jun 2021 07:26:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 24 Jun 2021 19:55:57 +0530 Message-ID: Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000d7bb1105c583cd04" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000d7bb1105c583cd04 Content-Type: text/plain; charset="UTF-8" Hi Pradip I have seen that we have duplicated code for resize_the_queryTool, resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I would suggest making a common function somewhere in the utils and call that function. In the future, if we need to change the code we will have to change it in four different places. Please resend the patch after fixing the above issue. On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > > Please find attached for debugger and ERD tool which was missing in > my previous patch. > > On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >> On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch for #6398.Detaching query editor panel >>> gives a blank white panel. >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000d7bb1105c583cd04 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Pradip

I have seen that we have= duplicated=C2=A0code for=C2=A0resize_the_queryTool,=C2=A0resize_the_erdtool,=C2=A0resize_the_psql, and in debug= ger_ui.js file.=C2=A0I would suggest making a common function somewh= ere in the utils and call that function. In the future, if we need to chang= e the code we will have to change it in four different places.

Please resend the patch after fixing the above issue.

On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:<= br>
Hi Akshay,

Please find=C2=A0attached=C2=A0for debugger = and ERD tool which was missing in my=C2=A0previous patch.

On Wed, Jun = 23, 2021 at 11:50 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:<= br>
Thanks, the patch applied.

On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale = <pr= adip.parkale@enterprisedb.com> wrote:
Hi Hackers,<= div>
Please find the attached patch for #6398.Detaching query= editor panel gives a blank white panel.

<= br>
--
Thanks & Regards,
Pradi= p Parkale
Software Engineer | EnterpriseDB Corporation
=


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000d7bb1105c583cd04--