Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jAC7o-0007Ky-LG for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Mar 2020 12:30:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jAC7n-0002yo-FM for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Mar 2020 12:30:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jAC7n-0002yh-2e for pgadmin-hackers@lists.postgresql.org; Fri, 06 Mar 2020 12:30:43 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jAC7k-0002yr-CN for pgadmin-hackers@postgresql.org; Fri, 06 Mar 2020 12:30:42 +0000 Received: by mail-il1-x142.google.com with SMTP id g6so1868149ilc.7 for ; Fri, 06 Mar 2020 04:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yfCyN/cNxkg9Vo8dB3jyakjnjbh+5+0mOHzf8yVVVy8=; b=LCWxDEFZc3GkwDs/3xqZZIG4nCAnOvnP8GEZ9hBRisulQpsvOaCq4rOC16BAGihQqD wPQcZtrE1cyx4MGj3kJ5o7KbrToiB8GvABi+eZYNv6Vm3vCq3T7s8dX95/VB3zyPvUMZ 2GyRqoPHT9NKA30gvotkhdKE9bOl0Y1ck5PospR2W+TMiySpMhLBLERKG4vaQXkW6Mdt kvBR+70PO3t3JtXnc1EBCieaS1w76dmdeKWG9pmFu6zpDo3Xv6UA2Ent80Sypxek6WiZ +eQkJextlDuwbDgKyaQ8jVptlIayOOVsK2o4VFBVFZZPMbXQZN9Ztj5A2ia/vc7DH/sY e3LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yfCyN/cNxkg9Vo8dB3jyakjnjbh+5+0mOHzf8yVVVy8=; b=MD2vn7l2QzcNl1WdWuSf/3kyCWFT+DGxN/1KjldJX72RTYSb4WqMQs+WOzqsJM4JY+ wFDceCS/Dk0uadsyzx0KXWCgBn6OSO67q0rWwMh0KuIj/3WCBFBg2LNzBuYg081+cHXe P4IkNq7T5XqiOGC1kou1Xw38V/PBd7NzLkA2Y8Xlckl7NSHCNR4V3ANvaQOog1qmyGGm tZXy++2oSX3a3n26v2flfJFsCERlc42JZ5iFMEjRluBryNjZTFwOaxA4nqMb91u61zFx XsvqIbuR1EJubrmoYHQJyBMteNjriLKuLUwmST4Piv5p4qIJwe5N2HYXZgLKSUuuXHcA ILaQ== X-Gm-Message-State: ANhLgQ0QJRur+SDtOUEv5aIwO7Z2jdkbTwCtYavqQp/Dq38ooEZdEwak vGljJj/hxUjfw6/j0boUWbTVTyXrbWf9FocCuadlinOWF7/dFeFnNNunmf30MRaYsMKNY1OtJCK 4p/YefVV0eBs7FS+VHm0OzKjJ1arH5YnPQmDOfjixyf92K71oiPwiHdF9wdFFS7U4VapvcyaY6S RTTrUbWjL3PUosTRaXe5c2EsajX0pzO3k66mbFlF7+ucclQGbuYPw= X-Google-Smtp-Source: ADFU+vsN8swiizYBJBn6kPgeiw6b2lPafDVorPotPFdYogZSjBiofZmYIVVn1zeOD9a7DQaPKedsbjwUoGSgBRraM/M= X-Received: by 2002:a92:89cb:: with SMTP id w72mr2809303ilk.252.1583497837834; Fri, 06 Mar 2020 04:30:37 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 6 Mar 2020 18:00:26 +0530 Message-ID: Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified To: Nagesh Dhope Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000208ff705a02ed203" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000208ff705a02ed203 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Fri, Mar 6, 2020 at 12:21 PM Nagesh Dhope wrote: > Hi Akshay, > Please find a patch to make controls under *Active query details* subnode > read-only on the dashboard. > > > On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch to include dialogs (create/edit) for all >>> the nodes. >>> Kindly review. >>> >>> On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> As per discussion, we should visit all the nodes create/edit dialog and >>>> make the controls read-only wherever appropriate. >>>> >>>> On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to allow input controls to be set as readonly >>>>> instead of disabled. >>>>> I've also changed the code for the nodes to make sure properties tab >>>>> have readonly fields wherever applicable. This will allow tab navigation in >>>>> properties tab and also allow screen readers to read it. >>>>> Please note that, I've not visited each and every node create/edit >>>>> dialog to identify what should be readonly or what should be disabled as it >>>>> depends on business logic. The patch is mainly for the properties tab. >>>>> >>>>> Kindly review. >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000208ff705a02ed203 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Fri, Mar 6, 2020 at 12:21 PM Nage= sh Dhope <nagesh.dhope@= enterprisedb.com> wrote:
Hi Akshay,
Please find a patch to make= controls under Active query details subnode read-only on the dashbo= ard.


On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi <= akshay.j= oshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Jan 30,= 2020 at 1:55 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>= wrote:
Hi Hackers,

Attached is the updated patch to include dialogs (= create/edit) for all the nodes.
Kindly review.

On Thu, Jan 23, 2020 at= 1:08 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Adi= tya

As per discussion, we should visit all the nodes cre= ate/edit dialog and make the controls read-only wherever=C2=A0appropriate.<= /div>

On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal <aditya.toshniwal@ente= rprisedb.com> wrote:
Hi Hackers,

Attached is the patch to allow inp= ut controls to be set as readonly instead of disabled.
I've also change= d the code for the nodes to make sure properties tab have readonly fields w= herever applicable. This will allow=C2=A0tab navigation in properties tab a= nd also allow screen readers to read it.
Please note that, I've not vis= ited each and every node create/edit dialog to identify what should be read= only or what should be disabled as it depends on business logic. The patch = is mainly for the properties tab.

Kindly review.

--
Thanks and Regards,
= Aditya Toshniwal
=
pgAdmin Hacker | Sr. Soft= ware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, P= lant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks,
Nagesh


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000208ff705a02ed203--