Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9khG-0006bQ-L3 for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 08:18:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9khF-0003TO-HR for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 08:18:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9khF-0003TH-9w for pgadmin-hackers@lists.postgresql.org; Wed, 10 Feb 2021 08:18:01 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9khC-0000Nk-EF for pgadmin-hackers@postgresql.org; Wed, 10 Feb 2021 08:18:00 +0000 Received: by mail-il1-x131.google.com with SMTP id a16so1070350ilq.5 for ; Wed, 10 Feb 2021 00:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/hc8iqHRyMLcDaLDVESM+vnJV6K1vvFNS0Cl4sJKwHA=; b=f0nfLYBHEieGsjxo2L9xf3nKWJxHqd4ahSNXwfSuAW5v75vLmvdavTrDmEVI/Omzc5 JmLR9WZXBuurYPBy7KbqPp1A1AQQyJw6rfRwJe665oiViSi+dLqzpTN0ZtceaiSTlCUt FtoTtu2amFjGMW5hH/XdsvNDWLsiVPGAsSJmm/iVi6+o9GuNB5eEdAlLOM7GxYHHovQ8 ewXRnk0A2x9759zPfp1f7iLOmecUH88/m6M3NggAhKfDMHO5J4DqQw64mv4wjuZ3Fi4n FlyBaIGHUw2TCSodN+SXbvJWtkW4/hsalIewOe+Zc/ccCktWYiP4whP5z61Ar2kahSrG ZjvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/hc8iqHRyMLcDaLDVESM+vnJV6K1vvFNS0Cl4sJKwHA=; b=gBF7iWXIJa4tGUBf64GtkoGnhWjyma9+1DV/LPoUrpNt+3SW1h/jj3ghji8dPUnY0k ELVp+0M4xbauL7tuTzRf0sSPd1z+A3b0cQYj2JCXrVCdc+5KnQd0i+wArw53Z8euC4JS B1TppAjOB+/uuL5kCdgGIalidPnXGzIWpb09YXMaBAx1JrZ09v4iNj9oCBZN1kdAPw0U JPY4X36QiM9kM/Kn5aRBUs8zIw3rzn//rFfURCVeEKvVM1ufXbWBC4xHCaQaLWGIiWXv 9JSORndyHUnIPE/uO4KPjEakZHwRgFFE3DJeZ54SzC1WTZ3kDcdGKQeZ69hH83pAwuTT 6A2Q== X-Gm-Message-State: AOAM5327GdFnj36BMaQl4ExN03TgzVhV1kk9w6jE0yP2Ex5vDv8oa/xa xRbcgRAX47ysgjke66P0xNnHSxATNq3Ql27ykHR2dnDFm79ZkcrNr8cn1vP5QqodOuMeu1qbaVf HiCmzHAzhkEABzA0wKLCOudjkY63fIJfbCLqVn937P4UjMjf5WSyqjm2chvNg+LUBW6T3xH2ayB /CDXuYgvCCs4cbZoordvZ5nfOeXkwEwiSrkAZYP2+C/zix80nxztGRiy9ylw== X-Google-Smtp-Source: ABdhPJyNlK5QtWsv3aH0RzGHfYA3QuAJvSCSqaUBD/7vRmSrFR/cxQJORTMSww98fYt5ccwsaPBywEwzA0mNauyzvZY= X-Received: by 2002:a92:1302:: with SMTP id 2mr1993057ilt.121.1612945075623; Wed, 10 Feb 2021 00:17:55 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 10 Feb 2021 13:47:44 +0530 Message-ID: Subject: Re: [pgAdmin][RM6207] Update JS dependencies To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000046732605baf70af6" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000046732605baf70af6 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Feb 10, 2021 at 1:37 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > The imagemin-gifsicle package is used to compress gif images. The latest > version of imagemin-gifsicle requires the binaries to be built from source, > which has a big dependency of dh-autoreconf. > pgAdmin has very few gifs. Instead of installing dh-autoreconf, I've > removed imagemin-gifsicle from package.json since the cost of installing > dh-autoreconf is more than the output of compressing gif. > Attached is the patch. > > > On Wed, Feb 10, 2021 at 12:51 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> One jasmine test is failing, please fix that and resend the patch. >>>> >>> It was failing because of a side effect of some other test case. Fixed. >>> >>> Please review. >>> >>>> >>>> On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to update the JS dependencies to latest. Changes >>>>> include: >>>>> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking >>>>> changes, so updated multiple webpack plugins and changed the config >>>>> accordingly. >>>>> 2) Replaced iconfont-webpack-plugin with a more maintained >>>>> webfonts-loader. >>>>> 3) Replaced deprecated babel-eslint with @babel/eslint-parser >>>>> 4) Replaced optimize-css-assets-webpack-plugin with a more maintained >>>>> css-minimizer-webpack-plugin >>>>> 5) Updated all other JS packages and made the required code changes. >>>>> >>>>> Note, there is an update available for slickgrid and I tried to update >>>>> it. But it was not working as expected. So without wasting time, I've not >>>>> updated slickgrid, and can be updated as a separate task. >>>>> >>>>> Please review. >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000046732605baf70af6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Feb 10, 2021 at 1:37 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi,

The imagemin-gifsicle package is used to compress gif image= s. The latest version of imagemin-gifsicle requires the binaries to be buil= t from source, which has a big dependency of dh-autoreconf.
pgAdmin has = very few gifs. Instead of installing dh-autoreconf, I've removed imagem= in-gifsicle from package.json since the cost of installing dh-autoreconf is= more than the output of compressing gif.
Attached is the patch.

On Wed, Feb 10, 2021 at 12:51 PM Akshay Joshi <akshay.joshi@enterpri= sedb.com> wrote:
Thanks, patch applied.

On Wed, Feb 10, 2021 at 12:0= 8 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
<= /div>
Hi,

On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi <akshay.joshi@= enterprisedb.com> wrote:
Hi=C2=A0Aditya

One jasm= ine test is failing, please fix that and resend the patch.
It was failing because of a side effect of some other test case. F= ixed.

Please review.=C2=A0

On Mon, Feb 8, 2021 at 5:07 PM Adity= a Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached = is the patch to update the JS dependencies to latest. Changes include:
1= ) Migrate from webpack 4 to webpack 5. This had a lot of breaking changes, = so updated multiple webpack plugins and changed the config accordingly.
= 2) Replaced iconfont-webpack-plugin with a more maintained =C2=A0webfonts-l= oader.
3) =C2=A0Replaced deprecated babel-eslint with @babel/eslint-p= arser
4) =C2=A0Replaced optimize-css-assets-webpack-plugin with a more m= aintained css-minimizer-webpack-plugin
5) Updated all other JS packages = and made the required code changes.

Note, there is = an update available for slickgrid and I tried to update it. But it was not = working as expected. So without wasting time, I've not updated slickgri= d, and can be updated as a separate task.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000046732605baf70af6--