Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGhhY-0002mJ-St for pgadmin-hackers@arkaria.postgresql.org; Mon, 01 Mar 2021 12:31:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lGhhX-0000lm-PO for pgadmin-hackers@arkaria.postgresql.org; Mon, 01 Mar 2021 12:31:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGhhX-0000le-Em for pgadmin-hackers@lists.postgresql.org; Mon, 01 Mar 2021 12:31:03 +0000 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lGhhT-0005A5-Ls for pgadmin-hackers@postgresql.org; Mon, 01 Mar 2021 12:31:03 +0000 Received: by mail-il1-x129.google.com with SMTP id z9so4169322iln.1 for ; Mon, 01 Mar 2021 04:30:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6+qzJuhDPqxwRzHDbRI/hOWfmha5tGPCKZfJxUndslk=; b=kRoqPj+gZKYijdkdiSqc8F9ziX2WgMXoHfHh1J7gfPnubBK6vjau0D9kWtkx9t48O+ j87MBDMBP47WDeGqzkWyeJxoCsYpn1NsasbBuua6yC/zx2NhHjU5moWCiibQCnwN4IdT 082Sjn1CL9quEMgsDdEgpYGIqRbjQK7wzXHu3NS5zfAlapKFo+9+uUfdmr3CmSfbLU5T 0CRbc8fF6haaBgPNcSaI40ZX1fQ64GZm04LhhNyAZq9UT1mO0/ff0Yt6ibPpv2xJdGjp XGcocL6fn3YaQEaUKh1w7Hpb4CKJLjuqW9USQ8iPS5N2EnBWSU8t4eFAtMUFuaQLKDKU QQtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6+qzJuhDPqxwRzHDbRI/hOWfmha5tGPCKZfJxUndslk=; b=QzotvedVmE3TOqBhh6rKMwBSWfte53uzvpVnUxd/LyFDRqxAGERGwItGizuesxjpJq WQfkd/iZqYb0V4Tjfdap5QR0oaRz2TRqW8nUWNQAV4WiUOR1jDi0gYLh1xvr9sWw1aZR kNkNslVHUWs+HncdMXeyzqBQqpsrZxJP0ucPoZUTO0DiFNrJ11GcrX1zyskWQYpfAlSl QzWheHtHCnBQWp3hEn1v+6yCoBoEFMREQLCOlgxFWX34sA4uqCWMylJ+bMDD2yW8uy5J 3BrsDluyD47/l/NuHGDypzb1gZ1Bd0O+R3szJjdnWpBtSAB3dncBXiO6jbTdrqVu7o0C sXeQ== X-Gm-Message-State: AOAM533AUoIUbe2CYdvSJtvu+MK/C0HD1DXJqkborA63/8zF/jHHfEa5 OYx5wz43l5sHqlEOeJeSRc8TApbglF70F72K6zR75ixccgR862eU1vkLtut3/EmPvwbipmqPMgY O55umvPWjLz2417JMjAR6Xb/oQYMM23o1Mdq9f9q/jGbWYhRdEQEgqL8yZj39/sLbL3klHD6i6/ R3vmMlo6qKwm6xPeg7AzqC7EmGdB128vOB4xs51EmNEQg5aIheAI7D31Ro1g== X-Google-Smtp-Source: ABdhPJz5GzDQgRafuZ+SyHvybbpOg8Lkhl4PawoozePKP3JVTZMmZAfyoKD9K8CZcfl30mfjNEo3cSyaL36EWH18udI= X-Received: by 2002:a92:d906:: with SMTP id s6mr13443683iln.121.1614601856919; Mon, 01 Mar 2021 04:30:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 1 Mar 2021 18:00:46 +0530 Message-ID: Subject: Re: [pgAdmin]: Patch for SonarQube fixes. To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000022c51a05bc78cab1" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000022c51a05bc78cab1 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Mar 1, 2021 at 4:42 PM Nikhil Mohite wrote: > Hi Akshay, > > Sorry for the inconvenience, Please find the attached patch. > > Regards, > Nikhil Mohite. > > On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi > wrote: > >> Hi Nikhil >> >> You forgot to attach the patch :) >> >> On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> I have fixed a few sonarQube issues, PFA patch >>> Details as follows: >>> >>> 1. Back-form (backform.pgadmin.js): >>> >>> - TypeError can be thrown as "$tabContent" might be null or >>> undefined here. >>> >>> 2. User Management (user_management.js): >>> >>> - 'self' is already declared in the upper scope. >>> - 'res' is already declared in the upper scope. >>> - 'self' is already declared in the upper scope. >>> - 'ownershipModel' is already declared in the upper scope. >>> >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Software Engineer.* >>> *EDB Postgres* >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000022c51a05bc78cab1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Mar 1, 2021 at 4:42 PM Nikhi= l Mohite <nikhil.mohit= e@enterprisedb.com> wrote:
Hi Akshay,

Sorry = for the inconvenience, Please find the attached patch.

=
Regards,
Nikhil Mohite.

On Mon, Mar 1, 2021 at 4:37 PM = Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil
<= br>
You forgot to attach the patch :)

On Mon, Mar 1, 2021 = at 4:12 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
H= i Team,

I have fixed a few=C2=A0sonarQube= =C2=A0issues, PFA patch
Details as follows:

<= /div>
1. Back-form=C2=A0 (backform.pgadmin.js):
  • TypeError = can be thrown as "$tabContent" might be null or undefined here.
2. User Management (user_management.js):
  • = 9;self' is already declared in the upper scope.
  • 'res' = is already declared in the upper scope.
  • 'self' is already d= eclared in the upper scope.
  • 'ownershipModel' is already dec= lared in the upper scope.

--
Thanks & Re= gards,
Nikhil Mohite
Software Engineer= .
EDB Postgres
Mob.No: +91-7798364578.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000022c51a05bc78cab1--