Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDpGL-0003eY-51 for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Sep 2020 13:26:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kDpGK-0006tO-2G for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Sep 2020 13:26:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDpGJ-0006tH-OM for pgadmin-hackers@lists.postgresql.org; Thu, 03 Sep 2020 13:26:47 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kDpGH-0007vm-7H for pgadmin-hackers@postgresql.org; Thu, 03 Sep 2020 13:26:46 +0000 Received: by mail-io1-xd36.google.com with SMTP id b16so2669187ioj.4 for ; Thu, 03 Sep 2020 06:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kWhCchAkQ2JxwJ7CdWsbG5yYanzcugG6aWfia0acXLs=; b=PWon919EdtLfSeRYDF9ukIaE/rC9ilBD13tQ7fEO6l/Bxc4PYhWcwNkk+Raob6bgju 63VVC1yzDdxbPawZBY7+nIm665sAIx+TS5OKx8/zf3q/Kb/B8ADE8sanV+ccxVQ76HWV R4nMX8WQa6V8nGyDy0VggK1zbiRtXhDEwyq5b15COTG+lpIrldBZhoY4L1i9GVANNejn K+g4M8BqAZzaLDpGfBqqFp4V14xuqrk/rAPhSySmuHQVXC/kRarVFxCDgGQfj3WQI/03 nPC0BHXUmdJ8cutsG+rURNBXteE5VQn8KRYSOU/WIBRWxr/32fMIRb/NTjagPs+Yr6OJ 9Mhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kWhCchAkQ2JxwJ7CdWsbG5yYanzcugG6aWfia0acXLs=; b=LYKbKp0EMGVlqanD6ehrgPmNQpgN3qoFVewXnu9OiFrJZpUsw5H93DMB5YbIWBi0Os X4JtPorptC6duv5fznMY2Jxkt7Ipvthrp4gqLvVVrIEw08oKQ3dJG2vWP+tIvGoubR5A baTFjzyffPfn8z3ZojgGPgpw36Aap3dU9e0QyC9Bw8VkER0SoMmXmsIyiOn9AuLTzqzI MK/FV+3Iu4mEFXOq6aP8lzM5pioaZcIyNV3YrFSuB/pIMfF160hrenWd7Ml/LSvmar+7 oa0OvVP8z9nLSQlpIAtKupAGwLvyj5r9LLQs7iPEjF58FC1SgbtlAAvdL689OKHMU65q JPTg== X-Gm-Message-State: AOAM532AreDqfo1oJGe/Y6KgIp2ElCrAGAzOHlWc252HkrSvQnM4u6aR 98UdNdRmSRCIC2VEtcN+qOcT8dm4J60ot5slWi5o/gJ4ARrFlg7S0hZcC3qW5Tro/4DeXZl5GJv lM3cBtAOgDpLTb8vXvhnsfFaui2y3ori0OKCSRjaEBFiZu8uBatvQmnlWPShlljzNY6k09O4y1T 3Tr9/HTo8+wTzeCHoXfW4Xjs2hM5wcchVE8nAzCxbbLxydRnj+F3F6tUFgI0exWYk= X-Google-Smtp-Source: ABdhPJzBMbCXG4y8ymMPeLEsGqkzrayQrSLxQmx5m+VKPJAWSDPQzH1f7ObvJ3NhmaLgvmqQ5dSErCt/okThh7ixwVs= X-Received: by 2002:a02:ce8c:: with SMTP id y12mr3350278jaq.53.1599139603904; Thu, 03 Sep 2020 06:26:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 3 Sep 2020 18:56:32 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000009917a05ae68b4c2" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000009917a05ae68b4c2 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Sep 3, 2020 at 4:39 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find more fixes for the sonarqube code smells having the rule "String > literals should not be duplicated". > > Thanks, > Khushboo > > On Wed, Aug 19, 2020 at 2:27 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached updated patch. >>> >>> >>> On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Khushboo >>>> >>>> As per offline discussion, multiple developers declaring the constant >>>> for the same string and error messages. To avoid that only one developer >>>> should work on this task. >>>> Suggestions: >>>> >>>> - We should have a common class for Constants (which are not module >>>> specific). >>>> >>>> Made a constant.py file which contains the common Constants. >>> >>>> >>>> - For module specific constants we should not declare them as >>>> Global variables if possible declare them as the Class variable. >>>> >>>> >>>> - For common error messages(if any) we can define functions in >>>> PGChildNodeView. >>>> >>>> Already implemented. >>> >>>> Please incorporate the changes send by Yogesh. >>>> >>> I will send another patch for Yogesh's changes as needed more changes. >>> >>> Thanks, >>> Khushboo >>> >>>> >>>> On Mon, Aug 3, 2020 at 1:36 PM Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix the sonarqube code smells having >>>>> the rule "String literals should not be duplicated". >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Sr. Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000009917a05ae68b4c2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Sep 3, 2020 at 4:39 PM K= hushboo Vashi <khushb= oo.vashi@enterprisedb.com> wrote:
Hi,

Please fin= d more fixes for=C2=A0th= e=C2=A0sonarqube=C2=A0code smells having the rule "String literals should not be duplicated".

Thanks,
Khushboo

=
On Wed, Aug 19, 2020 at 2:27 PM Aksha= y Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi <khushboo.vashi@enterprisedb.c= om> wrote:
Hi,

Please find the = attached updated patch.


On Tue, Aug 4, 2020 at 12:10 PM= Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Khushboo<= div>
As per offline discussion, multiple developers declaring= the constant for the same string and error messages. To avoid that only on= e developer should work on this task.
Suggestions:
    =
  • We should have a=C2=A0common=C2=A0class for Constants (which are not mo= dule specific).
Made a constant.py f= ile which contains the common Constants.=C2=A0
  • For module specifi= c constants we should not declare them as Global variables if possible decl= are them as the Class variable.
<= ul>
  • For common error messages(if any) we can define functions in PGChild= NodeView.
    • Already implemented.=C2=A0=
    Please incorporate the changes send by Yogesh.=C2=A0 =C2=A0
    <= /blockquote>
    I will send another patch for Yogesh's changes as need= ed more changes.

    Thanks,
    Khushboo
    <= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
    On Mon, Aug 3, 2020 at 1:36 PM K= hushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
    Hi,

    Please find the attached patch to fix the sonarqube code smells ha= ving the rule "String literals should not be duplicated".

    =
    Thanks,
    Khush= boo


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Sr. Software Ar= chitect
    EDB Postgres=
    Mobile: +91 976-788-8246



    --
    Thanks & R= egards
    Akshay Joshi
    pgAdmin Hacker | Sr. Software Architect=
    = EDB Postgres
    Mobile: +91 976-788-8246



    --
    Thanks & Regards
    Akshay Joshi
    <= div>pgAdmin Hacker | = Sr. Software Architect
    EDB Postgres
    Mobile: +91 976-788-8246

    <= /div>
    --00000000000009917a05ae68b4c2--