Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmBQV-0006Zy-4N for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 05:50:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmBQS-0003MK-Nt for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 05:50:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmBQS-0003MD-H5 for pgadmin-hackers@lists.postgresql.org; Wed, 23 Jan 2019 05:50:12 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmBQP-0001ZG-1f for pgadmin-hackers@postgresql.org; Wed, 23 Jan 2019 05:50:11 +0000 Received: by mail-qk1-x743.google.com with SMTP id c21so531667qkl.6 for ; Tue, 22 Jan 2019 21:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zmN+kSkaBzLjPSDWp01oIRKwliIQE8a/7vMWSm7XQD8=; b=AGJ3ErSx/95a5/39B4SyKF4Oa4j+RsdV+BWPn5u+aVU0Q1V0eVdFLxQ40OHcvMr+CZ TjJ19AXtC1PU34EiNt349sp2D2SlFFBjNwfdE+HBWzjhgeYsU5FWqrkLUdNcRmwJJoVc sg7FyNzFI6D5CKJadRmyp6oWbJYpsGke8pWfuYR/u8lo7ogoTxfDdxJVUXW1oxxkdHx/ cSzjkmMzCgll7VAQtpIzF+ytdGc/vJi7iaaed8qc42z8O8Jh2DlRadntlhZaULDwGCk6 IKUh8sS2OEbcpg3SkVLhggcOcbbvq163BntBEo8ZR1eM3B5Lul5smhcJrpWGXD027m8c A5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zmN+kSkaBzLjPSDWp01oIRKwliIQE8a/7vMWSm7XQD8=; b=mySNIGT6YiaDVI1R9uJPb5246LzBmKdNYD1pDAdVvvrcXC91csP9xISrLJ/Z7FIuJ7 FqrbiGuz3duRzNf4DpbyreKrgkKhJNQkt2qqslNEwSlkCbvI5D3dZZoCR4bxWNvCh9bw VmOP8AAFaxG0HGgiNvF5s1yLjD0JCTPzIlxRBldO81JxJZLk//FaW8Jf1BSIJd9RUlbE eNAJSgcfN8XLvVaziHbElABXSemfFQlcqEkrU1aUGSCM9GiPBqp05GJdUtn8KdEzRNLb EtxgxJ+xDXzNM6gPaGVoGQz3You9C3mQoxVJ6JCNkxpKOV7VG7BFRH8smk+t42iumO+b oVWg== X-Gm-Message-State: AJcUukczvDO3kthAf6RzXdWtiAU+JA74ATR0OgnB1vSzJVeHLXy5WcVU ccbD+aGp0Sn3/Z7A9w4SAf3w8RjmjwyJLpA3DJx+uw== X-Google-Smtp-Source: ALg8bN5FUrKGfH+4OvvuEUMq4y5gZcR8Pkfm/E5vyjSPfEaozTCfppEEwV8r/pqd0IuZNCEbM/OEIcb+PIkBIT//czI= X-Received: by 2002:a37:d91:: with SMTP id 139mr690301qkn.166.1548222606539; Tue, 22 Jan 2019 21:50:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 23 Jan 2019 11:19:55 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working To: Aditya Toshniwal Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007f111b058019aaa3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007f111b058019aaa3 Content-Type: text/plain; charset="UTF-8" Hi Aditya Found one issue you have remove the function "*disable_tree_state_save*" from "*web/regression/python_test_utils/test_utils.py*" and move that code into " *set_preference*" function and it is called from " *web/regression/runtests.py*" which is conditional, so please correct that behaviour. On Tue, Jan 22, 2019 at 6:28 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the revised patch. The warning occurrence is configurable from > Preferences > Browser > Display. > > Kindly review. > > On Tue, Jan 22, 2019 at 5:38 PM Dave Page > wrote: > >> On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal >> wrote: >> > >> > >> > >> > On Tue, Jan 22, 2019 at 5:27 PM Dave Page >> wrote: >> >> >> >> On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal >> >> wrote: >> >> > >> >> > Any suggestions on preferences name/desc ? >> >> >> >> Name: "Confirm on close" >> >> Desc: "Confirm closure of the browser or browser tab is intended >> >> before proceeding." >> > >> > It also warns on refresh. >> >> Name: "Confirm on close or refresh" >> Desc: "Confirm closure or refresh of the browser or browser tab is >> intended before proceeding." >> >> >> >> >> >> >> >> >> > On Tue, Jan 22, 2019 at 3:01 PM Dave Page < >> dave.page@enterprisedb.com> wrote: >> >> >> >> >> >> Hi >> >> >> >> >> >> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi >> >> >> wrote: >> >> >> > >> >> >> > Hi Aditya >> >> >> > >> >> >> > Below are my review comments: >> >> >> > >> >> >> > You have added new config parameter >> "DISABLE_BEFOREUNLOAD_MESSAGE" to make this request configurable, should it >> be the part of preferences setting instead of configuration? @Dave can you >> please comment on this. >> >> >> >> >> >> That does seem like something that should be a per-user preference, >> >> >> not a global config option. >> >> >> >> >> >> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users >> perspective, can you please change it to some meaningful name. >> >> >> > >> >> >> > Apart from that code looks good to me. >> >> >> > >> >> >> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >> >> >> >> >> >> >> Hi Hackers, >> >> >> >> >> >> >> >> Attached is the patch to throw alert warning when user reloads >> or closes the browser. >> >> >> >> >> >> >> >> Kindly review. >> >> >> >> >> >> >> >> -- >> >> >> >> Thanks and Regards, >> >> >> >> Aditya Toshniwal >> >> >> >> Software Engineer | EnterpriseDB Software Solutions | Pune >> >> >> >> "Don't Complain about Heat, Plant a tree" >> >> >> > >> >> >> > >> >> >> > >> >> >> > -- >> >> >> > Akshay Joshi >> >> >> > Sr. Software Architect >> >> >> > >> >> >> > >> >> >> > Phone: +91 20-3058-9517 >> >> >> > Mobile: +91 976-788-8246 >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> Dave Page >> >> >> VP, Chief Architect, Tools & Installers >> >> >> EnterpriseDB: http://www.enterprisedb.com >> >> >> The Enterprise PostgreSQL Company >> >> >> >> >> >> Blog: http://pgsnake.blogspot.com >> >> >> Twitter: @pgsnake >> >> > >> >> > >> >> > >> >> > -- >> >> > Thanks and Regards, >> >> > Aditya Toshniwal >> >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> >> > "Don't Complain about Heat, Plant a tree" >> >> >> >> >> >> >> >> -- >> >> Dave Page >> >> VP, Chief Architect, Tools & Installers >> >> EnterpriseDB: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> >> >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> > >> > >> > >> > -- >> > Thanks and Regards, >> > Aditya Toshniwal >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree" >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --0000000000007f111b058019aaa3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya=C2=A0

Found one iss= ue you have remove the function "disable_tree_state_save"= =C2=A0from "web/regression/python_test_utils/test_utils.py"= ; and move that code into "set_preference" function and it= is called from "web/regression/runtests.py" which is cond= itional, so please correct that behaviour.=C2=A0

On Tue, Jan 22, 2019 at 6:28 PM Aditya Toshniw= al <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached i= s the revised patch. The warning occurrence is configurable from Preference= s > Browser > Display.

Kindly review.

On Tue, Jan 22, 2019 at 5:38 PM Dave Page <dave.page@enterprisedb= .com> wrote:
On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal
<= aditya.toshniwal@enterprisedb.com> wrote:
>
>
>
> On Tue, Jan 22, 2019 at 5:27 PM Dave Page <dave.page@enterprisedb.com> = wrote:
>>
>> On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal
>> <aditya.toshniwal@enterprisedb.com> wrote:
>> >
>> > Any suggestions on preferences name/desc ?
>>
>> Name: "Confirm on close"
>> Desc: "Confirm closure of the browser or browser tab is inten= ded
>> before proceeding."
>
> It also warns on refresh.

Name: "Confirm on close or refresh"
Desc: "Confirm closure or refresh of the browser or browser tab is
intended before proceeding."

>>
>>
>>
>> > On Tue, Jan 22, 2019 at 3:01 PM Dave Page <dave.page@enterprisedb.com= > wrote:
>> >>
>> >> Hi
>> >>
>> >> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi
>> >> <akshay.joshi@enterprisedb.com> wrote:
>> >> >
>> >> > Hi Aditya
>> >> >
>> >> > Below are my review comments:
>> >> >
>> >> > You have added new config parameter "DISABLE_BE= FOREUNLOAD_MESSAGE" to make this request configurable, should it be th= e part of preferences setting instead of configuration? @Dave can you pleas= e comment on this.
>> >>
>> >> That does seem like something that should be a per-user p= reference,
>> >> not a global config option.
>> >>
>> >> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not= clear as users perspective, can you please change it to some meaningful na= me.
>> >> >
>> >> > Apart from that code looks good to me.
>> >> >
>> >> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <= ;adi= tya.toshniwal@enterprisedb.com> wrote:
>> >> >>
>> >> >> Hi Hackers,
>> >> >>
>> >> >> Attached is the patch to throw alert warning whe= n user reloads or closes the browser.
>> >> >>
>> >> >> Kindly review.
>> >> >>
>> >> >> --
>> >> >> Thanks and Regards,
>> >> >> Aditya Toshniwal
>> >> >> Software Engineer | EnterpriseDB Software Soluti= ons | Pune
>> >> >> "Don't Complain about Heat, Plant a tre= e"
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Akshay Joshi
>> >> > Sr. Software Architect
>> >> >
>> >> >
>> >> > Phone: +91 20-3058-9517
>> >> > Mobile: +91 976-788-8246
>> >>
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> VP, Chief Architect, Tools & Installers
>> >> EnterpriseDB: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Soft= ware Solutions |=C2=A0Pune
=
"Don't Complain about Heat, Pl= ant a tree"


--
Akshay Joshi
Sr. Software Architect <= br>


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246
--0000000000007f111b058019aaa3--