Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iuX2U-00041k-7l for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 Jan 2020 07:36:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iuX2S-0002sZ-BL for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 Jan 2020 07:36:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iuX2S-0002sM-0K for pgadmin-hackers@lists.postgresql.org; Thu, 23 Jan 2020 07:36:28 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iuX2P-0000D2-3I for pgadmin-hackers@postgresql.org; Thu, 23 Jan 2020 07:36:26 +0000 Received: by mail-io1-xd42.google.com with SMTP id t26so1952841ioi.13 for ; Wed, 22 Jan 2020 23:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SDKpmCthJKnq1L3b4mfMX/NUyi5k9mMIMALxAI8j2Fk=; b=V6SbYvOYMEpbKgOEi8Su+53dyMakfOmpvDel9ETNdHAxFXbdd7hNFJ7kpqJawJj6pB VSYq3K5303b06h+JNdv2NdTc1oDdBEtCNWuWlGNdPhI+az3EFfrZOUmos3FykEMNYBQD /ti/1JriSdJ8BmdYYtxQETdacq5eftLcHqAXDn9dWB8ycayKojx0JkPzSDuNpwS0fDDS AcJCJ66WqBgJQtKjdlBMUgGmqolLv05uBGgS5W1jRWkXZTWyUw1UksDByIWRHXLXTuHe +KPxuxpHG+wRkqq1ecpsCWdg4UoMqFPyx4KjwecEw6VS/t1q5Iq3svVDBrE4HfuFQuj5 IJIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SDKpmCthJKnq1L3b4mfMX/NUyi5k9mMIMALxAI8j2Fk=; b=MR18kZKZpEFAH4l400gLyd/9s3srCTFmT7wGE+tFQpfwvtizGzsiOmpHxIjl0m8SZW 1ETK6Ud3IXFEGzQLWznZlmPPi/bB/qLVfk/L73VX1TSH1j+41vXoCy4p04matvlAfCme tV0R6Gj76h5Ga26Zvc/ktijJZfA2YZObkOeAlIOtPKPRRa3qDjFLh9I6zk4FT+fb8n+v /T/Jy0p4/6uk4XZHnC7hV8iUWNLVrIVDNNnOk+QnLRd6zEaPMP4QF9DmsDx286PLorUh my6kHyOGZV7sRFdfPkB3Dytb0VhCahBSH6ELVEmGOxqa9LB9T66OLbkkFSmZ4YI6AdC3 a9aA== X-Gm-Message-State: APjAAAUqLs5Jcbq7Xi7zT6ljL/yAJrILUZkYIK1d8gtN/UGrkWd6j0ip tqyT7Z9f0ZQjUonYYGWGDZMjl/sjNBYBzzg1w3uXmGTcJAL4iuxM/urJl7p/0lCnmgAdb+qbA+D SSK/yHXiZD/AcEQO43quh4ayYPqXsCTG8YPeNzVDFDhd92sJnxVIs1o3+f7ZR5UBgG2BcBRn0bb +6f0WmsZhJTeCgmNt4T3849A6ftquIFLDS1BG/hFfWzKAYVSYWc5A= X-Google-Smtp-Source: APXvYqyqg47NsBrQqraJDbzDLp6S5Tz6uYFTWazB4102s0HMkN1mH8ldHwcxCAk4lWG7Gso/svXGPH3OHgGB6L5brlk= X-Received: by 2002:a5e:9748:: with SMTP id h8mr10041255ioq.121.1579764984278; Wed, 22 Jan 2020 23:36:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 23 Jan 2020 13:06:13 +0530 Message-ID: Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b77edd059cc9b289" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b77edd059cc9b289 Content-Type: text/plain; charset="UTF-8" Hi Aditya On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow input controls to be set as readonly > instead of disabled. > I've also changed the code for the nodes to make sure properties tab have > readonly fields wherever applicable. This will allow tab navigation in > properties tab and also allow screen readers to read it. > Please note that, I've not visited each and every node create/edit dialog > to identify what should be readonly or what should be disabled as it > depends on business logic. The patch is mainly for the properties tab. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000b77edd059cc9b289 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshn= iwal <aditya.toshni= wal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to a= llow input controls to be set as readonly instead of disabled.
I've als= o changed the code for the nodes to make sure properties tab have readonly = fields wherever applicable. This will allow=C2=A0tab navigation in properti= es tab and also allow screen readers to read it.
Please note that, I've= not visited each and every node create/edit dialog to identify what should= be readonly or what should be disabled as it depends on business logic. Th= e patch is mainly for the properties tab.

Kindly review.
--
=
Thanks and Regards,
Aditya Toshniwal=
pgAdmin Hacker | Sr= . Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about H= eat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000b77edd059cc9b289--