MIME-Version: 1.0
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 28 Jan 2019 18:02:53 +0530
Message-ID: 
 <CANxoLDe5=7hu-K66nXcRHB2sQ84CjEGkBC8Fg=5FFepbh7vbbA@mail.gmail.com>
Subject: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside
 package
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000d16187058083e0ff"
Precedence: bulk

--000000000000d16187058083e0ff
Content-Type: multipart/alternative; boundary="000000000000d16183058083e0fd"

--000000000000d16183058083e0fd
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached is the patch to fix RM 3927 "Unable to debug the procedure inside
package". Problem with the existing code is we assume that "PLDBGBREAK"
will be always found in the first element of the notification list.

In this patch we loop through the list and found the string. Apart from
that patch contains small fix to cancel the transaction of Query Tool when
panel is closed.

Please review it.

-- 
*Akshay Joshi*

*Sr. Software Architect *


*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

--000000000000d16183058083e0fd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Hi Hackers,=C2=A0<div><b=
r></div><div>Attached is the patch to fix RM 3927 &quot;Unable to debug the=
 procedure inside package&quot;. Problem with the existing code is we assum=
e that &quot;PLDBGBREAK&quot; will be always found in the first element of =
the notification list.=C2=A0</div><div><br></div><div>In this patch we loop=
 through the list and found the string. Apart=C2=A0from that patch contains=
 small fix to cancel the transaction of Query Tool when panel is closed.</d=
iv><div><br></div><div>Please review it.=C2=A0=C2=A0</div><div><div><br></d=
iv>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>=
<div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0=
,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"=
>Akshay Joshi</span></b></font></div><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Sr. Software Architect <br></span></b></font></div><di=
v><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:ar=
ial,sans-serif;font-size:13px;border-collapse:collapse"><br></span></b></fo=
nt></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);fo=
nt-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><img sr=
c=3D"http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png" width=
=3D"96" height=3D"54"></span></b></font></div><div><font color=3D"#3333FF">=
<b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:1=
3px;border-collapse:collapse"><br></span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Phone: +91 20-3058-9517<br>Mobil=
e: +91 976-788-8246</span></b></font></div></div></div></div></div></div></=
div></div></div>

--000000000000d16183058083e0fd--

--000000000000d16187058083e0ff
Content-Type: application/octet-stream; name="RM_3927.patch"
Content-Disposition: attachment; filename="RM_3927.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jrgbahl50>
X-Attachment-Id: f_jrgbahl50

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL19faW5pdF9fLnB5IGIvd2Vi
L3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvX19pbml0X18ucHkKaW5kZXggNzA5ZTE2NC4uNGRmYjdl
NyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvX19pbml0X18ucHkKKysr
IGIvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvX19pbml0X18ucHkKQEAgLTQwMiw2ICs0MDIs
NyBAQCBkZWYgY2xvc2UodHJhbnNfaWQpOgogCiAgICAgICAgICMgUmVsZWFzZSB0aGUgY29ubmVj
dGlvbgogICAgICAgICBpZiBjb25uLmNvbm5lY3RlZCgpOgorICAgICAgICAgICAgIyBjb25uLmNh
bmNlbF90cmFuc2FjdGlvbihjbWRfb2JqLmNvbm5faWQsIGNtZF9vYmouZGlkKQogICAgICAgICAg
ICAgbWFuYWdlci5yZWxlYXNlKGRpZD1jbWRfb2JqLmRpZCwgY29ubl9pZD1jbWRfb2JqLmNvbm5f
aWQpCiAKICAgICAgICAgIyBSZW1vdmUgdGhlIGluZm9ybWF0aW9uIG9mIHVuaXF1ZSB0cmFuc2Fj
dGlvbiBpZCBmcm9tIHRoZQpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIv
X19pbml0X18ucHkgYi93ZWIvcGdhZG1pbi90b29scy9kZWJ1Z2dlci9fX2luaXRfXy5weQppbmRl
eCA5ZTVmZjkxLi5jOWYxYTRlIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9kZWJ1Z2dl
ci9fX2luaXRfXy5weQorKysgYi93ZWIvcGdhZG1pbi90b29scy9kZWJ1Z2dlci9fX2luaXRfXy5w
eQpAQCAtMTMwMSwyMCArMTMwMSwyMiBAQCBkZWYgbWVzc2FnZXModHJhbnNfaWQpOgogICAgICAg
ICAgICAgIyBGcm9tIHRoZSBhYm92ZSBtZXNzYWdlIHdlIG5lZWQgdG8gZmluZCBvdXQgcG9ydCBu
dW1iZXIKICAgICAgICAgICAgICMgYXMgIjciIHNvIGJlbG93IGxvZ2ljIHdpbGwgZmluZCA3IGFz
IHBvcnQgbnVtYmVyCiAgICAgICAgICAgICAjIGFuZCBhdHRhY2ggbGlzdGVuZWQgdG8gdGhhdCBw
b3J0IG51bWJlcgotICAgICAgICAgICAgb2Zmc2V0ID0gbm90aWZ5WzBdLmZpbmQoJ1BMREJHQlJF
QUsnKQotICAgICAgICAgICAgc3RyX2xlbiA9IGxlbignUExEQkdCUkVBSycpCi0gICAgICAgICAg
ICBzdHJfbGVuICs9IDEKLSAgICAgICAgICAgIHRtcE9mZnNldCA9IDAKLSAgICAgICAgICAgIHRt
cEZsYWcgPSBGYWxzZQorICAgICAgICAgICAgcG9ydF9mb3VuZCA9IEZhbHNlCisgICAgICAgICAg
ICBmb3IgdmFsIGluIG5vdGlmeToKKyAgICAgICAgICAgICAgICBvZmZzZXQgPSB2YWwuZmluZCgn
UExEQkdCUkVBSycpCisgICAgICAgICAgICAgICAgaWYgb2Zmc2V0IDwgMDoKKyAgICAgICAgICAg
ICAgICAgICAgY29udGludWUKIAotICAgICAgICAgICAgd2hpbGUgbm90aWZ5WzBdW29mZnNldCAr
IHN0cl9sZW4gKyB0bXBPZmZzZXRdLmlzZGlnaXQoKToKLSAgICAgICAgICAgICAgICBzdGF0dXMg
PSAnU3VjY2VzcycKLSAgICAgICAgICAgICAgICB0bXBGbGFnID0gVHJ1ZQotICAgICAgICAgICAg
ICAgIHBvcnRfbnVtYmVyID0gcG9ydF9udW1iZXIgKyBcCi0gICAgICAgICAgICAgICAgICAgIG5v
dGlmeVswXVtvZmZzZXQgKyBzdHJfbGVuICsgdG1wT2Zmc2V0XQotICAgICAgICAgICAgICAgIHRt
cE9mZnNldCArPSAxCisgICAgICAgICAgICAgICAgb2Zmc2V0ID0gb2Zmc2V0ICsgbGVuKCdQTERC
R0JSRUFLJykgKyAxCisgICAgICAgICAgICAgICAgdG1wT2Zmc2V0ID0gMAorCisgICAgICAgICAg
ICAgICAgd2hpbGUgdmFsW29mZnNldCArIHRtcE9mZnNldF0uaXNkaWdpdCgpOgorICAgICAgICAg
ICAgICAgICAgICBzdGF0dXMgPSAnU3VjY2VzcycKKyAgICAgICAgICAgICAgICAgICAgcG9ydF9m
b3VuZCA9IFRydWUKKyAgICAgICAgICAgICAgICAgICAgcG9ydF9udW1iZXIgPSBwb3J0X251bWJl
ciArIHZhbFtvZmZzZXQgKyB0bXBPZmZzZXRdCisgICAgICAgICAgICAgICAgICAgIHRtcE9mZnNl
dCArPSAxCiAKLSAgICAgICAgICAgIGlmIG5vdCB0bXBGbGFnOgorICAgICAgICAgICAgaWYgbm90
IHBvcnRfZm91bmQ6CiAgICAgICAgICAgICAgICAgc3RhdHVzID0gJ0J1c3knCiAgICAgICAgIGVs
c2U6CiAgICAgICAgICAgICBzdGF0dXMgPSAnQnVzeScK
--000000000000d16187058083e0ff--