MIME-Version: 1.0
References: 
 <CAOBg0AP5qPSeQTszGraKxJ9DLt5-Qd7ikuU8oa1OJTpnmX4MPA@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AP5qPSeQTszGraKxJ9DLt5-Qd7ikuU8oa1OJTpnmX4MPA@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Wed, 17 Nov 2021 18:34:32 +0530
Message-ID: 
 <CANxoLDe5mEx_pM85YarO_qeSa+_wOvThOuvPbtMfA3_3b4XhKw@mail.gmail.com>
Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup
 object dialog in React
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000008782b805d0fbaf0e"
Archived-At: 
 <https://www.postgresql.org/message-id/CANxoLDe5mEx_pM85YarO_qeSa%2B_wOvThOuvPbtMfA3_3b4XhKw%40mail.gmail.com>
Precedence: bulk

--0000000000008782b805d0fbaf0e
Content-Type: text/plain; charset="UTF-8"

Hi Nikhil

Following are the review comments:

GUI:

   - Dialog size should be increased.
   - Remove the first blank element from the Encoding dropdown.
   - When opening the file dialog header should have the title 'Select
   file'.
   - 'Backup server' title should be changed to 'Backup Server'.
   - When taking the backup of any object like database, schema, etc..
   the title on the dialog header should be "Backup (Database/Schema ..."
   instead of  "Backup (database/schema ..."


Code:

   - Jasmine test cases are failing.
   - Remove warnBeforeChangesLost function not needed for Utilities.
   (Remove Alertify as well)
   - The naming convention should be identical, in some cases, you used
   camel case and in some cases used with an underscore.
   - Remove the commented code from all the files.
   - Take all the screenshots again with a width of 681.

Note: I haven't tested it thoroughly with all combinations.

On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite <
nikhil.mohite@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6884:
> <https://redmine.postgresql.org/issues/6984>  Port Backup Global, Backup
> Server, and Backup object dialog in React
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--0000000000008782b805d0fbaf0e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Nikhil<div><br></div><div>Following are the review comm=
ents:</div><div><br></div><div>GUI:</div><div><ul><li>Dialog size should be=
 increased.</li><li>Remove the first blank element from the Encoding dropdo=
wn.</li><li>When opening the file dialog header should have the title &#39;=
Select file&#39;.</li><li>&#39;Backup server&#39; title should be changed t=
o &#39;Backup Server&#39;.</li><li>When taking the backup of any object lik=
e database, schema, etc.. the=C2=A0title on the dialog header should be &qu=
ot;Backup (Database/Schema ...&quot; instead of=C2=A0 &quot;Backup (databas=
e/schema ...&quot;</li></ul></div><div><br></div><div>Code:<br><ul><li>Jasm=
ine test cases are failing.</li><li>Remove warnBeforeChangesLost function n=
ot needed for Utilities. (Remove Alertify as well)</li><li>The naming conve=
ntion should be identical, in some cases, you used camel case and in some c=
ases used with an underscore.</li><li>Remove the commented code from all th=
e files.</li><li>Take all the screenshots again with a width of 681.</li></=
ul>Note: I haven&#39;t tested it thoroughly with all combinations.</div></d=
iv><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On =
Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite &lt;<a href=3D"mailto:nikhil.moh=
ite@enterprisedb.com">nikhil.mohite@enterprisedb.com</a>&gt; wrote:<br></di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hac=
kers,<div><br></div><div>Please find the attached patch for=C2=A0<a href=3D=
"https://redmine.postgresql.org/issues/6984" target=3D"_blank">RM-6884:</a>=
=C2=A0 Port Backup Global, Backup Server, and Backup object dialog in React=
</div><div><br></div><div><br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr=
"><b><font face=3D"arial, sans-serif">Thanks &amp; Regards,</font></b><div>=
<b><font face=3D"arial, sans-serif">Nikhil Mohite</font></b></div><div><b><=
font face=3D"arial, sans-serif">Senior Software Engineer.</font></b></div><=
div><a href=3D"https://www.enterprisedb.com/" target=3D"_blank"><b><font fa=
ce=3D"arial, sans-serif">EDB Postgres</font></b></a></div><div><b><font fac=
e=3D"arial, sans-serif">Mob.No: +91-7798364578.</font></b></div></div></div=
></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--0000000000008782b805d0fbaf0e--