Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqdA2-0003HT-JU for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Feb 2019 12:15:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gqdA1-00084A-EA for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Feb 2019 12:15:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqdA1-00081J-6W for pgadmin-hackers@lists.postgresql.org; Mon, 04 Feb 2019 12:15:37 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqd9x-0000mD-JQ for pgadmin-hackers@postgresql.org; Mon, 04 Feb 2019 12:15:36 +0000 Received: by mail-qt1-x841.google.com with SMTP id v11so15111231qtc.2 for ; Mon, 04 Feb 2019 04:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wqip1g1DTp+GWN+ZRBhKJcQWp5ff331affCG6KU6jGU=; b=Ad2gZWLcxtDUM5/wh480McfVY8rSauCi1Rfo+oC7VJ54S2CgfJISwHrgVJmStFbUEs HUzTyMjX/sg/x0Ppe5lImwYMgT1+rhOKMg5GCtIaNkxKvG8hQphq1Rg/Y0QuBfBVgqzk oYrMcFNBrtOKTcY9FGHmTvxwq4zMUaYL9pIzpqVQB+wTm0t2y+x7aALHvf/FLiq3V2xh jprhMe0qadzKZW+yX0yg7NIlbrLjmAd51ErX31YvMM03GVlh/gHIE2mFUDgr5RlWVaCs cdTeHEv6akfortDXtZUOnjDy2EZv/vyvmVq6s0womvHt8uu9Bp9mlHrJMRZHfgIBwp1I TjbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wqip1g1DTp+GWN+ZRBhKJcQWp5ff331affCG6KU6jGU=; b=Thxw+vBcA+cnt9QOwJPeq5ZvLxvqFPqCH1iG1R86ILU6DwsTNNcSMkd1LCJFCVJicF ecNXfMKkRgruZYqBsK485jPBf8mXVMMKebXKrmFlqBPDnvttdS7JvEJdggxq/d/X7FQ3 xyNuaDrP6BvPI51MCs2JQn9sssRbdJcrl86l5NNb4RhotLLs2MsDy31F6yfS4Gpcx7ZQ v3AJnUf4AKqF7NqY0iAcEQYRkeITiZGn0gRx55A0c+I3xCkCeUNDucQrY+l/B6pJZWoC em2mtfy9lh+Wswh7zscubQDhldiDJeh4DFeTEChnIbUyunWagVsighn2+Fai12K2GjxR JqYw== X-Gm-Message-State: AJcUukfxENBNYTXd+lBTRF/ZxUFeyzfk2JrHqJL7JDQdRCTITcsosiet UCkfx9PDfYaoR3zMx3FpmCbuWrd8jNLJzuBAY8/8SQ== X-Google-Smtp-Source: ALg8bN7M6rL2yVelIsMSmGZrU3XHEMcaiqlRYRy7fwNyyCu3wiJso3bb918ilCTfwXuCTinML40npXOz+w6IjCYnbe0= X-Received: by 2002:aed:3ee4:: with SMTP id o33mr48498976qtf.354.1549282531570; Mon, 04 Feb 2019 04:15:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 4 Feb 2019 17:45:20 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations To: Aditya Toshniwal Cc: Dave Page , Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f38a5b05811072b5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f38a5b05811072b5 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Mon, Feb 4, 2019 at 5:36 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix jasmine test cases. Didn't realise the > timezones could create issues :( > Kindly review. > > On Mon, Feb 4, 2019 at 4:17 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to change the dashboard test cases to fetch >> server_id similar to how it is done in other test cases. >> >> Kindly review. >> >> On Mon, Feb 4, 2019 at 3:43 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks patch applied. >>> >>> On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the updated patch. The poller will wait 3 times the normal >>>> interval before sending new request if the previous request is pending. >>>> After that, it will send the ajax. >>>> >>>> Kindly review. >>>> >>>> On Mon, Feb 4, 2019 at 3:12 PM Dave Page wrote: >>>> >>>>> I can't get to this right now, but Akshay, can we get it in before the >>>>> release? >>>>> >>>>> I don't think the problem Khushboo notes is really a problem. Waiting >>>>> for a response before issuing another one seems sensible... as long as >>>>> there's a timeout so things don't get stuck if a response gets lost >>>>> somehow. Maybe the timeout should be something like 3x the normal interval? >>>>> >>>>> On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Aditya, >>>>>> >>>>>> I have reviewed the patch and it looks good to me except the logic to >>>>>> wait until we get the response from the AJAX request. >>>>>> So, in this case at a time only one request is being sent to the >>>>>> server. >>>>>> >>>>>> @ Dave/Ashesh, if you think this is okay then we can commit the patch. >>>>>> >>>>>> Thanks, >>>>>> Khushboo >>>>>> >>>>>> On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Khushboo >>>>>>> >>>>>>> Can you please review it. >>>>>>> >>>>>>> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal < >>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> Attached is the patch to optimise the dashboard. Changes include: >>>>>>>> 1) One ajax request for the all the charts instead of separate for >>>>>>>> every chart. The next request will not hit until the previous is completed. >>>>>>>> 2) The code will check for intervals which is greatest common >>>>>>>> divisor of all the refresh rates. Chart names which will be eligible for >>>>>>>> refresh will be sent with the ajax. If none are eligible, no ajax will be >>>>>>>> fired. >>>>>>>> 3) In the backend, query is generated in such a way that data for >>>>>>>> all the requested chart names will be fetched in one hit to the database. >>>>>>>> 4) Test cases for charts rest api and javascript added. >>>>>>>> >>>>>>>> -- >>>>>>>> Thanks and Regards, >>>>>>>> Aditya Toshniwal >>>>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>>>> "Don't Complain about Heat, Plant a tree" >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Akshay Joshi* >>>>>>> >>>>>>> *Sr. Software Architect * >>>>>>> >>>>>>> >>>>>>> >>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> "Don't Complain about Heat, Plant a tree" >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000f38a5b05811072b5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Mon, Feb 4, 2019 at 5:36 PM Aditya= Toshniwal <aditya.= toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patc= h to fix jasmine test cases. Didn't realise the timezones could create = issues :(
Kindly review.

On Mon, Feb 4, 2019 at 4:17 PM Aditya Toshniw= al <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached i= s the patch to change the dashboard test cases to fetch server_id similar t= o how it is done=C2=A0in other test cases.

Kindly review.
<= br>
On Mon,= Feb 4, 2019 at 3:43 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrot= e:
Thanks patch applied.

On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal &l= t;ad= itya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is t= he updated patch. The poller will wait 3 times the normal interval before s= ending new request if the previous request is pending. After that, it will = send the ajax.

Kindly review.

On Mon, Feb 4, 2019 at 3:12 PM Dave= Page <dpage@pgad= min.org> wrote:
I can't get to this right now, but Akshay, can = we get it in before the release?

I don't think the p= roblem Khushboo notes is really a problem. Waiting for a response before is= suing another one seems sensible... as long as there's a timeout so thi= ngs don't get stuck if a response gets lost somehow. Maybe the timeout = should be something like 3x the normal interval?

On Mon, Feb 4, 2019 = at 9:02 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
<= /div>
Hi = Aditya,

I have reviewed the patch and it looks good to m= e except the logic to wait until we get the response from the AJAX request.=
So, in this case at a time only one request is being sent to the= server.

@ Dave/Ashesh, if you think this is okay = then we can commit the patch.

Thanks,
Kh= ushboo

On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <akshay.joshi@enterpris= edb.com> wrote:
Hi Khushboo

Can you please revie= w it.

On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <aditya.toshniwal= @enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to opti= mise the dashboard. Changes include:
1) One ajax request for the all the ch= arts instead of separate for every chart. The next request will not hit unt= il the previous is completed.
2) The code will check for intervals which is= greatest common divisor of all the refresh rates. Chart names which will b= e eligible for refresh will be sent with the ajax. If none are eligible, no= ajax will be fired.
3) In the backend, query is generated in such a way th= at data for all the requested chart names will be fetched in one hit to the= database.
4) Test cases for charts rest api and javascript added.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"


--
Akshay Joshi
Sr. Software Architect
<= /font>

=

Phone: +91 20-3058= -9517
Mobile: +91 976-788-8246
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

= EnterpriseDB UK: = http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software = Solutions |=C2=A0Pune
= "Don't Complain about Heat, Plant a= tree"


--
Akshay Joshi


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /span>


--
Thanks and Regards,
Aditya Toshniwal
=
Software Engineer |=C2=A0E= nterpriseDB Software Solutions |=C2=A0P= une
"Don't Complai= n about Heat, Plant a tree"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000f38a5b05811072b5--