public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL
Date: Fri, 15 Jun 2018 12:21:36 +0530
Message-ID: <CANxoLDe6vNh+Svf1rHPWSZX_9sOejJSrWbwUo7HEjj-QAO7Ffg@mail.gmail.com> (raw)
Hi Hackers,
Attached is the patch for RM #3356 pgAdmin 4 does not include schema name
in generated package SQL. Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachments:
[application/octet-stream] RM_3356.patch (822B, 3-RM_3356.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
index 9aa5c9b..1013207 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
@@ -688,7 +688,7 @@ class PackageView(PGChildNodeView):
res['rows'][0].setdefault(row['deftype'], []).append(priv)
result = res['rows'][0]
- sql, name = self.getSQL(gid, sid, did, result, scid)
+ sql, name = self.getSQL(gid, sid, did, result, scid, pkgid)
# Most probably this is due to error
if not isinstance(sql, (str, unicode)):
return sql
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL
In-Reply-To: <CANxoLDe6vNh+Svf1rHPWSZX_9sOejJSrWbwUo7HEjj-QAO7Ffg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox