Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jGcNm-0006nO-3Y for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 Mar 2020 05:45:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jGcNk-0002qt-Ub for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 Mar 2020 05:45:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jGcNk-0002qm-C7 for pgadmin-hackers@lists.postgresql.org; Tue, 24 Mar 2020 05:45:44 +0000 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jGcNf-0000Yu-Gm for pgadmin-hackers@postgresql.org; Tue, 24 Mar 2020 05:45:43 +0000 Received: by mail-il1-x144.google.com with SMTP id m7so11555380ilg.5 for ; Mon, 23 Mar 2020 22:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2SkOq3v+qiO0BNkIbS3njn44bo67L2ihhnwO5fRuo/4=; b=h1JOL/piLCwzr+ioueAikgdpegF59yG8ZzrxF6CvvbtEz+dpxXg6wwpDvJDmYNoXDO +rYgLJyxgFxh/sqiHyv0MtIFD1zhpiOrgdzqo4DnY6h9OMMJrkAnddWlbZ8emgyuRL4k yJ2nau3GtmRf7bmsA0iiVGuQkpFclir+80bgY/tYpGXvDaPRHHlkLnoa4CG0lsR3/84i FibWCOTFg9DZciWn1GD/l/gZZT6Xd8olPAXW/PHdzyowi+1xqbaf9SdUJVQD/mBmsAj/ WiWA4aI5ohz4axZgQHlA7YJawdiWka7ObUFWiYdt7azAjm0JaDGl1Qoh7fEgyzUPZt5k Iv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2SkOq3v+qiO0BNkIbS3njn44bo67L2ihhnwO5fRuo/4=; b=jkV39zOje7odckMDYlBx8x1u78YysmaGLZq7R4y2UKjhRJPnCD2Ytto3LP8e+shdt0 oB+x+blSyie0+MEDxLM3PmafPJHPS9rxzr8NFf+i92nMFwV1N8t6d57xddL0nReGRDEA 0AfLDqPbnex3X616rK6eSzqTojfFLvEu7ImCnvwWvXDW0aat9dW8okESqFW1hKu6BmLV jT2HiuEYyHvSOmruHriwnLjHPOWMqVIbmpP5LpXAoSnwuzCtHO6/F8id774gaue47lVf ShmXaqsXRUCbv3O+BicKQMCSJxv9tSQx9Ey5aBdYwwlscDfsBSDQPrKdqWzj8KCXyiIc aufg== X-Gm-Message-State: ANhLgQ2IBHR/LBTNTJfOXtgGL8K5HbcrSbxBFG/JJ6rKm+briQNykHae 3R6ufTzfE8J1ai7O9CjejjAN5lGl6gSPrFmrvp51lmfAlfMBatUii9aw7gdHBJtV5/EnaIvuQYN 8er6MkN4Kud1L8vb+2z6bBZuCx5tC0y3RjAFurwEHmpbWR0wuaKZXpEppwhLMd3qHiRGf7Ad1bO 9q1u6xUaLl/yuN8X07a8or/Wa0cDdRLsidGMf5zzLNmEn9oduaetI= X-Google-Smtp-Source: ADFU+vu9ghgMhWAtkPB3b+O+Dwy9GPapjY9Q+R2A0SRpLPpdI0eXsyMpYPcofHkoobG0Mgc+gBkphD/SUwvf6z6fz0U= X-Received: by 2002:a92:8c45:: with SMTP id o66mr25118898ild.236.1585028738713; Mon, 23 Mar 2020 22:45:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 24 Mar 2020 11:15:27 +0530 Message-ID: Subject: Re: pgAdmin 4 - gettext usage fixes To: Aditya Toshniwal Cc: "Libor M." , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ee254c05a19342c9" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ee254c05a19342c9 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Mar 24, 2020 at 11:06 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Please find the updated patch with pep8, linter issues fixed. > > > On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Libor, >> >> Thank you for the patch. It is good clean up patch. >> I've made a few changes in the patch. You've imported sprintf which was >> not required since gettext also works as sprintf directly. >> I've also created a housekeeping redmine ticket to track it - >> https://redmine.postgresql.org/issues/5284 >> >> The messages compile fine. The patch can be committed. >> Please find the attached updated patch. >> >> >> >> On Mon, Mar 23, 2020 at 4:00 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Can you please review this? >>> >>> On Mon, Mar 23, 2020 at 5:00 AM Libor M. wrote: >>> >>>> Hello, >>>> I fixed using gettext function and add more usages for translations, >>>> specifically: >>>> >>>> - fixed usage gettext('') instead of _('') in javascript files >>>> - fixed usage gettext('') instead of `${gettext('')}` in javascript >>>> files, because "pybabel extract" not support extracting from this >>>> syntax >>>> - added a lot of gettext for support translations >>>> >>>> Diff file is attached. >>>> >>>> Best regards, >>>> >>>> Libor M. >>>> >>>> E-mail: liborm85@gmail.com >>>> GitHub: https://github.com/liborm85 >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000ee254c05a19342c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Mar 24, 2020 at 11:06 AM Adi= tya Toshniwal <adit= ya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Please find the updated patch with pep8, linter issu= es fixed.


On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal <aditya.= toshniwal@enterprisedb.com> wrote:
Hi Libor,

Thank you for t= he patch. It is good clean=C2=A0up patch.
I've made a few changes in the patch. You've impo= rted sprintf which was not required since gettext also works as sprintf dir= ectly.
I've also cre= ated a housekeeping redmine ticket to track it -=C2=A0https://redmine.postgresql.org/issues/5284

The messages compile fine. The patch can be c= ommitted.
Please find th= e attached updated patch.


<= br>
On Mon,= Mar 23, 2020 at 4:00 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wro= te:
Hi Aditya

Can you please review this?
On Mon, = Mar 23, 2020 at 5:00 AM Libor M. <liborm85@gmail.com> wrote:
Hello,
I fixed using gettext function and add more usages for translations,
specifically:

- fixed usage gettext('') instead of _('') in javascript fi= les
- fixed usage gettext('') instead of `${gettext('')}` in ja= vascript
files, because "pybabel extract" not support extracting from this=
syntax
- added a lot of gettext for support translations

Diff file is attached.

Best regards,

Libor M.

E-mail: liborm85@gm= ail.com
GitHub: https://github.com/liborm85


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000ee254c05a19342c9--